Fisheye on dialin/tests/test_conductivity.py

DIALIN-DENBUG-280-4: closed by Michael Garthwaite

Michael Garthwaite — Wed, 06 Nov 2024 15:20:04 -0800

Michael Garthwaite Closed DIALIN-DENBUG-280-4

DIALIN-DENBUG-280-1: closed by Michael Garthwaite

Michael Garthwaite — Wed, 06 Nov 2024 15:19:54 -0800

Michael Garthwaite Closed DIALIN-DENBUG-280-1

DIALIN-DENBUG-280-4: reviewers finished

Mon, 04 Nov 2024 10:29:29 -0800

Sean Nash finished reviewing DIALIN-DENBUG-280-4

DIALIN-DENBUG-280_Issues With HD Broadcast P1

DIALIN-DENBUG-280-4: started by Dara Navaei

Dara Navaei — Sat, 02 Nov 2024 16:01:22 -0700

Dara Navaei started review DIALIN-DENBUG-280-4

DIALIN-DENBUG-280-1: reviewers joined DIALIN-DENBUG-280_Issues With HD Broadcast P1B

Thu, 31 Oct 2024 11:03:43 -0700

Dara Navaei joined DIALIN-DENBUG-280-1

DIALIN-DENBUG-280_Issues With HD Broadcast P1B

DIALIN-DENBUG-280-1: reviewers removed from DIALIN-DENBUG-280_Issues With HD Broadcast P1B

Thu, 31 Oct 2024 11:03:43 -0700

Dara Navaei removed Michael Garthwaite from DIALIN-DENBUG-280-1

DIALIN-DENBUG-280_Issues With HD Broadcast P1B

DIALIN-DENBUG-280-1: started by Dara Navaei

Dara Navaei — Thu, 31 Oct 2024 11:02:51 -0700

Dara Navaei started review DIALIN-DENBUG-280-1

DIALIN-DIAL-299-1: closed by Michael Garthwaite

Michael Garthwaite — Mon, 01 Jul 2024 10:16:48 -0700

Michael Garthwaite Closed DIALIN-DIAL-299-1

DIALIN-DIAL-299-1: comment by Michael Garthwaite "This CR should be closed due to bad branching. ..."

Michael Garthwaite — Mon, 01 Jul 2024 10:16:33 -0700

Michael Garthwaite commented on DIALIN-DIAL-299-1

This CR should be closed due to bad branching. Should have been branched out of p1_staging.

DIALIN-DIAL-299-1: started by Dara Navaei

Dara Navaei — Wed, 26 Jun 2024 12:01:20 -0700

Dara Navaei started review DIALIN-DIAL-299-1

dialin (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 02 Jan 2023 17:11:32 -0800

Dara Navaei committed acd09d0 on branch DEN-13154-heparin-syringe-empty-position-incorrect, DEN-13903-s80-mg-DIAL-205 and 163 more in dialin

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /README.md

(-1, +1)

| History

| Source

| Diff

· /build.sh

(-1, +1)

| History

| Source

| Diff

· /dialin/common/alarm_defs.py

(-1, +1)

| History

| Source

| Diff

· /dialin/common/alarm_priorities.py

(-1, +1)

| History

| Source

| Diff

· /dialin/common/dg_defs.py

(-1, +1)

| History

| Source

| Diff

· /dialin/common/hd_defs.py

(-1, +1)

| History

| Source

| Diff

· /dialin/common/msg_defs.py

(-1, +1)

| History

| Source

| Diff

· /dialin/common/msg_ids.py

(-1, +1)

| History

| Source

| Diff

· /dialin/common/prs_defs.py

(-1, +1)

| History

| Source

| Diff

· /dialin/common/ui_defs.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/__init__.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/accelerometer.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/alarms.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/calibration_record.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/chemical_disinfect.py

(-1, +1)

| History

| Source

| Diff

… 169 more files in changeset.

DIALIN-DEN-12716-1: closed by Behrouz NematiPour

Behrouz NematiPour — Thu, 08 Sep 2022 17:26:45 -0700

Behrouz NematiPour Closed DIALIN-DEN-12716-1

DIALIN-DEN-12716-1: reviewers finished

Thu, 08 Sep 2022 17:04:13 -0700

Sean Nash , Tiffany Mejia and Michael Garthwaite finished reviewing DIALIN-DEN-12716-1

DIALIN-DEN-12716_UI BN S70

DIALIN-DEN-12716-1: comment by Sean Nash "Ok, let's do that. RESOLVED."

Sean Nash — Thu, 08 Sep 2022 17:02:54 -0700

Sean Nash replied to Behrouz NematiPour in DIALIN-DEN-12716-1

Ok, let's do that. RESOLVED.

DIALIN-DEN-12716-1: comment by Michael Garthwaite "RESOLVED."

Michael Garthwaite — Thu, 08 Sep 2022 16:28:30 -0700

Michael Garthwaite replied to Behrouz NematiPour in DIALIN-DEN-12716-1

RESOLVED.

DIALIN-DEN-12716-1: comment by Michael Garthwaite "RESOLVED."

Michael Garthwaite — Thu, 08 Sep 2022 16:28:19 -0700

Michael Garthwaite replied to Behrouz NematiPour in DIALIN-DEN-12716-1

RESOLVED.

DIALIN-DEN-12716-1: comment by Behrouz NematiPour "updated"

Behrouz NematiPour — Thu, 08 Sep 2022 16:13:06 -0700

Behrouz NematiPour replied to Michael Garthwaite in DIALIN-DEN-12716-1

updated

DIALIN-DEN-12716-1: comment by Behrouz NematiPour "Updated."

Behrouz NematiPour — Thu, 08 Sep 2022 16:12:54 -0700

Behrouz NematiPour replied to Michael Garthwaite in DIALIN-DEN-12716-1

Updated.

DIALIN-DEN-12716-1: comment by Behrouz NematiPour "I totally agree. This is the Dialin design, I ..."

Behrouz NematiPour — Tue, 26 Jul 2022 17:43:41 -0700

Behrouz NematiPour replied to Sean Nash in DIALIN-DEN-12716-1

I totally agree.
This is the Dialin design, I am just using the API.
I think we should create a task on the Dialin board and follow up on that ticket.

DIALIN-DEN-12716-1: comment by Michael Garthwaite "was MSG_ID_HD_ACCELEROMETER_DATA supposed to be..."

Michael Garthwaite — Thu, 07 Jul 2022 13:24:57 -0700

Michael Garthwaite commented on DIALIN-DEN-12716-1

was MSG_ID_HD_ACCELEROMETER_DATA supposed to be removed as well?

DIALIN-DEN-12716-1: comment by Michael Garthwaite "Please add data types of the parameters."

Michael Garthwaite — Wed, 06 Jul 2022 11:05:17 -0700

Michael Garthwaite commented on DIALIN-DEN-12716-1

Please add data types of the parameters.

DIALIN-DEN-12716-1: comment by Sean Nash "Not sure a list is appropriate. And if list do..."

Sean Nash — Wed, 06 Jul 2022 09:27:55 -0700

Sean Nash replied to Behrouz NematiPour in DIALIN-DEN-12716-1

Not sure a list is appropriate. And if list does make sense, should probably be a list of messages that do require ACK (as generally we do not want Dialin ACKing - we want Dialin to be passive and let HD/DG/UI do the ACKing). Let's discuss with Michael.

DIALIN-DEN-12716-1: comment by Sean Nash "RESOLVED."

Sean Nash — Wed, 06 Jul 2022 09:27:02 -0700

Sean Nash replied to Behrouz NematiPour in DIALIN-DEN-12716-1

RESOLVED.

DIALIN-DEN-12716-1: comment by Sean Nash "RESOLVED."

Sean Nash — Wed, 06 Jul 2022 09:26:49 -0700

Sean Nash replied to Behrouz NematiPour in DIALIN-DEN-12716-1

RESOLVED.

DIALIN-DEN-12716-1: comment by Sean Nash "RESOLVED."

Sean Nash — Wed, 06 Jul 2022 09:26:34 -0700

Sean Nash replied to Behrouz NematiPour in DIALIN-DEN-12716-1

RESOLVED.

DIALIN-DEN-12716-1: comment by Sean Nash "What criteria is used to determine whether a me..."

Sean Nash — Fri, 01 Jul 2022 10:46:56 -0700

Sean Nash commented on DIALIN-DEN-12716-1

What criteria is used to determine whether a message is included in this list?

DIALIN-DEN-12716-1: comment by Behrouz NematiPour "Wow, eagle-eye, duplicates removed."

Behrouz NematiPour — Fri, 01 Jul 2022 17:49:35 -0700

Behrouz NematiPour replied to Sean Nash in DIALIN-DEN-12716-1

Wow, eagle-eye,
duplicates removed.

DIALIN-DEN-12716-1: comment by Behrouz NematiPour "duplicates removed."

Behrouz NematiPour — Fri, 01 Jul 2022 17:49:25 -0700

Behrouz NematiPour replied to Sean Nash in DIALIN-DEN-12716-1

duplicates removed.

DIALIN-DEN-12716-1: comment by Behrouz NematiPour "Wow, eagle-eye, duplicates removed."

Behrouz NematiPour — Fri, 01 Jul 2022 17:49:14 -0700

Behrouz NematiPour replied to Sean Nash in DIALIN-DEN-12716-1

Wow, eagle-eye,
duplicates removed.

DIALIN-DEN-12716-1: comment by Behrouz NematiPour "Probably because assuming that the list of ACK_..."

Behrouz NematiPour — Fri, 01 Jul 2022 11:03:18 -0700

Behrouz NematiPour replied to Sean Nash in DIALIN-DEN-12716-1

Probably because assuming that the list of ACK_NOT_REQUIRED messages (at least at the time of implementation) was a shorter list.