Fisheye on application/sources/model/dg/data/MDGPressuresData.cpp

UI-DEN-12031-2: closed by Dara Navaei

Dara Navaei — Tue, 19 Nov 2024 15:27:58 -0800

Dara Navaei Closed UI-DEN-12031-2

UI-DEN-12031-2: reviewers finished

Tue, 19 Nov 2024 13:54:25 -0800

Behrouz NematiPour and Dara Navaei finished reviewing UI-DEN-12031-2

UI-DEN-12031_Leahi/Features/Den 12031 UI AM Models Nested Ifs

UI-DEN-12031-2: started by Dara Navaei

Dara Navaei — Tue, 19 Nov 2024 13:27:27 -0800

Dara Navaei started review UI-DEN-12031-2

UI-DEN-SUNRISE-1: closed by Dara Navaei

Dara Navaei — Fri, 15 Nov 2024 12:54:28 -0800

Dara Navaei Closed UI-DEN-SUNRISE-1

UI-DEN-SUNRISE-1: reviewers removed from UI-DEN-SUNRISE

Fri, 07 Jun 2024 09:05:01 -0700

Dara Navaei removed Sean Nash and vduong (deleted user) from UI-DEN-SUNRISE-1

UI-DEN-SUNRISE

UI-DEN-SUNRISE-1: started by Dara Navaei

Dara Navaei — Fri, 07 Jun 2024 09:04:34 -0700

Dara Navaei started review UI-DEN-SUNRISE-1

UI-UCOMMITS-3: closed by Sean Nash

Sean Nash — Thu, 03 Aug 2023 14:23:52 -0700

Sean Nash Closed UI-UCOMMITS-3

UI-UCOMMITS-3: reviewers finished

Thu, 03 Aug 2023 14:05:13 -0700

Dara Navaei finished reviewing UI-UCOMMITS-3

UI Staging Unreviewed Commits

UI-UCOMMITS-3: reviewers finished

Wed, 02 Aug 2023 09:33:38 -0700

Sean Nash finished reviewing UI-UCOMMITS-3

UI Staging Unreviewed Commits

UI-UCOMMITS-3: started by Dara Navaei

Dara Navaei — Mon, 08 May 2023 08:49:03 -0700

Dara Navaei started review UI-UCOMMITS-3

application (bugfix/DEN-16597-UI-BN-S114): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 10 Feb 2023 10:12:20 -0800

Dara Navaei committed af8d98b on branch master, @Environement_Swith and 176 more in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /cppcheck.sh

(-1, +1)

| History

| Source

| Diff

· /imake.sh

(-1, +1)

| History

| Source

| Diff

· /main.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/CanInterface.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/FrameInterface.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/MessageAcknowModel.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/MessageGlobals.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/MessageInterpreter.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/cloudsync/CloudSyncController.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/cloudsync/CloudSyncController.h

(-1, +1)

| History

| Source

| Diff

· /sources/device/DeviceController.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/gui/GuiController.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/gui/GuiView.h

(-1, +1)

| History

| Source

| Diff

· /sources/gui/qml/PowerItem.qml

(-1, +1)

| History

| Source

| Diff

· /sources/gui/qml/components/DebugDataColumn.qml

(-1, +1)

| History

| Source

| Diff

… 36 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): Merge branch 'DEN-14733-UI-BN-S90-2' into staging

Behrouz NematiPour — Fri, 10 Feb 2023 09:51:39 -0800

Behrouz NematiPour committed 1f2e7db on branch master, @Environement_Swith and 176 more in application

Merge branch 'DEN-14733-UI-BN-S90-2' into staging

· /AlarmMapping.csv

(-2, +3)

| History

| Source

| Diff

· /cppcheck.err

(-39, +1221)

| History

| Source

| Diff

· /cppcheck.log

(-69, +271)

| History

| Source

| Diff

· /denali.pro.user

(-118, +66)

| History

| Source

| Diff

· /en_US.udic

(-0, +1)

| History

| Source

| Diff

· /imake.sh

(-6, +0)

| History

| Source

| Diff

· /main.cpp

(-0, +31)

| History

| Source

| Diff

· /sources/canbus/CanInterface.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/MessageGlobals.h

(-4, +4)

| History

| Source

| Diff

· /sources/canbus/MessageInterpreter.cpp

(-5, +5)

| History

| Source

| Diff

· /sources/device/DeviceController.cpp

(-1, +6)

| History

| Source

| Diff

· /sources/gui/GuiController.cpp

(-11, +2)

| History

| Source

| Diff

· /sources/gui/GuiView.h

(-0, +3)

| History

| Source

| Diff

· /sources/gui/qml/PowerItem.qml

(-4, +1)

| History

| Source

| Diff

· /sources/gui/qml/components/DebugDataColumn.qml

(-3, +3)

| History

| Source

| Diff

… 29 more files in changeset.

UI-DEN-14733-2: closed by Behrouz NematiPour

Behrouz NematiPour — Fri, 10 Feb 2023 09:23:58 -0800

Behrouz NematiPour Closed UI-DEN-14733-2

UI-DEN-14733-2: reviewers finished

Fri, 10 Feb 2023 09:20:34 -0800

Sean Nash and vduong (deleted user) finished reviewing UI-DEN-14733-2

UI-DEN-14733_UI BN S90

UI-DEN-14733-2: comment by vduong "Yes, assignments break bindings. RESOLVED"

vduong — Fri, 10 Feb 2023 09:18:39 -0800

vduong (deleted user) replied to Behrouz NematiPour in UI-DEN-14733-2

Yes, assignments break bindings.

RESOLVED

UI-DEN-14733-2: comment by Behrouz NematiPour "Good point, But you can't. The readonly prope..."

Behrouz NematiPour — Fri, 10 Feb 2023 08:19:32 -0800

Behrouz NematiPour replied to vduong (deleted user) in UI-DEN-14733-2

Good point,
But you can't.
The readonly properties are only working with bindings, not assignments.
I am using that as a public variable.

UI-DEN-14733-2: comment by vduong "If _root.isOpen is not modified outside of this..."

vduong — Fri, 10 Feb 2023 08:04:45 -0800

vduong (deleted user) commented on UI-DEN-14733-2

If _root.isOpen is not modified outside of this powerItem.qml, You can make it a readonly property and bind it to the powerDialog's property.

UI-DEN-14733-2: reviewers resumed

Thu, 09 Feb 2023 16:39:31 -0800

jishii (deleted user) resumed reviewing UI-DEN-14733-2

UI-DEN-14733_UI BN S90

UI-DEN-14733-2: comment by Sean Nash "So we will likely remove this TODO and comment ..."

Sean Nash — Thu, 09 Feb 2023 11:08:38 -0800

Sean Nash replied to Behrouz NematiPour in UI-DEN-14733-2

So we will likely remove this TODO and comment later?
RESOLVED.

UI-DEN-14733-2: comment by Sean Nash "RESOLVED."

Sean Nash — Thu, 09 Feb 2023 11:06:37 -0800

Sean Nash replied to Behrouz NematiPour in UI-DEN-14733-2

RESOLVED.

UI-DEN-14733-2: comment by Behrouz NematiPour "It was removed. UI sends an alarmTriggered to ..."

Behrouz NematiPour — Thu, 09 Feb 2023 10:05:33 -0800

Behrouz NematiPour replied to Sean Nash in UI-DEN-14733-2

It was removed.
UI sends an alarmTriggered to HD for that, and should not display a dialog by itself.
Since on the device, if there is no other alarm HD will eventually display it, and if there is HD will override it.
It was just a bug in development then, which was always displaying a useless dialog on VM that doesn't even have a physical SD Card.

UI-DEN-14733-2: comment by Behrouz NematiPour "I laughed loud for a while :D This is the spel..."

Behrouz NematiPour — Thu, 09 Feb 2023 10:02:03 -0800

Behrouz NematiPour replied to Sean Nash in UI-DEN-14733-2

I laughed loud for a while
This is the spell checker dictionary.
Since my spell checker was complaining and it was bugging me, and I always look at it like there is a bug in that area, I add her name so spell checker won't highlight it anymore.
It is a comment I have about the decision we made to remind me why I have that line of code commented.

UI-DEN-14733-2: comment by Michael Garthwaite "RESOLVED."

Michael Garthwaite — Thu, 09 Feb 2023 09:24:04 -0800

Michael Garthwaite replied to Michael Garthwaite in UI-DEN-14733-2

RESOLVED.

UI-DEN-14733-2: comment by Michael Garthwaite "is this alignment correct? I see you align by ...."

Michael Garthwaite — Thu, 09 Feb 2023 09:21:04 -0800

Michael Garthwaite commented on UI-DEN-14733-2

is this alignment correct? I see you align by . above (line 35-38) but I don't see examples of aligning by ( for function calls.

UI-DEN-14733-2: comment by Sean Nash "Why is her name in string table?"

Sean Nash — Thu, 09 Feb 2023 08:41:28 -0800

Sean Nash commented on UI-DEN-14733-2

Why is her name in string table?

UI-DEN-14733-2: comment by Sean Nash "Any reason this alarm is commented out?"

Sean Nash — Thu, 09 Feb 2023 08:37:07 -0800

Sean Nash commented on UI-DEN-14733-2

Any reason this alarm is commented out?

UI-DEN-14733-2: started by Dara Navaei

Dara Navaei — Wed, 08 Feb 2023 21:09:51 -0800

Dara Navaei started review UI-DEN-14733-2

application (bugfix/DEN-16597-UI-BN-S114): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 04 Jan 2023 16:48:39 -0800

Dara Navaei committed c9f8f8c on branch master, @Environement_Swith and 181 more in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /alarmMapping.sh

(-1, +1)

| History

| Source

| Diff

· /cppcheck.sh

(-2, +2)

| History

| Source

| Diff

· /cr_objectives.sh

(-1, +1)

| History

| Source

| Diff

· /imake.sh

(-1, +1)

| History

| Source

| Diff

· /main.cpp

(-1, +1)

| History

| Source

| Diff

· /remove-exra-emptylines.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/autostart

(-2, +2)

| History

| Source

| Diff

· /scripts/bluetooth_paired_clear.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/bluetooth_paired_query.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/brightness_get.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/brightness_set.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/date_time_set.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/export_logs.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/globals.sh

(-3, +4)

| History

| Source

| Diff

· /scripts/run.sh

(-3, +3)

| History

| Source

| Diff

… 594 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 16 Feb 2022 10:10:27 -0800

Dara Navaei committed 27cc308 on branch master, @Environement_Swith and 200 more in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /alarmMapping.sh

(-7, +6)

| History

| Source

| Diff

· /cppcheck.sh

(-6, +6)

| History

| Source

| Diff

· /cr_objectives.sh

(-0, +15)

| History

| Source

| Diff

· /main.cpp

(-6, +6)

| History

| Source

| Diff

· /remove-exra-emptylines.sh

(-6, +6)

| History

| Source

| Diff

· /scripts/autostart

(-6, +6)

| History

| Source

| Diff

· /scripts/bluetooth_paired_clear.sh

(-6, +6)

| History

| Source

| Diff

· /scripts/bluetooth_paired_query.sh

(-6, +6)

| History

| Source

| Diff

· /scripts/brightness_get.sh

(-0, +15)

| History

| Source

| Diff

· /scripts/brightness_set.sh

(-0, +15)

| History

| Source

| Diff

· /scripts/date_time_set.sh

(-0, +15)

| History

| Source

| Diff

· /scripts/export_logs.sh

(-0, +15)

| History

| Source

| Diff

· /scripts/run.sh

(-6, +6)

| History

| Source

| Diff

· /scripts/setup.sh

(-6, +6)

| History

| Source

| Diff

· /scripts/start.sh

(-6, +6)

| History

| Source

| Diff

… 570 more files in changeset.

UI-DEN-4691-1: closed by Behrouz NematiPour

Behrouz NematiPour — Fri, 20 Nov 2020 01:12:45 -0800

Behrouz NematiPour Closed UI-DEN-4691-1