UI-DEN-4691_Inline Blood Pressure Adjustments

Activity

UI-DEN-4691-1 15

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 57m 5 Done
    plucia  (deleted user)
    Reviewer completed
    Reviewer - Complete 1h 6m 8 RESOLVED. My understanding is that this will be connected...
    pmontazemi  (deleted user)
    Reviewer completed
    Reviewer - Complete 18m 2 RESOLVED.
    Total   2h 22m 15  
    #permalink

    Objectives

    Story: DEN-4691: UI Blood In-Line Pressure Adjustments
    Note :

    • Some codes have been pulled from master and are subject to change/update in other stories. Will refer to this not if commented.
    • Some changes have been reviewed already since this story has been suspended for a while and has been branched out from within the Doxygenization branch and after branch, the source branch was moving forward.
    • Some codes have been mixed up with the "Create Treatment" story due to the fact that these are parallel stories.


    ChangeLog:
    01 - The messages for Adjusting Inline Arterial/Venous blood pressures request/response implemented.
    02 - RangeBar.qml Component updated to have out of range RangeMarker color.
    03 - RangeSlider.qml component has been created.
    04 - TickMarks.qml component ranges type changed from int to real.
    05 - TouchArea.qml component now has a property to hide the arrow/chevron.
    06 - A compound component PressureRangeSlider.qml has been created specifically for the pressures adjustment screen which contains a double progressbar (a progressbar for the current pressure values and another progress for the limits on top of it) and a double slider to allow the user to adjust the limits.
    07 - The Inline Arterial/Venous blood pressures adjustment screen has been created.
    08 - Updated TreatmentPressures.qml section.
    09 - Added CONSTANT property.
    10 - Some other minor tweaks.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /resources/images/Done.png Added
    Open in IDE #permalink
    /resources/images/OffGray.png Added
    Open in IDE #permalink
    /resources/images/alarm.png Added
    Open in IDE #permalink
    /resources/images/alarm.svg Deleted
    Open in IDE #permalink
    /resources/images/bell-off.png Added
    Open in IDE #permalink
    /resources/images/bell-off.svg Deleted
    Open in IDE #permalink
    /resources/images/bell.png Added
    Open in IDE #permalink
    /resources/images/bell.svg Deleted
    Open in IDE #permalink
    /scripts/copy.sh Changed
    /sources/canbus/CanInterface.cpp Changed
    /sources/canbus/CanInterface.h Changed
    /sources/canbus/FrameInterface.cpp Changed
    /sources/canbus/FrameInterface.h Changed
    /sources/canbus/MessageAcknowModel.cpp Changed
    /sources/canbus/MessageAcknowModel.h Changed
    /sources/canbus/MessageBuilder.cpp Changed
    /sources/canbus/MessageBuilder.h Changed
    /sources/canbus/MessageDispatcher.cpp Changed
    /sources/canbus/MessageDispatcher.h Changed
    /sources/canbus/MessageGlobals.h Added
    /sources/canbus/MessageInterpreter.cpp Added 3
    /sources/canbus/MessageInterpreter.h Added
    Open in IDE #permalink
    /sources/canbus/messageglobals.h Changed
    Open in IDE #permalink
    /sources/canbus/messageinterpreter.cpp Changed
    Open in IDE #permalink
    /sources/canbus/messageinterpreter.h Changed
    Open in IDE #permalink
    /sources/gui/.../components/CircleWithText.qml Added
    /sources/gui/qml/components/ImageClock.qml Changed
    /sources/gui/qml/components/ImageWave.qml Changed
    /sources/gui/qml/components/MainMenu.qml Changed
    /sources/gui/.../components/ModalDialog.qml Changed
    /sources/.../components/NotificationBar.qml Changed
    /sources/.../components/NotificationBarSmall.qml Changed
    /sources/gui/.../components/ProgressBar.qml Changed
    /sources/gui/.../components/ProgressBarEx.qml Changed
    /sources/gui/.../components/ProgressRect.qml Changed
    /sources/gui/qml/components/RangeBar.qml Changed
    /sources/gui/.../components/RangeMarker.qml Changed
    /sources/gui/qml/components/RangeRect.qml Changed
    /sources/gui/.../components/RangeSlider.qml Added
    /sources/.../components/RectSelectCreateTreatment.qml Added
    Open in IDE #permalink
    /sources/gui/qml/components/Slider.qml Changed
    Open in IDE #permalink
    /sources/.../components/SliderCreateTreatment.qml Added
    Open in IDE #permalink
    /sources/.../components/SliderDoubleCreateTreatment.qml Added
    Open in IDE #permalink
    /sources/gui/qml/components/TickMarks.qml Changed
    /sources/.../components/TopMenuBarCreateTreatment.qml Added
    Open in IDE #permalink
    /sources/gui/qml/components/TouchArea.qml Changed
    /sources/gui/qml/components/TouchRect.qml Changed
    Open in IDE #permalink
    /sources/.../components/UltrafiltrationButton.qml Changed
    /sources/.../compounds/PressureRangeSlider.qml Added
    /sources/gui/qml/dialogs/AutoHideInfo.qml Changed
    /sources/.../dialogs/NotificationDialog.qml Changed
    Open in IDE #permalink
    /sources/gui/qml/dialogs/PowerOff.qml Changed
    /sources/gui/qml/globals/Colors.qml Changed 3
    /sources/gui/qml/globals/Fonts.qml Changed
    /sources/gui/qml/globals/Variables.qml Changed
    /sources/.../adjustments/TreatmentAdjustmentBase.qml Changed
    /sources/.../adjustments/TreatmentAdjustmentDuration.qml Changed
    /sources/.../adjustments/TreatmentAdjustmentFlow.qml Changed
    /sources/.../adjustments/TreatmentAdjustmentPressures.qml Deleted
    Open in IDE #permalink
    /sources/.../adjustments/TreatmentAdjustmentPressuresLimits.qml Added
    /sources/.../adjustments/TreatmentAdjustmentUltrafiltrationConfirm.qml Changed
    /sources/.../adjustments/TreatmentAdjustmentUltrafiltrationEdit.qml Changed
    /sources/.../adjustments/TreatmentAdjustmentUltrafiltrationPaused.qml Changed
    /sources/.../adjustments/TreatmentAdjustmentUltrafiltrationStart.qml Changed
    /sources/gui/.../sections/TreatmentFluid.qml Changed
    /sources/.../sections/TreatmentPressure.qml Deleted
    Open in IDE #permalink
    /sources/.../sections/TreatmentPressures.qml Added
    /sources/.../sections/TreatmentPressuresLimits.qml Deleted
    Open in IDE #permalink
    /sources/gui/.../sections/TreatmentSaline.qml Changed
    /sources/gui/.../sections/TreatmentTime.qml Changed
    /sources/.../sections/TreatmentUltrafiltration.qml Changed
    /sources/gui/.../treatment/TreatmentBegin.qml Added
    /sources/.../treatment/TreatmentConfirm.qml Added
    Open in IDE #permalink
    /sources/gui/.../treatment/TreatmentCreate.qml Changed
    /sources/gui/.../treatment/TreatmentHome.qml Changed
    /sources/gui/.../treatment/TreatmentPrime.qml Added
    /sources/gui/.../treatment/TreatmentStack.qml Changed
    /sources/gui/.../treatment/TreatmentStart.qml Changed
    /sources/gui/qml/pages/Diagnostics.qml Changed
    /sources/gui/qml/pages/ManagerHome.qml Changed
    /sources/gui/qml/pages/SettingsHome.qml Changed
    /sources/gui/qml/main.qml Changed
    /sources/gui/GuiController.cpp Added
    /sources/gui/GuiController.h Added
    /sources/gui/GuiGlobals.cpp Added
    /sources/gui/GuiGlobals.h Added
    /sources/gui/GuiView.cpp Changed
    /sources/gui/GuiView.h Changed
    /sources/gui/guicontroller.cpp Changed
    Open in IDE #permalink
    /sources/gui/guicontroller.h Changed
    Open in IDE #permalink
    /sources/gui/guiglobals.cpp Changed
    Open in IDE #permalink
    /sources/gui/guiglobals.h Changed
    Open in IDE #permalink
    /sources/model/.../data/MDGDrainPumpData.cpp Changed
    /sources/model/dg/data/MDGDrainPumpData.h Changed
    /sources/model/dg/data/MDGHeatersData.cpp Changed
    /sources/model/dg/data/MDGHeatersData.h Changed
    /sources/.../data/MDGLoadCellReadingsData.cpp Changed
    /sources/.../data/MDGLoadCellReadingsData.h Changed
    /sources/.../data/MDGOperationModeData.cpp Changed
    /sources/model/.../data/MDGOperationModeData.h Changed
    /sources/model/.../data/MDGPressuresData.cpp Changed
    /sources/model/dg/data/MDGPressuresData.h Changed
    /sources/model/dg/data/MDGROPumpData.cpp Changed
    /sources/model/dg/data/MDGROPumpData.h Changed
    /sources/model/.../data/MDGReservoirData.cpp Changed
    /sources/model/dg/data/MDGReservoirData.h Changed
    /sources/.../data/MDGTemperaturesData.cpp Changed
    /sources/model/.../data/MDGTemperaturesData.h Changed
    /sources/.../data/MDGValvesStatesData.cpp Changed
    /sources/model/.../data/MDGValvesStatesData.h Changed
    /sources/.../adjustment/MTreatmentAdjustBloodDialysateResponse.cpp Changed
    /sources/.../adjustment/MTreatmentAdjustBloodDialysateResponse.h Changed
    /sources/.../adjustment/MTreatmentAdjustDurationResponse.cpp Changed
    /sources/.../adjustment/MTreatmentAdjustDurationResponse.h Changed
    /sources/.../adjustment/MTreatmentAdjustPressuresLimitsResponse.cpp Added
    Open in IDE #permalink
    /sources/.../adjustment/MTreatmentAdjustPressuresLimitsResponse.h Added
    /sources/.../adjustment/MTreatmentAdjustRequests.h Changed 3
    /sources/.../adjustment/MTreatmentAdjustSalineResponse.cpp Changed
    /sources/.../adjustment/MTreatmentAdjustSalineResponse.h Changed
    /sources/.../adjustment/MTreatmentAdjustUltrafiltrationConfirmResponse.cpp Changed
    /sources/.../adjustment/MTreatmentAdjustUltrafiltrationConfirmResponse.h Changed
    /sources/.../adjustment/MTreatmentAdjustUltrafiltrationEditResponse.cpp Changed
    /sources/.../adjustment/MTreatmentAdjustUltrafiltrationEditResponse.h Changed
    /sources/.../adjustment/MTreatmentAdjustUltrafiltrationStateResponse.cpp Changed
    /sources/.../adjustment/MTreatmentAdjustUltrafiltrationStateResponse.h Changed
    /sources/model/hd/alarm/MAlarmCleared.cpp Changed
    /sources/model/hd/alarm/MAlarmCleared.h Changed
    /sources/model/.../alarm/MAlarmStatusData.cpp Changed
    /sources/model/hd/alarm/MAlarmStatusData.h Changed
    Open in IDE #permalink
    /sources/model/.../alarm/MAlarmTriggered.cpp Changed
    /sources/model/hd/alarm/MAlarmTriggered.h Changed
    /sources/.../data/MHDOperationModeData.cpp Changed
    /sources/model/.../data/MHDOperationModeData.h Changed
    /sources/.../data/MTreatmentFlowsData.cpp Changed
    /sources/model/.../data/MTreatmentFlowsData.h Changed
    /sources/.../data/MTreatmentOutletFlowData.cpp Changed
    /sources/.../data/MTreatmentOutletFlowData.h Changed
    /sources/.../data/MTreatmentPressureOcclusionData.cpp Changed
    /sources/.../data/MTreatmentPressureOcclusionData.h Changed
    /sources/.../data/MTreatmentRangesData.cpp Changed
    /sources/model/.../data/MTreatmentRangesData.h Changed
    /sources/.../data/MTreatmentSalineData.cpp Changed
    /sources/model/.../data/MTreatmentSalineData.h Changed
    /sources/.../data/MTreatmentStatesData.cpp Changed
    /sources/model/.../data/MTreatmentStatesData.h Changed
    /sources/model/.../data/MTreatmentTimeData.cpp Changed
    /sources/model/.../data/MTreatmentTimeData.h Changed
    /sources/model/MAbstract.cpp Changed
    /sources/model/MAbstract.h Changed
    /sources/model/MDGDebugText.cpp Changed
    /sources/model/MDGDebugText.h Changed
    /sources/model/MHDDebugText.cpp Changed
    /sources/model/MHDDebugText.h Changed
    /sources/model/MModel.h Added
    /sources/model/MPowerOff.cpp Changed
    /sources/model/MPowerOff.h Changed
    /sources/model/MTreatmentParameters.cpp Added
    Open in IDE #permalink
    /sources/model/MTreatmentParameters.h Added
    Open in IDE #permalink
    /sources/model/MTreatmentParametersResp.cpp Added
    Open in IDE #permalink
    /sources/model/MTreatmentParametersResp.h Added
    Open in IDE #permalink
    /sources/model/mmodel.h Changed
    Open in IDE #permalink
    /sources/model/mtreatmentparameters.cpp Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentparameters.h Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentparametersresp.cpp Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentparametersresp.h Deleted
    Open in IDE #permalink
    /sources/storage/DriveWatcher.cpp Changed
    /sources/storage/DriveWatcher.h Changed
    /sources/storage/FileHandler.cpp Added
    /sources/storage/FileHandler.h Added
    /sources/storage/Logger.cpp Changed
    /sources/storage/Logger.h Changed
    /sources/storage/StorageGlobals.cpp Added
    /sources/storage/StorageGlobals.h Added
    /sources/storage/filehandler.cpp Changed
    Open in IDE #permalink
    /sources/storage/filehandler.h Changed
    Open in IDE #permalink
    /sources/storage/filesaver.cpp Added
    Open in IDE #permalink
    /sources/storage/filesaver.h Added
    /sources/storage/storageglobals.cpp Changed
    Open in IDE #permalink
    /sources/storage/storageglobals.h Changed
    Open in IDE #permalink
    /sources/utility/crc.cpp Changed
    /sources/utility/format.cpp Changed
    /sources/utility/format.h Changed
    /sources/utility/types.cpp Changed
    /sources/utility/types.h Changed
    /sources/view/dg/data/VDGDrainPumpData.cpp Changed
    /sources/view/dg/data/VDGDrainPumpData.h Changed
    /sources/view/dg/data/VDGHeatersData.cpp Changed
    /sources/view/dg/data/VDGHeatersData.h Changed
    /sources/.../data/VDGLoadCellReadingsData.cpp Changed
    /sources/.../data/VDGLoadCellReadingsData.h Changed
    /sources/.../data/VDGOperationModeData.cpp Changed
    /sources/view/.../data/VDGOperationModeData.h Changed
    /sources/view/dg/data/VDGPressuresData.cpp Changed
    /sources/view/dg/data/VDGPressuresData.h Changed
    /sources/view/dg/data/VDGROPumpData.cpp Changed
    /sources/view/dg/data/VDGROPumpData.h Changed
    /sources/view/dg/data/VDGReservoirData.cpp Changed
    /sources/view/dg/data/VDGReservoirData.h Changed
    /sources/view/.../data/VDGTemperaturesData.cpp Changed
    /sources/view/.../data/VDGTemperaturesData.h Changed
    /sources/view/.../data/VDGValvesStatesData.cpp Changed
    /sources/view/.../data/VDGValvesStatesData.h Changed
    /sources/.../adjustment/VTreatmentAdjustmentDuration.cpp Changed
    /sources/.../adjustment/VTreatmentAdjustmentDuration.h Changed
    /sources/.../adjustment/VTreatmentAdjustmentFlows.cpp Changed
    /sources/.../adjustment/VTreatmentAdjustmentFlows.h Changed
    /sources/.../adjustment/VTreatmentAdjustmentPressuresLimits.cpp Added 3
    /sources/.../adjustment/VTreatmentAdjustmentPressuresLimits.h Added
    /sources/.../adjustment/VTreatmentAdjustmentResponseBase.cpp Changed
    /sources/.../adjustment/VTreatmentAdjustmentResponseBase.h Changed
    /sources/.../adjustment/VTreatmentAdjustmentSaline.cpp Changed
    /sources/.../adjustment/VTreatmentAdjustmentSaline.h Changed
    /sources/.../adjustment/VTreatmentAdjustmentUltrafiltrationConfirm.cpp Changed
    /sources/.../adjustment/VTreatmentAdjustmentUltrafiltrationConfirm.h Changed
    /sources/.../adjustment/VTreatmentAdjustmentUltrafiltrationEdit.cpp Changed
    /sources/.../adjustment/VTreatmentAdjustmentUltrafiltrationEdit.h Changed
    /sources/.../adjustment/VTreatmentAdjustmentUltrafiltrationState.cpp Changed
    /sources/.../adjustment/VTreatmentAdjustmentUltrafiltrationState.h Changed
    /sources/view/hd/alarm/VAlarmStatus.cpp Changed
    Open in IDE #permalink
    /sources/view/hd/alarm/VAlarmStatus.h Changed
    /sources/.../data/VHDOperationModeData.cpp Changed
    /sources/view/.../data/VHDOperationModeData.h Changed
    /sources/.../data/VHDTreatmentStatesData.cpp Changed
    /sources/.../data/VHDTreatmentStatesData.h Changed
    /sources/view/.../data/VTreatmentBloodFlow.cpp Changed
    /sources/view/.../data/VTreatmentBloodFlow.h Changed
    /sources/.../data/VTreatmentDialysateFlow.cpp Changed
    /sources/.../data/VTreatmentDialysateFlow.h Changed
    /sources/.../data/VTreatmentPressureOcclusion.cpp Changed
    /sources/.../data/VTreatmentPressureOcclusion.h Changed
    /sources/view/hd/data/VTreatmentRanges.cpp Changed
    /sources/view/hd/data/VTreatmentRanges.h Changed
    /sources/.../data/VTreatmentSalineData.cpp Changed
    /sources/view/.../data/VTreatmentSalineData.h Changed
    /sources/view/hd/data/VTreatmentTime.cpp Changed
    /sources/view/hd/data/VTreatmentTime.h Changed
    /sources/.../data/VTreatmentUltrafiltration.cpp Changed
    /sources/.../data/VTreatmentUltrafiltration.h Changed
    /sources/view/VCreateTreatment.cpp Added
    Open in IDE #permalink
    /sources/view/VCreateTreatment.h Added
    Open in IDE #permalink
    /sources/view/VEventSpy.cpp Changed
    /sources/view/VEventSpy.h Changed
    /sources/view/VPowerOff.cpp Changed
    /sources/view/VPowerOff.h Changed
    /sources/view/VView.h Added
    /sources/view/vview.h Changed
    Open in IDE #permalink
    /sources/ApplicationController.cpp Added
    /sources/ApplicationController.h Added
    /sources/ApplicationPost.cpp Changed
    /sources/ApplicationPost.h Changed
    /sources/MainTimer.cpp Changed
    /sources/MainTimer.h Changed
    /sources/Threads.cpp Changed
    /sources/Threads.h Changed
    /sources/applicationcontroller.cpp Changed
    Open in IDE #permalink
    /sources/applicationcontroller.h Changed
    Open in IDE #permalink
    /sources/main.h Changed
    /unittests/tst_acknow.cpp Changed
    /unittests/tst_acknow.h Changed
    /unittests/tst_canbus.cpp Changed
    /unittests/tst_canbus.h Changed
    /unittests/tst_initializations.cpp Changed
    /unittests/tst_initializations.h Changed
    /unittests/tst_logging.cpp Changed
    /unittests/tst_messaging.cpp Changed
    /unittests/tst_messaging.h Changed
    /unittests/tst_models.cpp Changed
    /unittests/tst_models.h Changed
    /unittests/tst_threads.cpp Changed
    /unittests/tst_threads.h Changed
    /unittests/tst_views.cpp Changed 3
    /unittests/tst_views.h Changed
    Open in IDE #permalink
    /cppcheck.err Changed
    /cppcheck.log Changed
    /denali.pro Changed
    /denali.pro.user Added
    /denali.qrc Changed
    /en_US.aff Added
    Open in IDE #permalink
    /en_US.dic Added
    Open in IDE #permalink
    /en_US.udic Added
    /main.cpp Changed
    /remove-exra-emptylines.sh Added
    Open in IDE #permalink
    /shared/scripts/names.py Changed
    /simulator/Simulator.ui Changed
    /simulator/run.py Changed
    /tst_HomeScreen/test.py Changed
    /tst_ServiceShutdown/test.py Changed
    /tst_Treatment_Adjustment_Pressures/test.py Added
    /tst_Treatment_PressureOcclusion/test.py Changed
    /suite.conf Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time