Fisheye on hdfirmware/results/cppcheck.log https://devapps.diality.us/changelog/~br%3DDEN-15363-fw-handle-bld-sensor-communication-errors/hdfirmware/results/cppcheck.log Recent activity in "hdfirmware" under directory /results/cppcheck.log HD-DEN-16446-2: closed by Dara Navaei Fri, 20 Oct 2023 09:23:54 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16446-2 https://devapps.diality.us/cru/HD-DEN-16446-2 Dara Navaei Closed HD-DEN-16446-2 ]]> HD-DEN-16446-2: reviewers finished Fri, 20 Oct 2023 08:15:29 -0700 https://devapps.diality.us/cru/HD-DEN-16446-2 https://devapps.diality.us/cru/HD-DEN-16446-2 Sean Nash finished reviewing HD-DEN-16446-2 HD-DEN-16446_HD Dev Test Clean UP Vectorcast ]]> HD-DEN-16446-2: reviewers finished Thu, 19 Oct 2023 16:37:30 -0700 https://devapps.diality.us/cru/HD-DEN-16446-2 https://devapps.diality.us/cru/HD-DEN-16446-2 wbracken  (deleted user) finished reviewing HD-DEN-16446-2 HD-DEN-16446_HD Dev Test Clean UP Vectorcast ]]> HD-DEN-16446-2: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Thu, 19 Oct 2023 16:36:33 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-16446-2/#c19222 https://devapps.diality.us/cru/HD-DEN-16446-2/#c19222 wbracken  (deleted user) replied to Dara Navaei in HD-DEN-16446-2

RESOLVED IN CODE WALKTHROUGH

]]> HD-DEN-16446-2: comment by Dara Navaei "The result will be an unsigned integer" Thu, 19 Oct 2023 14:23:26 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16446-2/#c19206 https://devapps.diality.us/cru/HD-DEN-16446-2/#c19206 Dara Navaei replied to wbracken  (deleted user) in HD-DEN-16446-2

The result will be an unsigned integer

]]> HD-DEN-16446-2: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 19 Oct 2023 14:11:04 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16446-2/#c19205 https://devapps.diality.us/cru/HD-DEN-16446-2/#c19205 Sean Nash replied to Vinayakam Mani in HD-DEN-16446-2

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16446-2: comment by Vinayakam Mani "In the If conditions, we check "uFVolume > colU..." Thu, 19 Oct 2023 13:33:29 -0700 Vinayakam Mani https://devapps.diality.us/cru/HD-DEN-16446-2/#c19204 https://devapps.diality.us/cru/HD-DEN-16446-2/#c19204 Vinayakam Mani replied to Sean Nash in HD-DEN-16446-2

In the If conditions, we check "uFVolume > colUFVol" conditions, that makes uFRate always positive and hence the condition for minimum check is not required.

]]> HD-DEN-1312-1: closed by Dara Navaei Thu, 19 Oct 2023 09:33:22 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-1312-1 https://devapps.diality.us/cru/HD-DEN-1312-1 Dara Navaei Closed HD-DEN-1312-1 ]]> HD-DEN-1312-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 09:32:52 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-1312-1/#c19138 https://devapps.diality.us/cru/HD-DEN-1312-1/#c19138 Dara Navaei replied to Sean Nash in HD-DEN-1312-1

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-1312-1: reviewers resumed Thu, 19 Oct 2023 09:31:46 -0700 https://devapps.diality.us/cru/HD-DEN-1312-1 https://devapps.diality.us/cru/HD-DEN-1312-1 Dara Navaei resumed reviewing HD-DEN-1312-1 HD-DEN-1312_HD Dialysate Inlet Pump/Drive, Flow Sensor, Control ]]> HD-DEN-1312-1: started by Dara Navaei Thu, 19 Oct 2023 09:31:28 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-1312-1 https://devapps.diality.us/cru/HD-DEN-1312-1 Dara Navaei started review HD-DEN-1312-1 ]]> HD-DEN-431-1: closed by Dara Navaei Thu, 19 Oct 2023 08:57:34 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-431-1 https://devapps.diality.us/cru/HD-DEN-431-1 Dara Navaei Closed HD-DEN-431-1 ]]> HD-DEN-431-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:57:14 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-431-1/#c19115 https://devapps.diality.us/cru/HD-DEN-431-1/#c19115 Dara Navaei replied to Dara Navaei in HD-DEN-431-1

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-431-1: started by Dara Navaei Thu, 19 Oct 2023 08:53:05 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-431-1 https://devapps.diality.us/cru/HD-DEN-431-1 Dara Navaei started review HD-DEN-431-1 ]]> HD-DEN-16446-2: reviewers resumed Tue, 17 Oct 2023 15:00:28 -0700 https://devapps.diality.us/cru/HD-DEN-16446-2 https://devapps.diality.us/cru/HD-DEN-16446-2 jtaylor  (deleted user) resumed reviewing HD-DEN-16446-2 HD-DEN-16446_HD Dev Test Clean UP Vectorcast ]]> HD-DEN-16446-2: comment by Sean Nash "I think we need the minimum check too. uFRate ..." Mon, 16 Oct 2023 11:04:28 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16446-2/#c19033 https://devapps.diality.us/cru/HD-DEN-16446-2/#c19033 Sean Nash commented on HD-DEN-16446-2

I think we need the minimum check too. uFRate can be negative if user sets volume to something lower than what has already been collected (negative volume) which would yield a negative rate which is < 0.0.

]]> HD-DEN-16446-2: comment by wbracken "Check casting. Result is U32 but could be assi..." Fri, 13 Oct 2023 10:41:25 -0700 wbracken https://devapps.diality.us/cru/HD-DEN-16446-2/#c19029 https://devapps.diality.us/cru/HD-DEN-16446-2/#c19029 wbracken  (deleted user) commented on HD-DEN-16446-2

Check casting. Result is U32 but could be assigned an S32.

]]> HD-DEN-16446-2: started by Dara Navaei Fri, 06 Oct 2023 10:06:10 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16446-2 https://devapps.diality.us/cru/HD-DEN-16446-2 Dara Navaei started review HD-DEN-16446-2 ]]> HD-UCOMMITS-20: closed by Sean Nash Thu, 03 Aug 2023 09:52:03 -0700 Sean Nash https://devapps.diality.us/cru/HD-UCOMMITS-20 https://devapps.diality.us/cru/HD-UCOMMITS-20 Sean Nash Closed HD-UCOMMITS-20 ]]> HD-UCOMMITS-20: reviewers finished Thu, 03 Aug 2023 09:29:51 -0700 https://devapps.diality.us/cru/HD-UCOMMITS-20 https://devapps.diality.us/cru/HD-UCOMMITS-20 Dara Navaei finished reviewing HD-UCOMMITS-20 HD Staging Unreviewed Commits ]]> HD-UCOMMITS-19: closed by Sean Nash Thu, 03 Aug 2023 08:57:40 -0700 Sean Nash https://devapps.diality.us/cru/HD-UCOMMITS-19 https://devapps.diality.us/cru/HD-UCOMMITS-19 Sean Nash Closed HD-UCOMMITS-19 ]]> HD-UCOMMITS-21: closed by Sean Nash Thu, 03 Aug 2023 08:57:11 -0700 Sean Nash https://devapps.diality.us/cru/HD-UCOMMITS-21 https://devapps.diality.us/cru/HD-UCOMMITS-21 Sean Nash Closed HD-UCOMMITS-21 ]]> HD-UCOMMITS-21: reviewers finished Thu, 03 Aug 2023 08:42:59 -0700 https://devapps.diality.us/cru/HD-UCOMMITS-21 https://devapps.diality.us/cru/HD-UCOMMITS-21 Dara Navaei finished reviewing HD-UCOMMITS-21 HD Staging Unreviewed Commits ]]> HD-UCOMMITS-19: reviewers finished Wed, 02 Aug 2023 21:26:40 -0700 https://devapps.diality.us/cru/HD-UCOMMITS-19 https://devapps.diality.us/cru/HD-UCOMMITS-19 Dara Navaei and Sean Nash finished reviewing HD-UCOMMITS-19 HD Staging Unreviewed Commits ]]> HD-UCOMMITS-21: reviewers finished Wed, 02 Aug 2023 15:14:34 -0700 https://devapps.diality.us/cru/HD-UCOMMITS-21 https://devapps.diality.us/cru/HD-UCOMMITS-21 Sean Nash finished reviewing HD-UCOMMITS-21 HD Staging Unreviewed Commits ]]> HD-UCOMMITS-20: reviewers finished Wed, 02 Aug 2023 12:17:59 -0700 https://devapps.diality.us/cru/HD-UCOMMITS-20 https://devapps.diality.us/cru/HD-UCOMMITS-20 Sean Nash finished reviewing HD-UCOMMITS-20 HD Staging Unreviewed Commits ]]> HD-UCOMMITS-21: started by Dara Navaei Mon, 08 May 2023 09:30:01 -0700 Dara Navaei https://devapps.diality.us/cru/HD-UCOMMITS-21 https://devapps.diality.us/cru/HD-UCOMMITS-21 Dara Navaei started review HD-UCOMMITS-21 ]]> HD-UCOMMITS-20: started by Dara Navaei Mon, 08 May 2023 09:26:10 -0700 Dara Navaei https://devapps.diality.us/cru/HD-UCOMMITS-20 https://devapps.diality.us/cru/HD-UCOMMITS-20 Dara Navaei started review HD-UCOMMITS-20 ]]> HD-UCOMMITS-19: started by Dara Navaei Mon, 08 May 2023 09:22:08 -0700 Dara Navaei https://devapps.diality.us/cru/HD-UCOMMITS-19 https://devapps.diality.us/cru/HD-UCOMMITS-19 Dara Navaei started review HD-UCOMMITS-19 ]]> HD-DEN-7117-1: closed by Sean Nash Wed, 07 Apr 2021 11:07:55 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-7117-1 https://devapps.diality.us/cru/HD-DEN-7117-1 Sean Nash Closed HD-DEN-7117-1 ]]>