HD-DEN-431-1 HD-DEN-431_Real Time Clock

closed on 19 Oct 23

Author

Moderator

Reviewers

HD-DEN-431_Real Time Clock

Activity

Details
Objectives
General Comments 3
Unresolved
Resolved
Number of files included: 18

hdfirmware 0
- Folder firmware 0
  - Folder .launches 0
    - File HD.launch 0 Remove
  - Folder .settings 0
    - File org.eclipse.core.resources.prefs 0 Remove
  - Folder App 0
    - Folder Controllers 0
      - File RTC.c 85 Remove
      - File RTC.h 9 Remove
    - Folder Drivers 0
      - File CPLD.c 4 Remove
    - Folder Modes 0
      - File ModeInitPOST.c 0 Remove
    - Folder Services 0
      - File FPGA.c 5 Remove
    - Folder Tasks 0
      - File TaskGeneral.c 3 Remove
      - File TaskPriority.c 0 Remove
    - File Common.h 0 Remove
  - Folder include 0
    - File mibspi.h 0 Remove
  - Folder source 0
    - File mibspi.c 0 Remove
    - File sys_main.c 3 Remove
  - File HD.dil 0 Remove
- Folder results 0
  - File .gitignore 0 Remove
  - File VectorCAST.log 0 Remove
  - File cppcheck.log 0 Remove
  - File cppcheckError.csv 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Dara Navaei	Author & Moderator	16h 43m	35	RESOLVED in CODE WALKTHROUGH
Sean Nash	Reviewer - Complete	1h 49m	49	RESOLVED in CODE WALKTHROUGH.
Behrouz NematiPour	Reviewer - 100% reviewed	2h 1m	16	RESOLVED IN CODE WALKTHROUGH
pmontazemi (deleted user)	Reviewer - Complete	52m	10	RESOLVED in CODE WALKTHROUGH.
lbaloa (deleted user)	Reviewer - Complete	30m	2	RESOLVED in CODE WALKTHROUGH.
Total		21h 57m	112

Linked issues
- DEN-431

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

lbaloa (deleted user)

There is a lot of commented code that seems to be essential. Are you thinking...

There is a lot of commented code that seems to be essential. Are you thinking of uncommenting them before merge? If so, we need to verify it.

06 Jan 20

lbaloa

(deleted user)

Resolved

07 Jan 20

Dara Navaei

Yes, the commented code is only for calling the API functions somewhere from ...

Yes, the commented code is only for calling the API functions somewhere from outside. I marked that section as test code and I will delete it before merging.

06 Jan 20

lbaloa (deleted user)

RESOLVED in CODE WALKTHROUGH.

07 Jan 20

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

HD-DEN-431-1

HD-DEN-431_Real Time Clock

HD-DEN-431-1 112

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

lbaloa (deleted user)

Dara Navaei

lbaloa (deleted user)

Log time

HD-DEN-431_Real Time Clock

HD-DEN-431-1 112

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

lbaloa (deleted user)

Dara Navaei

lbaloa (deleted user)

Log time