Fisheye on application/sources/model/MAbstract.h

UI-UCOMMITS-3: closed by Sean Nash

Sean Nash — Thu, 03 Aug 2023 14:23:52 -0700

Sean Nash Closed UI-UCOMMITS-3

UI-UCOMMITS-3: reviewers finished

Thu, 03 Aug 2023 14:05:13 -0700

Dara Navaei finished reviewing UI-UCOMMITS-3

UI Staging Unreviewed Commits

UI-UCOMMITS-3: reviewers finished

Wed, 02 Aug 2023 09:33:38 -0700

Sean Nash finished reviewing UI-UCOMMITS-3

UI Staging Unreviewed Commits

UI-UCOMMITS-3: started by Dara Navaei

Dara Navaei — Mon, 08 May 2023 08:49:03 -0700

Dara Navaei started review UI-UCOMMITS-3

application (bugfix/DEN-16597-UI-BN-S114): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 04 Jan 2023 16:48:39 -0800

Dara Navaei committed c9f8f8c on branch master, @Environement_Swith and 181 more in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /alarmMapping.sh

(-1, +1)

| History

| Source

| Diff

· /cppcheck.sh

(-2, +2)

| History

| Source

| Diff

· /cr_objectives.sh

(-1, +1)

| History

| Source

| Diff

· /imake.sh

(-1, +1)

| History

| Source

| Diff

· /main.cpp

(-1, +1)

| History

| Source

| Diff

· /remove-exra-emptylines.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/autostart

(-2, +2)

| History

| Source

| Diff

· /scripts/bluetooth_paired_clear.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/bluetooth_paired_query.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/brightness_get.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/brightness_set.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/date_time_set.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/export_logs.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/globals.sh

(-3, +4)

| History

| Source

| Diff

· /scripts/run.sh

(-3, +3)

| History

| Source

| Diff

… 594 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 16 Feb 2022 10:10:27 -0800

Dara Navaei committed 27cc308 on branch master, @Environement_Swith and 200 more in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /alarmMapping.sh

(-7, +6)

| History

| Source

| Diff

· /cppcheck.sh

(-6, +6)

| History

| Source

| Diff

· /cr_objectives.sh

(-0, +15)

| History

| Source

| Diff

· /main.cpp

(-6, +6)

| History

| Source

| Diff

· /remove-exra-emptylines.sh

(-6, +6)

| History

| Source

| Diff

· /scripts/autostart

(-6, +6)

| History

| Source

| Diff

· /scripts/bluetooth_paired_clear.sh

(-6, +6)

| History

| Source

| Diff

· /scripts/bluetooth_paired_query.sh

(-6, +6)

| History

| Source

| Diff

· /scripts/brightness_get.sh

(-0, +15)

| History

| Source

| Diff

· /scripts/brightness_set.sh

(-0, +15)

| History

| Source

| Diff

· /scripts/date_time_set.sh

(-0, +15)

| History

| Source

| Diff

· /scripts/export_logs.sh

(-0, +15)

| History

| Source

| Diff

· /scripts/run.sh

(-6, +6)

| History

| Source

| Diff

· /scripts/setup.sh

(-6, +6)

| History

| Source

| Diff

· /scripts/start.sh

(-6, +6)

| History

| Source

| Diff

… 570 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): DEN-9614: Meetings & Support - General Support...

Behrouz NematiPour — Wed, 04 Aug 2021 17:29:31 -0700

Behrouz NematiPour committed 73d6d02 on branch master, @Environement_Swith and 213 more in application

DEN-9614: Meetings & Support - General Support

Bug_Fixes :

- Fixed the issue in the log having null characters in the version message

- Fixing the issue with the bottom main menu not showing up after navigating back and forth from home screen.

- Removed the touchable property from the Treatment Review screen items.

New_Features :

Known_Bugs :

- N/A [Initial push]

Changes :

- Adding the acknowledge directly sending to the DG device by UI.

· /denali.pro.user	(-1, +1)	\| History	\| Source	\| Diff
· /en_US.udic	(-0, +1)	\| History	\| Source	\| Diff
· /sources/canbus/MessageDispatcher.cpp	(-10, +12)	\| History	\| Source	\| Diff
· /sources/canbus/MessageDispatcher.h	(-3, +3)	\| History	\| Source	\| Diff
· /sources/canbus/MessageInterpreter.cpp	(-2, +34)	\| History	\| Source	\| Diff
· /sources/canbus/MessageInterpreter.h	(-1, +2)	\| History	\| Source	\| Diff
· /sources/gui/qml/components/MainMenu.qml	(-6, +7)	\| History	\| Source	\| Diff
· /sources/gui/qml/dialogs/AlarmListDialog.qml	(-2, +2)	\| History	\| Source	\| Diff
· /sources/gui/qml/pages/MainStack.qml	(-9, +5)	\| History	\| Source	\| Diff
· /sources/gui/qml/pages/posttreatment/PostTreatmentReview.qml	(-2, +2)	\| History	\| Source	\| Diff
· /sources/model/MAbstract.cpp	(-2, +2)	\| History	\| Source	\| Diff
· /sources/model/MAbstract.h	(-1, +1)	\| History	\| Source	\| Diff
· /sources/storage/Logger.cpp	(-0, +2)	\| History	\| Source	\| Diff
· /ui_build_history.log	(-0, +19)	\| History	\| Source	\| Diff

UI-DEN-8514-2: closed by Behrouz NematiPour

Behrouz NematiPour — Fri, 02 Jul 2021 11:10:56 -0700

Behrouz NematiPour Closed UI-DEN-8514-2

UI-DEN-8514-2: reviewers finished

Fri, 02 Jul 2021 10:57:56 -0700

plucia (deleted user) finished reviewing UI-DEN-8514-2

UI-DEN-8514_UI DEV Alarms Active List Merge Setting

UI-DEN-8252-1: closed by plucia

plucia — Fri, 02 Jul 2021 09:19:46 -0700

plucia (deleted user) Closed UI-DEN-8252-1

UI-DEN-8252-1: reviewers finished

Thu, 01 Jul 2021 11:54:10 -0700

Behrouz NematiPour finished reviewing UI-DEN-8252-1

UI-DEN-8252_POST

UI-DEN-8514-2: reviewers finished

Tue, 29 Jun 2021 08:44:40 -0700

pmontazemi (deleted user) finished reviewing UI-DEN-8514-2

UI-DEN-8514_UI DEV Alarms Active List Merge Setting

UI-DEN-8252-1: comment by Behrouz NematiPour "Is it ready for review?"

Behrouz NematiPour — Fri, 25 Jun 2021 12:53:23 -0700

Behrouz NematiPour commented on UI-DEN-8252-1

Is it ready for review?

UI-DEN-8252-1: reviewers finished

Wed, 16 Jun 2021 08:14:34 -0700

pmontazemi (deleted user) finished reviewing UI-DEN-8252-1

UI-DEN-8252_POST

UI-DEN-8514-2: started by Behrouz NematiPour

Behrouz NematiPour — Mon, 14 Jun 2021 11:26:24 -0700

Behrouz NematiPour started review UI-DEN-8514-2

application (bugfix/DEN-16597-UI-BN-S114): DEN-8523: Bluetooth cuff...

Behrouz NematiPour — Sun, 06 Jun 2021 13:35:32 -0700

Behrouz NematiPour committed 97d593e on branch master, @Environement_Swith and 217 more in application

DEN-8523: Bluetooth cuff

- Although there is not specific Bluetooth setting appear here but the entire idea here is to prepare the application to have a better platform for device handling like Bluetooth and the other ones.

· /denali.pro

(-1, +3)

| History

| Source

| Diff

· /denali.pro.user

(-1, +1)

| History

| Source

| Diff

· /denali.qrc

(-0, +1)

| History

| Source

| Diff

· /sources/ApplicationController.cpp

(-6, +2)

| History

| Source

| Diff

· /sources/ApplicationController.h

(-12, +5)

| History

| Source

| Diff

· /sources/canbus/FrameInterface.cpp

(-1, +6)

| History

| Source

| Diff

· /sources/canbus/MessageBuilder.h

(-1, +0)

| History

| Source

| Diff

· /sources/device/DeviceController.cpp

(-45, +72)

| History

| Source

| Diff

· /sources/device/DeviceController.h

(-13, +14)

| History

| Source

| Diff

· /sources/device/DeviceError.cpp

(-0, +52)

| History

| Source

· /sources/device/DeviceError.h

(-0, +70)

| History

| Source

· /sources/device/DeviceGlobals.h

(-20, +128)

| History

| Source

| Diff

· /sources/device/DeviceModels.h

(-18, +25)

| History

| Source

| Diff

· /sources/device/DeviceView.cpp

(-19, +10)

| History

| Source

| Diff

· /sources/device/DeviceView.h

(-10, +6)

| History

| Source

| Diff

… 7 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): DEN-8533 & DEN-8693...

Behrouz NematiPour — Thu, 03 Jun 2021 01:52:37 -0700

Behrouz NematiPour committed 61f16c9 on branch master, @Environement_Swith and 217 more in application

DEN-8533 & DEN-8693

Merge and support

· /denali.pro

(-4, +8)

| History

| Source

| Diff

· /denali.pro.user

(-1, +1)

| History

| Source

| Diff

· /en_US.udic

(-0, +4)

| History

| Source

| Diff

· /main.cpp

(-3, +3)

| History

| Source

| Diff

· /sources/ApplicationController.cpp

(-14, +22)

| History

| Source

| Diff

· /sources/ApplicationController.h

(-0, +12)

| History

| Source

| Diff

· /sources/Threads.cpp

(-2, +2)

| History

| Source

| Diff

· /sources/Threads.h

(-7, +7)

| History

| Source

| Diff

· /sources/canbus/MessageDispatcher.cpp

(-39, +54)

| History

| Source

| Diff

· /sources/canbus/MessageDispatcher.h

(-0, +3)

| History

| Source

| Diff

· /sources/device/DeviceController.cpp

(-0, +475)

| History

| Source

· /sources/device/DeviceController.h

(-0, +171)

| History

| Source

· /sources/device/DeviceGlobals.h

(-0, +58)

| History

| Source

· /sources/device/DeviceModels.cpp

(-0, +26)

| History

| Source

· /sources/device/DeviceModels.h

(-0, +105)

| History

| Source

… 30 more files in changeset.

UI-DEN-8252-1: started by plucia

plucia — Wed, 02 Jun 2021 13:31:53 -0700

plucia (deleted user) started review UI-DEN-8252-1

UI-DEN-8252-1: comment by plucia "Note for reviewers: I've created this review ..."

plucia — Wed, 02 Jun 2021 13:31:40 -0700

plucia (deleted user) commented on UI-DEN-8252-1

Note for reviewers:
I've created this review ahead of time
I am still working on the implementation

UI-DEN-8495-1: closed by Behrouz NematiPour

Behrouz NematiPour — Fri, 28 May 2021 17:43:25 -0700

Behrouz NematiPour Closed UI-DEN-8495-1

UI-DEN-8308-1: closed by Behrouz NematiPour

Behrouz NematiPour — Fri, 28 May 2021 17:42:15 -0700

Behrouz NematiPour Closed UI-DEN-8308-1

UI-DEN-8495-1: reviewers finished

Fri, 28 May 2021 17:21:35 -0700

plucia (deleted user) finished reviewing UI-DEN-8495-1

UI-DEN-8495_UI Dev Service Manual Disinfection & Flush

UI-DEN-8308-1: reviewers finished

Fri, 28 May 2021 17:12:37 -0700

plucia (deleted user) finished reviewing UI-DEN-8308-1

UI-DEN-8308_UI DEV Treatment Log

UI-DEN-8308-1: comment by plucia "RESOLVED"

plucia — Fri, 28 May 2021 17:12:02 -0700

plucia (deleted user) replied to plucia (deleted user) in UI-DEN-8308-1

RESOLVED

UI-DEN-8308-1: comment by plucia "From what I can tell the dg command is separate..."

plucia — Tue, 25 May 2021 12:27:20 -0700

plucia (deleted user) replied to Behrouz NematiPour in UI-DEN-8308-1

From what I can tell the dg command is separated from the hd command which is good.
Please let me know when your code is ready to be merged to staging and I will handle it.
Also for the next feature you're working on please branch off of the latest staging.

UI-DEN-8308-1: comment by Behrouz NematiPour "I don't have dg_simulator. It would be a merge..."

Behrouz NematiPour — Tue, 25 May 2021 12:04:35 -0700

Behrouz NematiPour replied to plucia (deleted user) in UI-DEN-8308-1

I don't have dg_simulator.
It would be a merge task later to merge this code into the staging, I think it's out of the code review scope.

UI-DEN-8495-1: comment by plucia "RESOLVED"

plucia — Tue, 25 May 2021 10:54:44 -0700

plucia (deleted user) replied to Behrouz NematiPour in UI-DEN-8495-1

RESOLVED

UI-DEN-8495-1: comment by plucia "RESOLVED"

plucia — Tue, 25 May 2021 10:54:29 -0700

plucia (deleted user) replied to Behrouz NematiPour in UI-DEN-8495-1

RESOLVED

UI-DEN-8308-1: comment by plucia "The dg simulator needs to be used for dg respon..."

plucia — Tue, 25 May 2021 10:40:27 -0700

plucia (deleted user) replied to Behrouz NematiPour in UI-DEN-8308-1

The dg simulator needs to be used for dg responses here still

UI-DEN-8308-1: comment by plucia "RESOLVED"

plucia — Tue, 25 May 2021 10:45:34 -0700

plucia (deleted user) replied to Behrouz NematiPour in UI-DEN-8308-1

RESOLVED