Fisheye on dgfirmware/firmware/App/Services/SystemComm.h https://devapps.diality.us/changelog/~br%3DDEN-16595-2-vectorcast-unit-and-integration-testing/dgfirmware/firmware/App/Services/SystemComm.h Recent activity in "dgfirmware" under directory /firmware/App/Services/SystemComm.h DG-DEN-14902-1: closed by Dara Navaei Fri, 15 Nov 2024 12:53:35 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14902-1 https://devapps.diality.us/cru/DG-DEN-14902-1 Dara Navaei Closed DG-DEN-14902-1 ]]> DG-DEN-11750-1: closed by Dara Navaei Thu, 19 Oct 2023 09:30:42 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-11750-1 https://devapps.diality.us/cru/DG-DEN-11750-1 Dara Navaei Closed DG-DEN-11750-1 ]]> DG-DEN-11750-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 09:30:29 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-11750-1/#c19137 https://devapps.diality.us/cru/DG-DEN-11750-1/#c19137 Dara Navaei replied to Michael Garthwaite in DG-DEN-11750-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-11750-1: started by Dara Navaei Thu, 19 Oct 2023 09:29:35 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-11750-1 https://devapps.diality.us/cru/DG-DEN-11750-1 Dara Navaei started review DG-DEN-11750-1 ]]> DG-DEN-3421-1: closed by Dara Navaei Thu, 19 Oct 2023 08:34:58 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-3421-1 https://devapps.diality.us/cru/DG-DEN-3421-1 Dara Navaei Closed DG-DEN-3421-1 ]]> DG-DEN-3421-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:34:41 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-3421-1/#c19107 https://devapps.diality.us/cru/DG-DEN-3421-1/#c19107 Dara Navaei replied to qnguyen  (deleted user) in DG-DEN-3421-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-3421-1: reviewers resumed Thu, 19 Oct 2023 08:29:12 -0700 https://devapps.diality.us/cru/DG-DEN-3421-1 https://devapps.diality.us/cru/DG-DEN-3421-1 pmontazemi  (deleted user) , qnguyen  (deleted user) and Sean Nash resumed reviewing DG-DEN-3421-1 DG-DEN-3421_DG Heat Disinfection ]]> DG-DEN-3421-1: started by Dara Navaei Thu, 19 Oct 2023 08:29:07 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-3421-1 https://devapps.diality.us/cru/DG-DEN-3421-1 Dara Navaei started review DG-DEN-3421-1 ]]> DG-DEN-4217-1: closed by Dara Navaei Thu, 19 Oct 2023 08:28:36 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-4217-1 https://devapps.diality.us/cru/DG-DEN-4217-1 Dara Navaei Closed DG-DEN-4217-1 ]]> DG-DEN-4217-1: reviewers finished Thu, 19 Oct 2023 08:28:27 -0700 https://devapps.diality.us/cru/DG-DEN-4217-1 https://devapps.diality.us/cru/DG-DEN-4217-1 Dara Navaei , qnguyen  (deleted user) and pmontazemi  (deleted user) finished reviewing DG-DEN-4217-1 DG-DEN-4217_Level and Shock Detection ]]> DG-DEN-4217-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:28:18 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-4217-1/#c19106 https://devapps.diality.us/cru/DG-DEN-4217-1/#c19106 Dara Navaei replied to pmontazemi  (deleted user) in DG-DEN-4217-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-4217-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:27:53 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-4217-1/#c19105 https://devapps.diality.us/cru/DG-DEN-4217-1/#c19105 Dara Navaei replied to pmontazemi  (deleted user) in DG-DEN-4217-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-4217-1: started by Dara Navaei Thu, 19 Oct 2023 08:26:45 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-4217-1 https://devapps.diality.us/cru/DG-DEN-4217-1 Dara Navaei started review DG-DEN-4217-1 ]]> DG-DEN-11750-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:34:06 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-11750-1/#c19086 https://devapps.diality.us/cru/DG-DEN-11750-1/#c19086 Dara Navaei replied to Michael Garthwaite in DG-DEN-11750-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-11750-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:33:40 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-11750-1/#c19085 https://devapps.diality.us/cru/DG-DEN-11750-1/#c19085 Dara Navaei replied to Michael Garthwaite in DG-DEN-11750-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-11750-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:33:26 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-11750-1/#c19084 https://devapps.diality.us/cru/DG-DEN-11750-1/#c19084 Dara Navaei replied to Michael Garthwaite in DG-DEN-11750-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-11750-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:32:37 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-11750-1/#c19083 https://devapps.diality.us/cru/DG-DEN-11750-1/#c19083 Dara Navaei replied to Michael Garthwaite in DG-DEN-11750-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-11750-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:32:12 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-11750-1/#c19082 https://devapps.diality.us/cru/DG-DEN-11750-1/#c19082 Dara Navaei replied to Michael Garthwaite in DG-DEN-11750-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-11750-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:31:50 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-11750-1/#c19081 https://devapps.diality.us/cru/DG-DEN-11750-1/#c19081 Dara Navaei replied to Michael Garthwaite in DG-DEN-11750-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-11750-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:31:44 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-11750-1/#c19080 https://devapps.diality.us/cru/DG-DEN-11750-1/#c19080 Dara Navaei replied to Michael Garthwaite in DG-DEN-11750-1

RESOLVED in CODE WALKTHROUGH

]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Mon, 21 Aug 2023 11:48:25 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=9b423e2af11aa2c990e1d3e050976b4d164b93ea https://devapps.diality.us/changelog/dgfirmware?cs=9b423e2af11aa2c990e1d3e050976b4d164b93ea Dara Navaei committed 9b423e2 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 74 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemComm.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemComm.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-1, +1) | History | Source | Diff
]]> DG-DEN-14706-1: closed by Michael Garthwaite Mon, 21 Aug 2023 11:27:26 -0700 Michael Garthwaite https://devapps.diality.us/cru/DG-DEN-14706-1 https://devapps.diality.us/cru/DG-DEN-14706-1 Michael Garthwaite Closed DG-DEN-14706-1 ]]> DG-DEN-14706-1: reviewers finished Mon, 21 Aug 2023 11:24:46 -0700 https://devapps.diality.us/cru/DG-DEN-14706-1 https://devapps.diality.us/cru/DG-DEN-14706-1 wbracken  (deleted user) and Sean Nash finished reviewing DG-DEN-14706-1 DG-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked ]]> DG-DEN-14706-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 21 Aug 2023 11:10:08 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-14706-1/#c18656 https://devapps.diality.us/cru/DG-DEN-14706-1/#c18656 Sean Nash replied to Michael Garthwaite in DG-DEN-14706-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-14706-1: comment by jtaylor "Suggest aligning comments in the block above" Fri, 18 Aug 2023 09:33:24 -0700 jtaylor https://devapps.diality.us/cru/DG-DEN-14706-1/#c18623 https://devapps.diality.us/cru/DG-DEN-14706-1/#c18623 jtaylor  (deleted user) commented on DG-DEN-14706-1

Suggest aligning comments in the block above

]]> DG-DEN-14706-1: comment by Michael Garthwaite "Removed #define. Thanks!" Fri, 18 Aug 2023 12:35:06 -0700 Michael Garthwaite https://devapps.diality.us/cru/DG-DEN-14706-1/#c18649 https://devapps.diality.us/cru/DG-DEN-14706-1/#c18649 Michael Garthwaite replied to Sean Nash in DG-DEN-14706-1

Removed #define. Thanks!

]]> DG-DEN-14706-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 18 Aug 2023 11:04:37 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-14706-1/#c18645 https://devapps.diality.us/cru/DG-DEN-14706-1/#c18645 Sean Nash replied to Sean Nash in DG-DEN-14706-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-14706-1: comment by Sean Nash "I think override should be OR'd with timeout on..." Fri, 18 Aug 2023 09:57:09 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-14706-1/#c18626 https://devapps.diality.us/cru/DG-DEN-14706-1/#c18626 Sean Nash commented on DG-DEN-14706-1

I think override should be OR'd with timeout only. The used condition should still have to be true even if override is in place.

]]> DG-DEN-14706-1: comment by Sean Nash "I don't see where this #define is ever used. R..." Fri, 18 Aug 2023 09:58:43 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-14706-1/#c18627 https://devapps.diality.us/cru/DG-DEN-14706-1/#c18627 Sean Nash replied to jtaylor  (deleted user) in DG-DEN-14706-1

I don't see where this #define is ever used. Remove if not needed.

]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14706: DG ACK pending override message handling and implementation. Thu, 17 Aug 2023 19:59:21 -0700 Michael Garthwaite https://devapps.diality.us/changelog/dgfirmware?cs=aa1367aa813db6acc52013795a8c6e58405bb10e https://devapps.diality.us/changelog/dgfirmware?cs=aa1367aa813db6acc52013795a8c6e58405bb10e Michael Garthwaite committed aa1367a on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 76 more in dgfirmware DEN-14706: DG ACK pending override message handling and implementation.

· /firmware/App/Services/SystemComm.c (-1, +52) | History | Source | Diff
· /firmware/App/Services/SystemComm.h (-0, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-0, +32) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-0, +3) | History | Source | Diff
]]>