DG-DEN-11750-1 DG-DEN-11750_DG Dev Dialysate Temperature Control Tune Up

closed on 19 Oct 23

Author

Moderator

Reviewers

DG-DEN-11750_DG Dev Dialysate Temperature Control Tune Up

Activity

Details
Objectives
General Comments 2
Unresolved
Resolved
Number of files included: 54

common 0
- File AlarmDefs.h 0 Remove
- File Compatibility.h 0 Remove
- File Compatible.h 3 Remove
- File DGDefs.h 0 Remove
- File HDDefs.h 0 Remove
- File MsgDefs.h 0 Remove
dgfirmware 0
- Folder firmware 0
  - Folder App 0
    - Folder Controllers 0
      - File ConcentratePumps.c 0 Remove
      - File ConductivitySensors.c 8 Remove
      - File ConductivitySensors.h 0 Remove
      - File DialysateFlow.c 4 Remove
      - File DrainPump.c 0 Remove
      - File DrainPump.h 0 Remove
      - File Fans.c 7 Remove
      - File Fans.h 0 Remove
      - File FluidLeak.c 0 Remove
      - File Heaters.c 3 Remove
      - File LoadCell.c 4 Remove
      - File Pressures.c 0 Remove
      - File ROPump.c 0 Remove
      - File ROPump.h 0 Remove
      - File Switches.c 0 Remove
      - File TemperatureSensors.c 3 Remove
      - File TemperatureSensors.h 0 Remove
      - File Thermistors.c 0 Remove
      - File UVReactors.c 5 Remove
      - File Valves.c 0 Remove
      - File Voltages.c 0 Remove
    - Folder Drivers 0
      - File InternalADC.c 0 Remove
    - Folder Modes 0
      - File ModeChemicalDisinfect.c 21 Remove
      - File ModeDrain.c 0 Remove
      - File ModeFill.c 0 Remove
      - File ModeFlush.c 0 Remove
      - File ModeGenIdle.c 0 Remove
      - File ModeHeatDisinfect.c 7 Remove
      - File OperationModes.c 0 Remove
    - Folder Services 0
      - File AlarmMgmt.c 3 Remove
      - File AlarmMgmt.h 0 Remove
      - File AlarmMgmtSWFaults.h 0 Remove
      - File Reservoirs.c 10 Remove
      - File Reservoirs.h 0 Remove
      - File SystemComm.c 0 Remove
      - File SystemComm.h 0 Remove
      - File SystemCommMessages.c 3 Remove
      - File SystemCommMessages.h 0 Remove
    - Folder Tasks 0
      - File TaskPriority.c 0 Remove
    - File DGCommon.h 0 Remove
  - Folder source 0
    - File sys_selftest.c 0 Remove
fwcommon 0
- File Accel.c 0 Remove
- File Common.h 2 Remove
- File NVDataMgmt.c 5 Remove
- File NVDataMgmt.h 3 Remove
- File NVDataMgmtDGRecords.h 6 Remove
- File NVDataMgmtHDRecords.h 6 Remove
- File RTC.c 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Dara Navaei	Author & Moderator	2h 14m	40	RESOLVED in CODE WALKTHROUGH
hnguyen (deleted user)	Reviewer - 0% reviewed	0m
Sean Nash	Reviewer - Complete	2h 53m	48	RESOLVED in CODE WALKTHROUGH.
Michael Garthwaite	Reviewer - Complete	1h 27m	17	RESOVLED IN CODE WALKTHROUGH.
Behrouz NematiPour	Reviewer - 0% reviewed	1m
Total		6h 36m	105

Linked issues
- DEN-11250
- DEN-11750

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Michael Garthwaite

Notices the 170 files that need to be reviewed https://c.tenor.com/RXMxqsRKE...

Notices the 170 files that need to be reviewed

https://c.tenor.com/RXMxqsRKEn0AAAAC/this-is-fine.gif

22 Feb 22

Dara Navaei

Most of the files are VectorCAST that has been brought back from Code Clinic....

Most of the files are VectorCAST that has been brought back from Code Clinic. Look at the files but they are auto generated so they are mostly passing through.

22 Feb 22

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

DG-DEN-11750-1

DG-DEN-11750_DG Dev Dialysate Temperature Control Tune Up

DG-DEN-11750-1 105

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Michael Garthwaite

Dara Navaei

Log time

DG-DEN-11750_DG Dev Dialysate Temperature Control Tune Up

DG-DEN-11750-1 105

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Michael Garthwaite

Dara Navaei

Log time