Fisheye on dgfirmware/firmware/App/Controllers/DrainPump.c https://devapps.diality.us/changelog/~br%3DDEN-16674-td2-calibration-feature/dgfirmware/firmware/App/Controllers/DrainPump.c Recent activity in "dgfirmware" under directory /firmware/App/Controllers/DrainPump.c DG-DEN-14902-1: closed by Dara Navaei Fri, 15 Nov 2024 12:53:35 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14902-1 https://devapps.diality.us/cru/DG-DEN-14902-1 Dara Navaei Closed DG-DEN-14902-1 ]]> DG-DEN-16773-1: closed by Dara Navaei Tue, 19 Mar 2024 18:20:47 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16773-1 https://devapps.diality.us/cru/DG-DEN-16773-1 Dara Navaei Closed DG-DEN-16773-1 ]]> DG-DEN-16773-1: reviewers finished Tue, 19 Mar 2024 18:11:40 -0700 https://devapps.diality.us/cru/DG-DEN-16773-1 https://devapps.diality.us/cru/DG-DEN-16773-1 Sean Nash and Vinayakam Mani finished reviewing DG-DEN-16773-1 DG-DEN-16773_Add Chemical Disinfect Enable Institutional Record 2 ]]> DG-DEN-16773-1: reviewers added to DG-DEN-16773_Add Chemical Disinfect Enable Institu... Tue, 19 Mar 2024 17:26:41 -0700 https://devapps.diality.us/cru/DG-DEN-16773-1 https://devapps.diality.us/cru/DG-DEN-16773-1 Dara Navaei added pvedantam  (deleted user) to DG-DEN-16773-1 DG-DEN-16773_Add Chemical Disinfect Enable Institutional Record 2 ]]> DG-DEN-16773-1: started by Dara Navaei Tue, 19 Mar 2024 16:11:07 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16773-1 https://devapps.diality.us/cru/DG-DEN-16773-1 Dara Navaei started review DG-DEN-16773-1 ]]> DG-DEN-16769-1: closed by Dara Navaei Tue, 19 Mar 2024 15:55:23 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16769-1 https://devapps.diality.us/cru/DG-DEN-16769-1 Dara Navaei Closed DG-DEN-16769-1 ]]> DG-DEN-16769-1: reviewers finished Mon, 18 Mar 2024 11:26:41 -0700 https://devapps.diality.us/cru/DG-DEN-16769-1 https://devapps.diality.us/cru/DG-DEN-16769-1 Sean Nash and Vinayakam Mani finished reviewing DG-DEN-16769-1 DG-DEN-16769_Alarm 280 DG Fault Drp Direction Fault ]]> DG-DEN-16769-1: reviewers added to DG-DEN-16769_Alarm 280 DG Fault Drp Direction Faul... Mon, 18 Mar 2024 09:35:28 -0700 https://devapps.diality.us/cru/DG-DEN-16769-1 https://devapps.diality.us/cru/DG-DEN-16769-1 Dara Navaei added pvedantam  (deleted user) to DG-DEN-16769-1 DG-DEN-16769_Alarm 280 DG Fault Drp Direction Fault ]]> DG-DEN-16769-1: started by Dara Navaei Mon, 18 Mar 2024 09:31:48 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16769-1 https://devapps.diality.us/cru/DG-DEN-16769-1 Dara Navaei started review DG-DEN-16769-1 ]]> DG-DEN-16682-3: closed by Dara Navaei Mon, 11 Mar 2024 10:14:09 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16682-3 https://devapps.diality.us/cru/DG-DEN-16682-3 Dara Navaei Closed DG-DEN-16682-3 ]]> DG-DEN-16682-3: reviewers finished Mon, 11 Mar 2024 10:13:39 -0700 https://devapps.diality.us/cru/DG-DEN-16682-3 https://devapps.diality.us/cru/DG-DEN-16682-3 Vinayakam Mani and Sean Nash finished reviewing DG-DEN-16682-3 DG-DEN-16682_Use Cd2 Values For Acid Check ]]> DG-DEN-16682-3: reviewers added to DG-DEN-16682_Use Cd2 Values For Acid Check Mon, 11 Mar 2024 10:07:56 -0700 https://devapps.diality.us/cru/DG-DEN-16682-3 https://devapps.diality.us/cru/DG-DEN-16682-3 Dara Navaei added pvedantam  (deleted user) to DG-DEN-16682-3 DG-DEN-16682_Use Cd2 Values For Acid Check ]]> DG-DEN-16682-3: reviewers resumed Fri, 08 Mar 2024 16:40:34 -0800 https://devapps.diality.us/cru/DG-DEN-16682-3 https://devapps.diality.us/cru/DG-DEN-16682-3 Michael Garthwaite resumed reviewing DG-DEN-16682-3 DG-DEN-16682_Use Cd2 Values For Acid Check ]]> DG-DEN-16682-3: started by Dara Navaei Thu, 07 Mar 2024 10:42:29 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16682-3 https://devapps.diality.us/cru/DG-DEN-16682-3 Dara Navaei started review DG-DEN-16682-3 ]]> DG-DEN-16682-2: closed by Dara Navaei Thu, 07 Mar 2024 09:59:08 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16682-2 https://devapps.diality.us/cru/DG-DEN-16682-2 Dara Navaei Closed DG-DEN-16682-2 ]]> DG-DEN-16682-2: reviewers finished Thu, 07 Mar 2024 09:55:51 -0800 https://devapps.diality.us/cru/DG-DEN-16682-2 https://devapps.diality.us/cru/DG-DEN-16682-2 Vinayakam Mani and Michael Garthwaite finished reviewing DG-DEN-16682-2 DG-DEN-16682_Use Cd2 Values For Acid Check ]]> DG-DEN-16682-2: reviewers removed from DG-DEN-16682_Use Cd2 Values For Acid Check Thu, 07 Mar 2024 09:48:35 -0800 https://devapps.diality.us/cru/DG-DEN-16682-2 https://devapps.diality.us/cru/DG-DEN-16682-2 Dara Navaei removed msuleiman  (deleted user) from DG-DEN-16682-2 DG-DEN-16682_Use Cd2 Values For Acid Check ]]> DG-DEN-16682-2: reviewers added to DG-DEN-16682_Use Cd2 Values For Acid Check Thu, 07 Mar 2024 09:48:07 -0800 https://devapps.diality.us/cru/DG-DEN-16682-2 https://devapps.diality.us/cru/DG-DEN-16682-2 Dara Navaei added Behrouz NematiPour and msuleiman  (deleted user) to DG-DEN-16682-2 DG-DEN-16682_Use Cd2 Values For Acid Check ]]> DG-DEN-16682-2: reviewers resumed Wed, 06 Mar 2024 14:48:51 -0800 https://devapps.diality.us/cru/DG-DEN-16682-2 https://devapps.diality.us/cru/DG-DEN-16682-2 Sean Nash resumed reviewing DG-DEN-16682-2 DG-DEN-16682_Use Cd2 Values For Acid Check ]]> DG-DEN-16682-2: reviewers added to DG-DEN-16682_Use Cd2 Values For Acid Check Sat, 02 Mar 2024 18:38:39 -0800 https://devapps.diality.us/cru/DG-DEN-16682-2 https://devapps.diality.us/cru/DG-DEN-16682-2 Dara Navaei added pvedantam  (deleted user) to DG-DEN-16682-2 DG-DEN-16682_Use Cd2 Values For Acid Check ]]> DG-DEN-16674-2: closed by Dara Navaei Fri, 01 Mar 2024 16:31:05 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16674-2 https://devapps.diality.us/cru/DG-DEN-16674-2 Dara Navaei Closed DG-DEN-16674-2 ]]> DG-DEN-16674-2: reviewers finished Fri, 01 Mar 2024 16:21:45 -0800 https://devapps.diality.us/cru/DG-DEN-16674-2 https://devapps.diality.us/cru/DG-DEN-16674-2 Vinayakam Mani and Sean Nash finished reviewing DG-DEN-16674-2 DG-DEN-16674_Td2 Calibration Feature ]]> DG-DEN-16674-2: comment by Vinayakam Mani "RESOLVED IN CODE WALKTHROUGH" Fri, 01 Mar 2024 16:21:27 -0800 Vinayakam Mani https://devapps.diality.us/cru/DG-DEN-16674-2/#c19552 https://devapps.diality.us/cru/DG-DEN-16674-2/#c19552 Vinayakam Mani replied to Dara Navaei in DG-DEN-16674-2

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-16682-2: started by Dara Navaei Fri, 01 Mar 2024 16:16:05 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16682-2 https://devapps.diality.us/cru/DG-DEN-16682-2 Dara Navaei started review DG-DEN-16682-2 ]]> DG-DEN-16674-2: comment by Dara Navaei "Done" Fri, 01 Mar 2024 15:50:52 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16674-2/#c19551 https://devapps.diality.us/cru/DG-DEN-16674-2/#c19551 Dara Navaei replied to Vinayakam Mani in DG-DEN-16674-2

Done

]]> DG-DEN-16674-2: comment by Vinayakam Mani "Can we bring a parenthesis for better readabili..." Fri, 01 Mar 2024 13:38:40 -0800 Vinayakam Mani https://devapps.diality.us/cru/DG-DEN-16674-2/#c19550 https://devapps.diality.us/cru/DG-DEN-16674-2/#c19550 Vinayakam Mani commented on DG-DEN-16674-2

Can we bring a parenthesis for better readability?

]]> DG-DEN-16674-2: reviewers added to DG-DEN-16674_Td2 Calibration Feature Fri, 01 Mar 2024 10:54:45 -0800 https://devapps.diality.us/cru/DG-DEN-16674-2 https://devapps.diality.us/cru/DG-DEN-16674-2 Dara Navaei added Behrouz NematiPour to DG-DEN-16674-2 DG-DEN-16674_Td2 Calibration Feature ]]> dgfirmware (DENBUG-236-alarm-97-when-running-treatment-45-seconds-p1-staging): DEN-16674 updated the code from staging Fri, 01 Mar 2024 09:27:38 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=61c74b7c3a092f9e2900665f1a4f0391f78c5c03 https://devapps.diality.us/changelog/dgfirmware?cs=61c74b7c3a092f9e2900665f1a4f0391f78c5c03 Dara Navaei committed 61c74b7 on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-16674-td2-calibration-feature and 11 more in dgfirmware DEN-16674 updated the code from staging

· /firmware/App/Controllers/ConductivitySensors.c (-10, +21) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-46, +14) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-1, +68) | History | Source | Diff
· /firmware/App/Controllers/UVReactors.c (-4, +4) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-7, +94) | History | Source | Diff
· /firmware/App/Modes/ModeFill.h (-0, +2) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-0, +4) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-0, +28) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-0, +3) | History | Source | Diff
]]> DG-DEN-16674-2: started by Dara Navaei Fri, 01 Mar 2024 08:41:42 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16674-2 https://devapps.diality.us/cru/DG-DEN-16674-2 Dara Navaei started review DG-DEN-16674-2 ]]> DG-DEN-16674-1: closed by Dara Navaei Thu, 29 Feb 2024 14:45:27 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16674-1 https://devapps.diality.us/cru/DG-DEN-16674-1 Dara Navaei Closed DG-DEN-16674-1 ]]>