Fisheye on dgfirmware/firmware/App/Controllers/UVReactors.c https://devapps.diality.us/changelog/~br%3DDEN-16674-td2-calibration-feature/dgfirmware/firmware/App/Controllers/UVReactors.c Recent activity in "dgfirmware" under directory /firmware/App/Controllers/UVReactors.c DG-DEN-17047-1: closed by Dara Navaei Sat, 08 Nov 2025 14:06:26 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17047-1 https://devapps.diality.us/cru/DG-DEN-17047-1 Dara Navaei Closed DG-DEN-17047-1 ]]> DG-DEN-14902-1: closed by Dara Navaei Fri, 15 Nov 2024 12:53:35 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14902-1 https://devapps.diality.us/cru/DG-DEN-14902-1 Dara Navaei Closed DG-DEN-14902-1 ]]> DG-DEN-17047-1: started by Dara Navaei Tue, 10 Sep 2024 12:12:10 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17047-1 https://devapps.diality.us/cru/DG-DEN-17047-1 Dara Navaei started review DG-DEN-17047-1 ]]> DG-DENBUG-236-3: closed by Dara Navaei Tue, 16 Apr 2024 10:19:51 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-236-3 https://devapps.diality.us/cru/DG-DENBUG-236-3 Dara Navaei Closed DG-DENBUG-236-3 ]]> DG-DENBUG-236-3: reviewers finished Tue, 16 Apr 2024 10:17:50 -0700 https://devapps.diality.us/cru/DG-DENBUG-236-3 https://devapps.diality.us/cru/DG-DENBUG-236-3 Sean Nash and Vinayakam Mani finished reviewing DG-DENBUG-236-3 DG-DENBUG-236_Alarm 97 When Running Treatmenet Vectorcast ]]> DG-DENBUG-236-3: started by Dara Navaei Tue, 16 Apr 2024 09:11:28 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-236-3 https://devapps.diality.us/cru/DG-DENBUG-236-3 Dara Navaei started review DG-DENBUG-236-3 ]]> DG-DENBUG-216-1: closed by Dara Navaei Fri, 05 Apr 2024 16:47:58 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-216-1 https://devapps.diality.us/cru/DG-DENBUG-216-1 Dara Navaei Closed DG-DENBUG-216-1 ]]> DG-DENBUG-216-1: reviewers finished Fri, 05 Apr 2024 16:34:35 -0700 https://devapps.diality.us/cru/DG-DENBUG-216-1 https://devapps.diality.us/cru/DG-DENBUG-216-1 Vinayakam Mani and Sean Nash finished reviewing DG-DENBUG-216-1 DG-DENBUG-216_Alarm 89 Alarm ID DG Outlet UV Reactor ON With NO Flow Triggered During Chem Disinfect Flush ]]> DG-DENBUG-216-1: started by Dara Navaei Fri, 05 Apr 2024 14:36:49 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-216-1 https://devapps.diality.us/cru/DG-DENBUG-216-1 Dara Navaei started review DG-DENBUG-216-1 ]]> DG-DEN-16674-2: closed by Dara Navaei Fri, 01 Mar 2024 16:31:05 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16674-2 https://devapps.diality.us/cru/DG-DEN-16674-2 Dara Navaei Closed DG-DEN-16674-2 ]]> DG-DEN-16674-2: reviewers finished Fri, 01 Mar 2024 16:21:45 -0800 https://devapps.diality.us/cru/DG-DEN-16674-2 https://devapps.diality.us/cru/DG-DEN-16674-2 Vinayakam Mani and Sean Nash finished reviewing DG-DEN-16674-2 DG-DEN-16674_Td2 Calibration Feature ]]> DG-DEN-16674-2: comment by Vinayakam Mani "RESOLVED IN CODE WALKTHROUGH" Fri, 01 Mar 2024 16:21:27 -0800 Vinayakam Mani https://devapps.diality.us/cru/DG-DEN-16674-2/#c19552 https://devapps.diality.us/cru/DG-DEN-16674-2/#c19552 Vinayakam Mani replied to Dara Navaei in DG-DEN-16674-2

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-16674-2: comment by Dara Navaei "Done" Fri, 01 Mar 2024 15:50:52 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16674-2/#c19551 https://devapps.diality.us/cru/DG-DEN-16674-2/#c19551 Dara Navaei replied to Vinayakam Mani in DG-DEN-16674-2

Done

]]> DG-DEN-16674-2: comment by Vinayakam Mani "Can we bring a parenthesis for better readabili..." Fri, 01 Mar 2024 13:38:40 -0800 Vinayakam Mani https://devapps.diality.us/cru/DG-DEN-16674-2/#c19550 https://devapps.diality.us/cru/DG-DEN-16674-2/#c19550 Vinayakam Mani commented on DG-DEN-16674-2

Can we bring a parenthesis for better readability?

]]> DG-DEN-16674-2: reviewers added to DG-DEN-16674_Td2 Calibration Feature Fri, 01 Mar 2024 10:54:45 -0800 https://devapps.diality.us/cru/DG-DEN-16674-2 https://devapps.diality.us/cru/DG-DEN-16674-2 Dara Navaei added Behrouz NematiPour to DG-DEN-16674-2 DG-DEN-16674_Td2 Calibration Feature ]]> dgfirmware (DENBUG-236-alarm-97-when-running-treatment-45-seconds-p1-staging): DEN-16674 updated the code from staging Fri, 01 Mar 2024 09:27:38 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=61c74b7c3a092f9e2900665f1a4f0391f78c5c03 https://devapps.diality.us/changelog/dgfirmware?cs=61c74b7c3a092f9e2900665f1a4f0391f78c5c03 Dara Navaei committed 61c74b7 on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-16674-td2-calibration-feature and 11 more in dgfirmware DEN-16674 updated the code from staging

· /firmware/App/Controllers/ConductivitySensors.c (-10, +21) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-46, +14) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-1, +68) | History | Source | Diff
· /firmware/App/Controllers/UVReactors.c (-4, +4) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-7, +94) | History | Source | Diff
· /firmware/App/Modes/ModeFill.h (-0, +2) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-0, +4) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-0, +28) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-0, +3) | History | Source | Diff
]]> DG-DEN-16674-2: started by Dara Navaei Fri, 01 Mar 2024 08:41:42 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16674-2 https://devapps.diality.us/cru/DG-DEN-16674-2 Dara Navaei started review DG-DEN-16674-2 ]]> DG-DEN-16674-1: closed by Dara Navaei Thu, 29 Feb 2024 14:45:27 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16674-1 https://devapps.diality.us/cru/DG-DEN-16674-1 Dara Navaei Closed DG-DEN-16674-1 ]]> DG-DEN-16674-1: reviewers finished Thu, 29 Feb 2024 13:45:11 -0800 https://devapps.diality.us/cru/DG-DEN-16674-1 https://devapps.diality.us/cru/DG-DEN-16674-1 Sean Nash finished reviewing DG-DEN-16674-1 DG-DEN-16674_Td2 Calibration Feature ]]> DG-DEN-16674-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 29 Feb 2024 13:44:32 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16674-1/#c19548 https://devapps.diality.us/cru/DG-DEN-16674-1/#c19548 Sean Nash replied to Dara Navaei in DG-DEN-16674-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-16674-1: comment by Dara Navaei "Done" Thu, 29 Feb 2024 13:04:04 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16674-1/#c19547 https://devapps.diality.us/cru/DG-DEN-16674-1/#c19547 Dara Navaei replied to Sean Nash in DG-DEN-16674-1

Done

]]> DG-DEN-16674-1: comment by Sean Nash "But this comment also asked that you remove the..." Thu, 29 Feb 2024 12:59:26 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16674-1/#c19546 https://devapps.diality.us/cru/DG-DEN-16674-1/#c19546 Sean Nash replied to Dara Navaei in DG-DEN-16674-1

But this comment also asked that you remove the transition to fill mode here and add it to the fill mode function called above. It's still here.

]]> DG-DEN-16674-1: comment by Dara Navaei "No I will check the Dialin check in the functio..." Thu, 29 Feb 2024 12:51:48 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16674-1/#c19545 https://devapps.diality.us/cru/DG-DEN-16674-1/#c19545 Dara Navaei replied to Sean Nash in DG-DEN-16674-1

No I will check the Dialin check in the function like the rest of the commands from Dialin.

]]> DG-DEN-16674-1: comment by Sean Nash "I don't see change. Did you push?" Thu, 29 Feb 2024 12:50:36 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16674-1/#c19544 https://devapps.diality.us/cru/DG-DEN-16674-1/#c19544 Sean Nash replied to Dara Navaei in DG-DEN-16674-1

I don't see change. Did you push?

]]> DG-DEN-16674-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 29 Feb 2024 12:50:11 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16674-1/#c19543 https://devapps.diality.us/cru/DG-DEN-16674-1/#c19543 Sean Nash replied to Dara Navaei in DG-DEN-16674-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-16674-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 29 Feb 2024 12:49:56 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16674-1/#c19542 https://devapps.diality.us/cru/DG-DEN-16674-1/#c19542 Sean Nash replied to Dara Navaei in DG-DEN-16674-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-16674-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 29 Feb 2024 12:49:34 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16674-1/#c19541 https://devapps.diality.us/cru/DG-DEN-16674-1/#c19541 Sean Nash replied to Dara Navaei in DG-DEN-16674-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-16674-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 29 Feb 2024 12:49:06 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-16674-1/#c19540 https://devapps.diality.us/cru/DG-DEN-16674-1/#c19540 Sean Nash replied to Dara Navaei in DG-DEN-16674-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-16674-1: comment by Dara Navaei "Done" Thu, 29 Feb 2024 10:58:17 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16674-1/#c19539 https://devapps.diality.us/cru/DG-DEN-16674-1/#c19539 Dara Navaei replied to Sean Nash in DG-DEN-16674-1

Done

]]> DG-DEN-16674-1: comment by Dara Navaei "Done" Thu, 29 Feb 2024 10:53:25 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16674-1/#c19538 https://devapps.diality.us/cru/DG-DEN-16674-1/#c19538 Dara Navaei replied to Sean Nash in DG-DEN-16674-1

Done

]]>