Fisheye on dgfirmware/firmware/App/Modes/ModeChemicalDisinfect.c https://devapps.diality.us/changelog/~br%3DDEN-17047-remove-uv-reactors-from-code-bases/dgfirmware/firmware/App/Modes/ModeChemicalDisinfect.c Recent activity in "dgfirmware" under directory /firmware/App/Modes/ModeChemicalDisinfect.c DG-DEN-17047-1: closed by Dara Navaei Sat, 08 Nov 2025 14:06:26 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17047-1 https://devapps.diality.us/cru/DG-DEN-17047-1 Dara Navaei Closed DG-DEN-17047-1 ]]> DG-DEN-14902-1: closed by Dara Navaei Fri, 15 Nov 2024 12:53:35 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14902-1 https://devapps.diality.us/cru/DG-DEN-14902-1 Dara Navaei Closed DG-DEN-14902-1 ]]> DG-DEN-17053-6: closed by Dara Navaei Fri, 20 Sep 2024 16:39:59 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17053-6 https://devapps.diality.us/cru/DG-DEN-17053-6 Dara Navaei Closed DG-DEN-17053-6 ]]> DG-DEN-17053-6: reviewers finished Tue, 17 Sep 2024 10:27:48 -0700 https://devapps.diality.us/cru/DG-DEN-17053-6 https://devapps.diality.us/cru/DG-DEN-17053-6 Michael Garthwaite finished reviewing DG-DEN-17053-6 DG-DEN-17053_Release 17 Firmware Update ]]> DG-DEN-17053-6: reviewers finished Mon, 16 Sep 2024 11:10:23 -0700 https://devapps.diality.us/cru/DG-DEN-17053-6 https://devapps.diality.us/cru/DG-DEN-17053-6 Sean Nash finished reviewing DG-DEN-17053-6 DG-DEN-17053_Release 17 Firmware Update ]]> DG-DEN-17053-6: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 16 Sep 2024 11:10:15 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-17053-6/#c20214 https://devapps.diality.us/cru/DG-DEN-17053-6/#c20214 Sean Nash replied to Dara Navaei in DG-DEN-17053-6

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-17053-6: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 16 Sep 2024 11:10:01 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-17053-6/#c20213 https://devapps.diality.us/cru/DG-DEN-17053-6/#c20213 Sean Nash replied to Dara Navaei in DG-DEN-17053-6

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-17053-6: comment by Dara Navaei "Done" Mon, 16 Sep 2024 11:07:10 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17053-6/#c20212 https://devapps.diality.us/cru/DG-DEN-17053-6/#c20212 Dara Navaei replied to Sean Nash in DG-DEN-17053-6

Done

]]> DG-DEN-17053-6: comment by Dara Navaei "Done" Mon, 16 Sep 2024 11:04:54 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17053-6/#c20211 https://devapps.diality.us/cru/DG-DEN-17053-6/#c20211 Dara Navaei replied to Sean Nash in DG-DEN-17053-6

Done

]]> DG-DEN-17053-6: comment by Sean Nash "No colon." Fri, 13 Sep 2024 12:59:49 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-17053-6/#c20209 https://devapps.diality.us/cru/DG-DEN-17053-6/#c20209 Sean Nash commented on DG-DEN-17053-6

No colon.

]]> DG-DEN-17053-6: comment by Sean Nash "Do not put colons after params." Fri, 13 Sep 2024 12:59:26 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-17053-6/#c20208 https://devapps.diality.us/cru/DG-DEN-17053-6/#c20208 Sean Nash commented on DG-DEN-17053-6

Do not put colons after params.

]]> DG-DEN-17053-6: started by Dara Navaei Fri, 13 Sep 2024 12:24:35 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17053-6 https://devapps.diality.us/cru/DG-DEN-17053-6 Dara Navaei started review DG-DEN-17053-6 ]]> DG-DEN-16970-1: closed by Dara Navaei Thu, 12 Sep 2024 13:40:34 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16970-1 https://devapps.diality.us/cru/DG-DEN-16970-1 Dara Navaei Closed DG-DEN-16970-1 ]]> DG-DEN-16970-1: reviewers finished Thu, 12 Sep 2024 13:37:36 -0700 https://devapps.diality.us/cru/DG-DEN-16970-1 https://devapps.diality.us/cru/DG-DEN-16970-1 Vinayakam Mani and Sean Nash finished reviewing DG-DEN-16970-1 DG-DEN-16970_Stuck IN Cancel Basic Path During Heat Disinfect Passive Cool ]]> dgfirmware (DEN-17047-remove-uv-reactors-from-code-bases): DEN-17047 removed the UV reactors code from the firmware Tue, 10 Sep 2024 12:28:10 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=7f45e52be52e11e33178e6a0eb86c67806e6921e https://devapps.diality.us/changelog/dgfirmware?cs=7f45e52be52e11e33178e6a0eb86c67806e6921e Dara Navaei committed 7f45e52 on branch DEN-17047-remove-uv-reactors-from-code-bases in dgfirmware DEN-17047 removed the UV reactors code from the firmware

· /firmware/App/Controllers/UVReactors.c (-627, +0) | History | Source | Diff
· /firmware/App/Controllers/UVReactors.h (-88, +0) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c (-7, +0) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-5, +0) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-5, +0) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-3, +0) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-15, +0) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-5, +0) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-7, +0) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c (-26, +0) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-14, +2) | History | Source | Diff
· /firmware/App/Modes/ModeROPermeateSample.c (-25, +0) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-28, +3) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-1, +0) | History | Source | Diff
· /firmware/App/Tasks/TaskGeneral.c (-4, +0) | History | Source | Diff
· /firmware/source/sys_main.c (-2, +0) | History | Source | Diff
]]> DG-DEN-17047-1: started by Dara Navaei Tue, 10 Sep 2024 12:12:10 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17047-1 https://devapps.diality.us/cru/DG-DEN-17047-1 Dara Navaei started review DG-DEN-17047-1 ]]> DG-DEN-16970-1: reviewers added to DG-DEN-16970_Stuck IN Cancel Basic Path During Hea... Mon, 09 Sep 2024 16:13:17 -0700 https://devapps.diality.us/cru/DG-DEN-16970-1 https://devapps.diality.us/cru/DG-DEN-16970-1 Dara Navaei added pvedantam  (deleted user) to DG-DEN-16970-1 DG-DEN-16970_Stuck IN Cancel Basic Path During Heat Disinfect Passive Cool ]]> DG-DEN-16970-1: started by Dara Navaei Mon, 09 Sep 2024 12:58:27 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16970-1 https://devapps.diality.us/cru/DG-DEN-16970-1 Dara Navaei started review DG-DEN-16970-1 ]]> dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Mon, 08 Jan 2024 14:00:04 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=7d4711edd7b40cd3e29f43e766f79a8a09586fe9 https://devapps.diality.us/changelog/dgfirmware?cs=7d4711edd7b40cd3e29f43e766f79a8a09586fe9 Dara Navaei committed 7d4711e on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16499-fw-message-list-testing-issues and 28 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/Fans.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-1, +1) | History | Source | Diff
… 86 more files in changeset.
]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 10 Nov 2023 15:05:40 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=fee34142c8fac0075a7573600c1977a0fb083b8e https://devapps.diality.us/changelog/dgfirmware?cs=fee34142c8fac0075a7573600c1977a0fb083b8e Dara Navaei committed fee3414 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 48 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeChemicalDisinfect.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-2, +2) | History | Source | Diff
]]> DG-DENBUG-187-3: closed by Dara Navaei Fri, 10 Nov 2023 12:22:42 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-187-3 https://devapps.diality.us/cru/DG-DENBUG-187-3 Dara Navaei Closed DG-DENBUG-187-3 ]]> DG-DENBUG-187-3: reviewers finished Fri, 10 Nov 2023 10:00:37 -0800 https://devapps.diality.us/cru/DG-DENBUG-187-3 https://devapps.diality.us/cru/DG-DENBUG-187-3 Sean Nash and jtaylor  (deleted user) finished reviewing DG-DENBUG-187-3 DG-DENBUG-187_Chemical Disinfect Start Date Does Not Update When Using DI Water OR Acetic Acid ]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-187 changed the code to set the chem disinfect start date at the prime state and changed the other DG modes to ch... Fri, 10 Nov 2023 09:43:45 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=c39ed7a93d564db5ba2de199799b69ee308ad008 https://devapps.diality.us/changelog/dgfirmware?cs=c39ed7a93d564db5ba2de199799b69ee308ad008 Dara Navaei committed c39ed7a on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 48 more in dgfirmware DENBUG-187 changed the code to set the chem disinfect start date at the prime state and changed the other DG modes to check against the chem disinfect start date

· /firmware/App/Modes/ModeChemicalDisinfect.c (-17, +16) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-8, +8) | History | Source | Diff
]]> DG-DENBUG-187-3: started by Dara Navaei Fri, 10 Nov 2023 09:30:53 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-187-3 https://devapps.diality.us/cru/DG-DENBUG-187-3 Dara Navaei started review DG-DENBUG-187-3 ]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Mon, 23 Oct 2023 16:50:34 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=2df80d5b91b421957f3701c3711dc33ffcddbd1c https://devapps.diality.us/changelog/dgfirmware?cs=2df80d5b91b421957f3701c3711dc33ffcddbd1c Dara Navaei committed 2df80d5 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 49 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeChemicalDisinfect.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-1, +1) | History | Source | Diff
]]> DG-DENBUG-124-1: closed by Dara Navaei Mon, 23 Oct 2023 16:50:01 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-124-1 https://devapps.diality.us/cru/DG-DENBUG-124-1 Dara Navaei Closed DG-DENBUG-124-1 ]]> DG-DENBUG-124-1: reviewers finished Mon, 23 Oct 2023 09:16:24 -0700 https://devapps.diality.us/cru/DG-DENBUG-124-1 https://devapps.diality.us/cru/DG-DENBUG-124-1 jtaylor  (deleted user) finished reviewing DG-DENBUG-124-1 DG-DENBUG-124_Chemical Disinfect Flush Cancel Water Path Running Too Fast ]]> DG-DENBUG-124-1: reviewers finished Sun, 22 Oct 2023 15:37:57 -0700 https://devapps.diality.us/cru/DG-DENBUG-124-1 https://devapps.diality.us/cru/DG-DENBUG-124-1 Sean Nash and wbracken  (deleted user) finished reviewing DG-DENBUG-124-1 DG-DENBUG-124_Chemical Disinfect Flush Cancel Water Path Running Too Fast ]]> dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-124 added code to reinitialize the drain parameters chemical disinfect, chemical disinfect flush and flush in can... Sat, 21 Oct 2023 13:06:11 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=be920d1ab62ea8520093c7c0ab44eba31faea429 https://devapps.diality.us/changelog/dgfirmware?cs=be920d1ab62ea8520093c7c0ab44eba31faea429 Dara Navaei committed be920d1 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 50 more in dgfirmware DENBUG-124 added code to reinitialize the drain parameters chemical disinfect, chemical disinfect flush and flush in cancel water path

· /firmware/App/Modes/ModeChemicalDisinfect.c (-5, +8) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c (-4, +6) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-3, +5) | History | Source | Diff
]]> DG-DENBUG-124-1: started by Dara Navaei Sat, 21 Oct 2023 12:39:37 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-124-1 https://devapps.diality.us/cru/DG-DENBUG-124-1 Dara Navaei started review DG-DENBUG-124-1 ]]>