This CR should be closed due to bad branching. Should have been branched out of p1_staging.

· /build.sh	(-1, +1)	| History	| Source	| Diff
· /dialin/common/alarm_defs.py	(-0, +15)	| History	| Source	| Diff
· /dialin/common/msg_defs.py	(-0, +15)	| History	| Source	| Diff
· /dialin/dg/__init__.py	(-1, +1)	| History	| Source	| Diff
· /dialin/dg/conductivity_sensors.py	(-9, +8)	| History	| Source	| Diff
· /dialin/dg/dialysate_generator.py	(-1, +1)	| History	| Source	| Diff
· /dialin/dg/drain_pump.py	(-1, +1)	| History	| Source	| Diff
· /dialin/dg/hd_proxy.py	(-1, +1)	| History	| Source	| Diff
· /dialin/dg/heaters.py	(-2, +2)	| History	| Source	| Diff
· /dialin/dg/load_cells.py	(-1, +1)	| History	| Source	| Diff
· /dialin/dg/pressures.py	(-1, +1)	| History	| Source	| Diff
· /dialin/dg/reservoirs.py	(-1, +1)	| History	| Source	| Diff
· /dialin/dg/ro_pump.py	(-2, +2)	| History	| Source	| Diff
· /dialin/dg/temperature_sensors.py	(-2, +2)	| History	| Source	| Diff
· /dialin/dg/valves.py	(-1, +1)	| History	| Source	| Diff
… 40 more files in changeset.

]]> Wed, 26 Aug 2020 12:02:54 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4344-1 https://devapps.diality.us/cru/DIALIN-DEN-4344-1 plucia  (deleted user) Closed DIALIN-DEN-4344-1 ]]> Wed, 26 Aug 2020 12:01:57 -0700 https://devapps.diality.us/cru/DIALIN-DEN-4344-1 https://devapps.diality.us/cru/DIALIN-DEN-4344-1 Sean Nash and Behrouz NematiPour finished reviewing DIALIN-DEN-4344-1 DIALIN-DEN-4344_Sprint 25 ]]> Wed, 26 Aug 2020 11:52:21 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c4001 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c4001 Behrouz NematiPour replied to plucia  (deleted user) in DIALIN-DEN-4344-1

RESOLVED.

Okay. It's "Projects" now

Reminded him again and he is aware of it and has plan to do so.
We use "Projects" and if meanwhile anyone has a non-updated VM will update the folder name manually for now.

Yes I told him to update that.
Will remind him again.

Great,
RESOLVED

great,
RESOLVED

Have you checked with Dara on this? I think the VM's are setup with the "~/projects" directory. Systems and V&V both have v4 of those VM's already...

I had the same thought awhile ago and begin investigating it. It may be possible - but will take some time. I previously created a Jira ticket to make sure we implement this feature in the future: http://dvm-linux02:8080/browse/DIAL-23.

I had the same thought awhile ago and begin investigating it. It may be possible - but will take some time. I previously created a Jira ticket to make sure we implement this feature in the future: http://dvm-linux02:8080/browse/DIAL-23.

Is there a way to get these values right from c code of firmware?
Like a scripts which reads the c file and generates this py code.

Is there a way to get these values right from c code of firmware?
Like a scripts which reads the c file and generates this py code.

It has been updated in scripts to "Projects"

RESOLVED

It is so during the import process, the modules in the common directory are found. It's used to mark directories as python package directories.
If you remove it, then python will no longer find submodules.

https://docs.python.org/3/reference/import.html#regular-packages

If we add the following to _init.py then the user doesn't have to know the exact file location of a particular class:

So in dialin.init_.py, we could add:
from hd.hemodialysis_device.py import HD

Then, a dialin script could do:

from dialin import HD

instead of

from dialin.hd.hemodialysis_device import HD

It abstracts away the file location so if we can rename files without the API user being affected.

Your comment reminded me that we weren't doing this yet and so I've added those changes to this review.

Why is this empty?

· /dialin/dg/dialysate_generator.py	(-8, +8)	| History	| Source	| Diff
· /dialin/dg/drain_pump.py	(-9, +8)	| History	| Source	| Diff
· /dialin/dg/hd_proxy.py	(-9, +8)	| History	| Source	| Diff
· /dialin/dg/heaters.py	(-9, +8)	| History	| Source	| Diff
· /dialin/dg/load_cells.py	(-9, +8)	| History	| Source	| Diff
· /dialin/dg/pressures.py	(-9, +8)	| History	| Source	| Diff
· /dialin/dg/reservoirs.py	(-9, +8)	| History	| Source	| Diff
· /dialin/dg/ro_pump.py	(-9, +8)	| History	| Source	| Diff
· /dialin/dg/temperature_sensors.py	(-9, +8)	| History	| Source	| Diff
· /dialin/dg/valves.py	(-9, +8)	| History	| Source	| Diff
· /dialin/hd/alarms.py	(-8, +8)	| History	| Source	| Diff
· /dialin/hd/blood_flow.py	(-9, +8)	| History	| Source	| Diff
· /dialin/hd/buttons.py	(-8, +8)	| History	| Source	| Diff
· /dialin/hd/dialysate_inlet_flow.py	(-9, +8)	| History	| Source	| Diff
· /dialin/hd/dialysate_outlet_flow.py	(-9, +8)	| History	| Source	| Diff
… 20 more files in changeset.

]]>