Fisheye on dialin/tools/run_static_code_analysis.sh https://devapps.diality.us/changelog/~br%3DDEN-5328-Sprint-30/dialin/tools/run_static_code_analysis.sh Recent activity in "dialin" under directory /tools/run_static_code_analysis.sh DIALIN-DENBUG-280-4: closed by Michael Garthwaite Wed, 06 Nov 2024 15:20:04 -0800 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DENBUG-280-4 https://devapps.diality.us/cru/DIALIN-DENBUG-280-4 Michael Garthwaite Closed DIALIN-DENBUG-280-4 ]]> DIALIN-DENBUG-280-1: closed by Michael Garthwaite Wed, 06 Nov 2024 15:19:54 -0800 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 Michael Garthwaite Closed DIALIN-DENBUG-280-1 ]]> DIALIN-DENBUG-280-4: reviewers finished Mon, 04 Nov 2024 10:29:29 -0800 https://devapps.diality.us/cru/DIALIN-DENBUG-280-4 https://devapps.diality.us/cru/DIALIN-DENBUG-280-4 Sean Nash finished reviewing DIALIN-DENBUG-280-4 DIALIN-DENBUG-280_Issues With HD Broadcast P1 ]]> DIALIN-DENBUG-280-4: started by Dara Navaei Sat, 02 Nov 2024 16:01:22 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DENBUG-280-4 https://devapps.diality.us/cru/DIALIN-DENBUG-280-4 Dara Navaei started review DIALIN-DENBUG-280-4 ]]> DIALIN-DENBUG-280-1: reviewers joined DIALIN-DENBUG-280_Issues With HD Broadcast P1B Thu, 31 Oct 2024 11:03:43 -0700 https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 Dara Navaei joined DIALIN-DENBUG-280-1 DIALIN-DENBUG-280_Issues With HD Broadcast P1B ]]> DIALIN-DENBUG-280-1: reviewers removed from DIALIN-DENBUG-280_Issues With HD Broadcast P1B Thu, 31 Oct 2024 11:03:43 -0700 https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 Dara Navaei removed Michael Garthwaite from DIALIN-DENBUG-280-1 DIALIN-DENBUG-280_Issues With HD Broadcast P1B ]]> DIALIN-DENBUG-280-1: started by Dara Navaei Thu, 31 Oct 2024 11:02:51 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 https://devapps.diality.us/cru/DIALIN-DENBUG-280-1 Dara Navaei started review DIALIN-DENBUG-280-1 ]]> DIALIN-DIAL-299-1: closed by Michael Garthwaite Mon, 01 Jul 2024 10:16:48 -0700 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DIAL-299-1 https://devapps.diality.us/cru/DIALIN-DIAL-299-1 Michael Garthwaite Closed DIALIN-DIAL-299-1 ]]> DIALIN-DIAL-299-1: comment by Michael Garthwaite "This CR should be closed due to bad branching. ..." Mon, 01 Jul 2024 10:16:33 -0700 Michael Garthwaite https://devapps.diality.us/cru/DIALIN-DIAL-299-1/#c19797 https://devapps.diality.us/cru/DIALIN-DIAL-299-1/#c19797 Michael Garthwaite commented on DIALIN-DIAL-299-1

This CR should be closed due to bad branching. Should have been branched out of p1_staging.

]]> DIALIN-DIAL-299-1: started by Dara Navaei Wed, 26 Jun 2024 12:01:20 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DIAL-299-1 https://devapps.diality.us/cru/DIALIN-DIAL-299-1 Dara Navaei started review DIALIN-DIAL-299-1 ]]> DIALIN-DEN-5328-1: closed by plucia Mon, 16 Nov 2020 10:08:57 -0800 plucia https://devapps.diality.us/cru/DIALIN-DEN-5328-1 https://devapps.diality.us/cru/DIALIN-DEN-5328-1 plucia  (deleted user) Closed DIALIN-DEN-5328-1 ]]> DIALIN-DEN-5328-1: reviewers finished Mon, 16 Nov 2020 08:50:51 -0800 https://devapps.diality.us/cru/DIALIN-DEN-5328-1 https://devapps.diality.us/cru/DIALIN-DEN-5328-1 Sean Nash finished reviewing DIALIN-DEN-5328-1 DIALIN-DEN-5328_Sprint 31 ]]> DIALIN-DEN-5328-1: reviewers finished Wed, 11 Nov 2020 11:26:51 -0800 https://devapps.diality.us/cru/DIALIN-DEN-5328-1 https://devapps.diality.us/cru/DIALIN-DEN-5328-1 qnguyen  (deleted user) finished reviewing DIALIN-DEN-5328-1 DIALIN-DEN-5328_Sprint 31 ]]> DIALIN-DEN-5328-1: comment by qnguyen "RESOLVED." Wed, 11 Nov 2020 11:26:31 -0800 qnguyen https://devapps.diality.us/cru/DIALIN-DEN-5328-1/#c6116 https://devapps.diality.us/cru/DIALIN-DEN-5328-1/#c6116 qnguyen  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-5328-1

RESOLVED.

]]> DIALIN-DEN-5328-1: comment by plucia "RESOLVED" Wed, 11 Nov 2020 11:07:49 -0800 plucia https://devapps.diality.us/cru/DIALIN-DEN-5328-1/#c6112 https://devapps.diality.us/cru/DIALIN-DEN-5328-1/#c6112 plucia  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-5328-1

RESOLVED

]]> DIALIN-DEN-5328-1: comment by plucia "Done" Wed, 11 Nov 2020 11:07:29 -0800 plucia https://devapps.diality.us/cru/DIALIN-DEN-5328-1/#c6111 https://devapps.diality.us/cru/DIALIN-DEN-5328-1/#c6111 plucia  (deleted user) replied to qnguyen  (deleted user) in DIALIN-DEN-5328-1

Done

]]> DIALIN-DEN-5328-1: comment by qnguyen "Add space between functions." Wed, 11 Nov 2020 10:20:47 -0800 qnguyen https://devapps.diality.us/cru/DIALIN-DEN-5328-1/#c6106 https://devapps.diality.us/cru/DIALIN-DEN-5328-1/#c6106 qnguyen  (deleted user) commented on DIALIN-DEN-5328-1

Add space between functions.

]]> DIALIN-DEN-5328-1: comment by plucia "This code review contains all changes up to the..." Tue, 10 Nov 2020 14:27:03 -0800 plucia https://devapps.diality.us/cru/DIALIN-DEN-5328-1/#c6080 https://devapps.diality.us/cru/DIALIN-DEN-5328-1/#c6080 plucia  (deleted user) commented on DIALIN-DEN-5328-1

This code review contains all changes up to the end of sprint 31 not already included in http://dvm-linux02:8060/cru/DIALIN-DEVELOP-BUG-FIXES-1

]]> DIALIN-DEN-5328-1: started by plucia Tue, 10 Nov 2020 14:26:18 -0800 plucia https://devapps.diality.us/cru/DIALIN-DEN-5328-1 https://devapps.diality.us/cru/DIALIN-DEN-5328-1 plucia  (deleted user) started review DIALIN-DEN-5328-1 ]]> dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-5518: Fixed invalid message IDs in hd simulator, refactoring... Mon, 02 Nov 2020 18:07:01 -0800 Peter Lucia <plucia@diality.com> https://devapps.diality.us/changelog/dialin?cs=c32591086c6d9696c63f3d282818280651cca4be https://devapps.diality.us/changelog/dialin?cs=c32591086c6d9696c63f3d282818280651cca4be Peter Lucia <plucia@diality.com> committed c325910 on branch 2020_EOY_DEMO, Calibration_fixes and 264 more in dialin DEN-5518: Fixed invalid message IDs in hd simulator, refactoring

- Fixed missing return in version.py

- Ensure env is activate before running flake8
· /dialin/hd/alarms.py (-7, +6) | History | Source | Diff
· /dialin/ui/hd_simulator.py (-11, +12) | History | Source | Diff
· /dialin/utils/base.py (-4, +5) | History | Source | Diff
· /dialin/version.py (-1, +1) | History | Source | Diff
· /tools/run_static_code_analysis.sh (-1, +2) | History | Source | Diff
]]> dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-5328: Disabled unneeded warnings. Wed, 21 Oct 2020 11:16:23 -0700 Peter Lucia <plucia@diality.com> https://devapps.diality.us/changelog/dialin?cs=3e60c6828d7863221897154cae38e171e2451a3e https://devapps.diality.us/changelog/dialin?cs=3e60c6828d7863221897154cae38e171e2451a3e Peter Lucia <plucia@diality.com> committed 3e60c68 on branch 2020_EOY_DEMO, Calibration_fixes and 264 more in dialin DEN-5328: Disabled unneeded warnings.

· /tools/run_static_code_analysis.sh (-2, +16) | History | Source | Diff
]]> DIALIN-DEN-4856-1: closed by plucia Fri, 16 Oct 2020 14:42:41 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4856-1 https://devapps.diality.us/cru/DIALIN-DEN-4856-1 plucia  (deleted user) Closed DIALIN-DEN-4856-1 ]]> DIALIN-DEN-4856-1: reviewers finished Fri, 16 Oct 2020 14:41:32 -0700 https://devapps.diality.us/cru/DIALIN-DEN-4856-1 https://devapps.diality.us/cru/DIALIN-DEN-4856-1 qnguyen  (deleted user) and Sean Nash finished reviewing DIALIN-DEN-4856-1 DIALIN-DEN-4856_Sprint_27 ]]> DIALIN-DEN-4856-1: comment by qnguyen "RESOLVED." Wed, 14 Oct 2020 17:26:05 -0700 qnguyen https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5538 https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5538 qnguyen  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-4856-1

RESOLVED.

]]> DIALIN-DEN-4856-1: comment by qnguyen "RESOLVED." Wed, 14 Oct 2020 16:22:51 -0700 qnguyen https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5537 https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5537 qnguyen  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-4856-1

RESOLVED.

]]> DIALIN-DEN-4856-1: comment by qnguyen "RESOLVED." Wed, 14 Oct 2020 16:22:33 -0700 qnguyen https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5536 https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5536 qnguyen  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-4856-1

RESOLVED.

]]> DIALIN-DEN-4856-1: comment by plucia "The version of crucible we're using has an issu..." Wed, 14 Oct 2020 15:59:06 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5535 https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5535 plucia  (deleted user) replied to qnguyen  (deleted user) in DIALIN-DEN-4856-1

The version of crucible we're using has an issue where duplicate files show in the file viewer on the left.

If you look at the more recent hemodialysis_device.py file (see the files viewer on the left), this message id is removed: http://dvm-linux02:8060/cru/DIALIN-DEN-4856-1#CFR-19219

It is also removed from both msg_defs.py: http://dvm-linux02:8060/cru/DIALIN-DEN-4856-1#CFR-19027 and http://dvm-linux02:8060/cru/DIALIN-DEN-4856-1#CFR-19203

]]> DIALIN-DEN-4856-1: comment by plucia "Done" Wed, 14 Oct 2020 15:57:59 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5534 https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5534 plucia  (deleted user) replied to qnguyen  (deleted user) in DIALIN-DEN-4856-1

Done

]]> DIALIN-DEN-4856-1: comment by plucia "Yes, if it's already there no reason to remove ..." Wed, 14 Oct 2020 15:57:21 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5533 https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5533 plucia  (deleted user) replied to qnguyen  (deleted user) in DIALIN-DEN-4856-1

Yes, if it's already there no reason to remove it. I've added it back

]]> DIALIN-DEN-4856-1: comment by qnguyen "This message id is not being used." Mon, 12 Oct 2020 09:18:58 -0700 qnguyen https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5430 https://devapps.diality.us/cru/DIALIN-DEN-4856-1/#c5430 qnguyen  (deleted user) commented on DIALIN-DEN-4856-1

This message id is not being used.

]]>