Fisheye on dgfirmware/firmware/App/Modes/ModeHeatDisinfectActiveCool.c

DG-DEN-17047-1: closed by Dara Navaei

Dara Navaei — Sat, 08 Nov 2025 14:06:26 -0800

Dara Navaei Closed DG-DEN-17047-1

DG-DENBUG-298-1: closed by Dara Navaei

Dara Navaei — Thu, 10 Apr 2025 15:09:27 -0700

Dara Navaei Closed DG-DENBUG-298-1

DG-DENBUG-298-1: reviewers finished

Wed, 09 Apr 2025 16:43:33 -0700

Michael Garthwaite and Sean Nash finished reviewing DG-DENBUG-298-1

DG-DENBUG-298_User Unable TO Deliver Saline P1B Staging

DG-DENBUG-298-1: started by Dara Navaei

Dara Navaei — Tue, 08 Apr 2025 14:25:08 -0700

Dara Navaei started review DG-DENBUG-298-1

dgfirmware (DEN-17298-release_22_vc-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 04 Apr 2025 15:46:58 -0700

Dara Navaei committed 8a89e04 on branch DEN-17298-release_22_vc-staging, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

DG-DENBUG-307-1: closed by Dara Navaei

Dara Navaei — Fri, 04 Apr 2025 15:04:50 -0700

Dara Navaei Closed DG-DENBUG-307-1

DG-DENBUG-307-1: reviewers finished

Fri, 04 Apr 2025 11:00:43 -0700

Michael Garthwaite finished reviewing DG-DENBUG-307-1

DG-DENBUG-307_Concentrate Pump Tube Ruptures During Heat Disinfection Staging

DG-DENBUG-307-1: reviewers finished

Wed, 02 Apr 2025 11:14:02 -0700

Sean Nash finished reviewing DG-DENBUG-307-1

DG-DENBUG-307_Concentrate Pump Tube Ruptures During Heat Disinfection Staging

DG-DENBUG-307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Wed, 02 Apr 2025 11:13:55 -0700

Sean Nash replied to Dara Navaei in DG-DENBUG-307-1

RESOLVED in CODE WALKTHROUGH.

DG-DENBUG-307-1: comment by Sean Nash "Not needed, but benign. RESOLVED in CODE WALKT..."

Sean Nash — Wed, 02 Apr 2025 11:13:43 -0700

Sean Nash replied to Dara Navaei in DG-DENBUG-307-1

Not needed, but benign. RESOLVED in CODE WALKTHROUGH.

DG-DENBUG-307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Wed, 02 Apr 2025 11:13:11 -0700

Sean Nash replied to Dara Navaei in DG-DENBUG-307-1

RESOLVED in CODE WALKTHROUGH.

dgfirmware (DENBUG-327-baro-sensor-data-refresh-staging): DENBUG-307 updated the active cool mode to set the actuators prior to transitioning to complete state

Dara Navaei — Wed, 02 Apr 2025 11:03:48 -0700

Dara Navaei committed cb488a4 on branch DEN-17298-release_22_vc-staging, DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging and 5 more in dgfirmware

DENBUG-307 updated the active cool mode to set the actuators prior to transitioning to complete state

· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c

(-1, +2)

| History

| Source

| Diff

DG-DENBUG-307-1: comment by Dara Navaei "Done"

Dara Navaei — Wed, 02 Apr 2025 10:28:52 -0700

Dara Navaei replied to Sean Nash in DG-DENBUG-307-1

Done

DG-DENBUG-307-1: comment by Dara Navaei "Done"

Dara Navaei — Wed, 02 Apr 2025 10:27:50 -0700

Dara Navaei replied to Sean Nash in DG-DENBUG-307-1

Done

DG-DENBUG-307-1: comment by Dara Navaei "I used fabs so all are positive when monitoring..."

Dara Navaei — Wed, 02 Apr 2025 10:26:21 -0700

Dara Navaei replied to Sean Nash in DG-DENBUG-307-1

I used fabs so all are positive when monitoring is started.

dgfirmware (DENBUG-327-baro-sensor-data-refresh-staging): DENBUG-307 updated the active cool to run the concentrate pumps for a few seconds at the end of the mode

Dara Navaei — Tue, 01 Apr 2025 18:16:36 -0700

Dara Navaei committed b410b42 on branch DEN-17298-release_22_vc-staging, DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging and 5 more in dgfirmware

DENBUG-307 updated the active cool to run the concentrate pumps for a few seconds at the end of the mode

· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c

(-23, +50)

| History

| Source

| Diff

DG-DENBUG-307-1: comment by Sean Nash "This check doesn't make sense to me. Measured ..."

Sean Nash — Tue, 01 Apr 2025 09:03:02 -0700

Sean Nash commented on DG-DENBUG-307-1

This check doesn't make sense to me. Measured speed will only be negative if set direction is reverse. So how could directions ever not match?

DG-DENBUG-307-1: comment by Sean Nash "Aren't speeds (commanded and measured) always p..."

Sean Nash — Tue, 01 Apr 2025 09:01:22 -0700

Sean Nash commented on DG-DENBUG-307-1

Aren't speeds (commanded and measured) always positive? Do we need the fabs?

DG-DENBUG-307-1: comment by Sean Nash "Measured speed (whether real or override) shoul..."

Sean Nash — Tue, 01 Apr 2025 08:59:42 -0700

Sean Nash commented on DG-DENBUG-307-1

Measured speed (whether real or override) should always be positive. And if that's true, we shouldn't need this exception.

dgfirmware (DENBUG-327-baro-sensor-data-refresh-staging): DENBUG-307 changed the heat disinfect active cool to run the concentrate pumps during the final reservoir drains

Dara Navaei — Fri, 28 Mar 2025 15:23:39 -0700

Dara Navaei committed e7947c4 on branch DEN-17298-release_22_vc-staging, DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging and 5 more in dgfirmware

DENBUG-307 changed the heat disinfect active cool to run the concentrate pumps during the final reservoir drains

· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c

(-12, +19)

| History

| Source

| Diff

DG-DENBUG-307-1: started by Dara Navaei

Dara Navaei — Fri, 07 Mar 2025 11:32:56 -0800

Dara Navaei started review DG-DENBUG-307-1

DG-DEN-17220-1: closed by Dara Navaei

Dara Navaei — Fri, 07 Feb 2025 16:12:39 -0800

Dara Navaei Closed DG-DEN-17220-1

DG-DEN-17220-1: reviewers finished

Fri, 07 Feb 2025 10:03:27 -0800

jpaguio (deleted user) and Sean Nash finished reviewing DG-DEN-17220-1

DG-DEN-17220_Release 20 P1B Staging

DG-DEN-17220-1: started by Dara Navaei

Dara Navaei — Thu, 06 Feb 2025 14:19:30 -0800

Dara Navaei started review DG-DEN-17220-1

DG-DEN-17135-1: closed by Dara Navaei

Dara Navaei — Fri, 31 Jan 2025 16:57:30 -0800

Dara Navaei Closed DG-DEN-17135-1

DG-DEN-17135-1: reviewers finished

Thu, 30 Jan 2025 10:39:28 -0800

Sean Nash finished reviewing DG-DEN-17135-1

DG-DEN-17135_Concentrate Pump Calibration Staging

dgfirmware (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 29 Jan 2025 18:46:47 -0800

Dara Navaei committed 721bd71 on branch DEN-17213-release_20_vectorcast-staging, DEN-17234-alarm_68_fix_in_expedite_pretreatment and 7 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

… 86 more files in changeset.

DG-DEN-17135-1: reviewers finished

Wed, 29 Jan 2025 17:32:19 -0800

Vinayakam Mani finished reviewing DG-DEN-17135-1

DG-DEN-17135_Concentrate Pump Calibration Staging

DG-DEN-17135-1: comment by Vinayakam Mani "RESOLVED IN CODE WALKTHROUGH"

Vinayakam Mani — Wed, 29 Jan 2025 17:32:01 -0800

Vinayakam Mani replied to Dara Navaei in DG-DEN-17135-1

RESOLVED IN CODE WALKTHROUGH

DG-DEN-17135-1: comment by Dara Navaei "Updated the trigger condition. This is a calibr..."

Dara Navaei — Wed, 29 Jan 2025 17:22:53 -0800

Dara Navaei replied to Vinayakam Mani in DG-DEN-17135-1

Updated the trigger condition. This is a calibration and is checked in POST. The titles are POST.