Align the comments.

Its static function and not used by external API to pass the wrong id.

0.0F is made by Sean.

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. else, just a PI control signal would work. (something similar to Feed forward enabled flag)

nope. removed.

fixed

fixed

fixed

fixed

Same comment applies here (removing resetPIController).

I think we can remove the balancing chamber fill in progress check for Opening D80 valve, as this does not impact the balancing chamber fill process.

Maintain space after and before parenthesis across the file.

Do we need to add another else statement and address an alarm if wrong mixId is passed? or Keep only else part instead of else if ( ACID_MIX_ID == mixID) check?? this change may be needed across the file.

Remove this comment.

You may use getF32OverrideValue for consistency (across the file).

The resetPIController is already invoked in InitializePIController with the InitialControlSignal. Instead of 0.0F, pass the STD_BICARB_DOSING as initialControlSignal ( in InitializePIController)

This is being repeated.

Please add comment. if it is not being used, delete it.

Can this be reused from ConcentratePumps.h?