Fisheye on ro-firmware/firmware/App/FPCommon.h https://devapps.diality.us/changelog/~br%3DLDT-1773-iofp-valve-pwm/ro-firmware/firmware/App/FPCommon.h Recent activity in "ro-firmware" under directory /firmware/App/FPCommon.h ro-firmware (staging): Bamboo Commit: Updated FPCommon.h with build versions from Bamboo. Thu, 04 Sep 2025 13:32:24 -0700 Dara Navaei https://devapps.diality.us/changelog/ro-firmware?cs=98a0d33898570c0422563219d9fa9236bc8d4bae https://devapps.diality.us/changelog/ro-firmware?cs=98a0d33898570c0422563219d9fa9236bc8d4bae Dara Navaei committed 98a0d33 on branch LDT-1773-iofp-valve-pwm, LDT-2116-iofp-evaluate-closing-p39, staging in ro-firmware Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

· /firmware/App/FPCommon.h (-1, +1) | History | Source | Diff
]]> ro-firmware (LDT-1773-iofp-valve-pwm): Bamboo Commit: Updated FPCommon.h with build versions from Bamboo. Thu, 04 Sep 2025 09:06:43 -0700 Dara Navaei https://devapps.diality.us/changelog/ro-firmware?cs=f3ce9092a4c6468f096a8c8bb74764b40f070708 https://devapps.diality.us/changelog/ro-firmware?cs=f3ce9092a4c6468f096a8c8bb74764b40f070708 Dara Navaei committed f3ce909 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

· /firmware/App/FPCommon.h (-1, +1) | History | Source | Diff
]]> ro-firmware (LDT-1773-iofp-valve-pwm): Bamboo Commit: Updated FPCommon.h with build versions from Bamboo. Wed, 03 Sep 2025 14:48:41 -0700 Dara Navaei https://devapps.diality.us/changelog/ro-firmware?cs=dab045421ffa11b689659f69345e31776ad5c19e https://devapps.diality.us/changelog/ro-firmware?cs=dab045421ffa11b689659f69345e31776ad5c19e Dara Navaei committed dab0454 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

· /firmware/App/FPCommon.h (-1, +1) | History | Source | Diff
]]> LEAHI-RO-FIRMWARE-LDT-828-1: closed by Michael Garthwaite Wed, 03 Sep 2025 08:52:54 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 Michael Garthwaite Closed LEAHI-RO-FIRMWARE-LDT-828-1 ]]> LEAHI-RO-FIRMWARE-LDT-1242-1: closed by Michael Garthwaite Wed, 03 Sep 2025 08:52:47 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 Michael Garthwaite Closed LEAHI-RO-FIRMWARE-LDT-1242-1 ]]> ro-firmware (LDT-1735-test-config-support-for-dd): Bamboo Commit: Updated FPCommon.h with build versions from Bamboo. Tue, 02 Sep 2025 11:10:24 -0700 Dara Navaei https://devapps.diality.us/changelog/ro-firmware?cs=83a68611b4a06c1681b29f3796fb57073e18a3d5 https://devapps.diality.us/changelog/ro-firmware?cs=83a68611b4a06c1681b29f3796fb57073e18a3d5 Dara Navaei committed 83a6861 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 4 more in ro-firmware Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

· /firmware/App/FPCommon.h (-1, +1) | History | Source | Diff
]]> LEAHI-RO-FIRMWARE-LDT-828-1: started by Dara Navaei Tue, 02 Sep 2025 10:03:23 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 Dara Navaei started review LEAHI-RO-FIRMWARE-LDT-828-1 ]]> LEAHI-RO-FIRMWARE-LDT-1242-1: started by Dara Navaei Tue, 02 Sep 2025 10:03:14 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 Dara Navaei started review LEAHI-RO-FIRMWARE-LDT-1242-1 ]]> ro-firmware (LDT-1735-test-config-support-for-dd): Bamboo Commit: Updated FPCommon.h with build versions from Bamboo. Fri, 22 Aug 2025 15:21:24 -0700 Dara Navaei https://devapps.diality.us/changelog/ro-firmware?cs=77f9dd6386a34f1abb8abb7a49870ef16f178e99 https://devapps.diality.us/changelog/ro-firmware?cs=77f9dd6386a34f1abb8abb7a49870ef16f178e99 Dara Navaei committed 77f9dd6 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 5 more in ro-firmware Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

· /firmware/App/FPCommon.h (-1, +1) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): Bamboo Commit: Updated FPCommon.h with build versions from Bamboo. Wed, 06 Aug 2025 08:24:10 -0700 Dara Navaei https://devapps.diality.us/changelog/ro-firmware?cs=c76b4f0f821e44144b1a169684b46c596bb9173a https://devapps.diality.us/changelog/ro-firmware?cs=c76b4f0f821e44144b1a169684b46c596bb9173a Dara Navaei committed c76b4f0 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 7 more in ro-firmware Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

· /firmware/App/FPCommon.h (-1, +1) | History | Source | Diff
]]> RO-LDT-566-2: closed by Michael Garthwaite Wed, 06 Aug 2025 08:18:39 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-566-2 https://devapps.diality.us/cru/RO-LDT-566-2 Michael Garthwaite Closed RO-LDT-566-2 ]]> RO-LDT-566-2: reviewers finished Tue, 05 Aug 2025 17:13:28 -0700 https://devapps.diality.us/cru/RO-LDT-566-2 https://devapps.diality.us/cru/RO-LDT-566-2 Sean Nash and Vinayakam Mani finished reviewing RO-LDT-566-2 RO-LDT-566_Water Treatment And Degassing FP 2 ]]> RO-LDT-566-2: reviewers added to RO-LDT-566_Water Treatment And Degassing FP 2 Tue, 05 Aug 2025 09:28:45 -0700 https://devapps.diality.us/cru/RO-LDT-566-2 https://devapps.diality.us/cru/RO-LDT-566-2 Michael Garthwaite added Raghu Kallala to RO-LDT-566-2 RO-LDT-566_Water Treatment And Degassing FP 2 ]]> RO-LDT-566-2: comment by Michael Garthwaite "Added TODO. It'll be implemented in the next br..." Mon, 04 Aug 2025 09:25:48 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-566-2/#c23482 https://devapps.diality.us/cru/RO-LDT-566-2/#c23482 Michael Garthwaite replied to Sean Nash in RO-LDT-566-2

Added TODO. It'll be implemented in the next branch regarding stop/pauses states and alarm requirements.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:35:46 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23445 https://devapps.diality.us/cru/RO-LDT-566-2/#c23445 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "I think FP and DD need to handle alarm trigger,..." Fri, 01 Aug 2025 15:35:04 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23444 https://devapps.diality.us/cru/RO-LDT-566-2/#c23444 Sean Nash commented on RO-LDT-566-2

I think FP and DD need to handle alarm trigger, clear, and clear condition messages (msg ID 2,3,4) from other s/w stacks.

]]> RO-LDT-566-2: comment by Sean Nash "I would put normal messages above Dialin messag..." Fri, 01 Aug 2025 15:34:21 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23442 https://devapps.diality.us/cru/RO-LDT-566-2/#c23442 Sean Nash commented on RO-LDT-566-2

I would put normal messages above Dialin messages in this list - basically ordering this list in msg enum order.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:29:59 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23434 https://devapps.diality.us/cru/RO-LDT-566-2/#c23434 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:28:16 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23430 https://devapps.diality.us/cru/RO-LDT-566-2/#c23430 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:27:53 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23429 https://devapps.diality.us/cru/RO-LDT-566-2/#c23429 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:27:42 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23428 https://devapps.diality.us/cru/RO-LDT-566-2/#c23428 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:27:36 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23427 https://devapps.diality.us/cru/RO-LDT-566-2/#c23427 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:27:29 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23426 https://devapps.diality.us/cru/RO-LDT-566-2/#c23426 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:27:21 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23425 https://devapps.diality.us/cru/RO-LDT-566-2/#c23425 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:27:16 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23424 https://devapps.diality.us/cru/RO-LDT-566-2/#c23424 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Fix this." Fri, 01 Aug 2025 15:26:03 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23421 https://devapps.diality.us/cru/RO-LDT-566-2/#c23421 Sean Nash commented on RO-LDT-566-2

Fix this.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:25:13 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23420 https://devapps.diality.us/cru/RO-LDT-566-2/#c23420 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:24:05 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23419 https://devapps.diality.us/cru/RO-LDT-566-2/#c23419 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:21:00 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23417 https://devapps.diality.us/cru/RO-LDT-566-2/#c23417 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:19:50 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23416 https://devapps.diality.us/cru/RO-LDT-566-2/#c23416 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]>