Fisheye on ro-firmware/firmware/App/Services/FpgaFP.h https://devapps.diality.us/changelog/~br%3DLDT-1773-iofp-valve-pwm/ro-firmware/firmware/App/Services/FpgaFP.h Recent activity in "ro-firmware" under directory /firmware/App/Services/FpgaFP.h LEAHI-RO-FIRMWARE-LDT-1773-1: closed by Michael Garthwaite Thu, 18 Dec 2025 10:14:20 -0800 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1773-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1773-1 Michael Garthwaite Closed LEAHI-RO-FIRMWARE-LDT-1773-1 ]]> LEAHI-RO-FIRMWARE-LDT-1773-1: reviewers finished Tue, 04 Nov 2025 09:48:44 -0800 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1773-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1773-1 Sean Nash finished reviewing LEAHI-RO-FIRMWARE-LDT-1773-1 LEAHI-RO-FIRMWARE-LDT-1773_IOFP- Power Budget and if we need to employ the strike and hold ]]> LEAHI-RO-FIRMWARE-LDT-1773-1: comment by Michael Garthwaite "fixed. thanks!" Mon, 03 Nov 2025 09:13:42 -0800 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1773-1/#c24958 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1773-1/#c24958 Michael Garthwaite replied to Sean Nash in LEAHI-RO-FIRMWARE-LDT-1773-1

fixed. thanks!

]]> LEAHI-RO-FIRMWARE-LDT-1773-1: comment by Sean Nash "I think this should be initialized to zero in c..." Thu, 16 Oct 2025 09:49:39 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1773-1/#c24672 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1773-1/#c24672 Sean Nash commented on LEAHI-RO-FIRMWARE-LDT-1773-1

I think this should be initialized to zero in case some bits are unused.

]]> ro-firmware (staging): LDT-1773: updated comments for fpga interface. changed valve pwm period to correct value Mon, 29 Sep 2025 14:14:55 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=0362e435bb028b4d9154105e8f386306a89432d5 https://devapps.diality.us/changelog/ro-firmware?cs=0362e435bb028b4d9154105e8f386306a89432d5 Michael Garthwaite committed 0362e43 on branch LDT-1773-iofp-valve-pwm, LDT-2116-iofp-evaluate-closing-p39, staging in ro-firmware LDT-1773: updated comments for fpga interface. changed valve pwm period to correct value

· /firmware/App/Controllers/Valves.c (-5, +5) | History | Source | Diff
· /firmware/App/Services/FpgaFP.c (-5, +43) | History | Source | Diff
· /firmware/App/Services/FpgaFP.h (-1, +1) | History | Source | Diff
]]> LEAHI-RO-FIRMWARE-LDT-1773-1: started by Dara Navaei Fri, 19 Sep 2025 10:00:57 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1773-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1773-1 Dara Navaei started review LEAHI-RO-FIRMWARE-LDT-1773-1 ]]> ro-firmware (staging): LDT-1773: implemented FPGA interface for valve PWM. implemented in valves module Fri, 19 Sep 2025 08:58:03 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=cf82e0c4128078cce50bd6c7969ea7192ab5be94 https://devapps.diality.us/changelog/ro-firmware?cs=cf82e0c4128078cce50bd6c7969ea7192ab5be94 Michael Garthwaite committed cf82e0c on branch LDT-1773-iofp-valve-pwm, LDT-2116-iofp-evaluate-closing-p39, staging in ro-firmware LDT-1773: implemented FPGA interface for valve PWM. implemented in valves module

· /firmware/App/Controllers/Valves.c (-0, +12) | History | Source | Diff
· /firmware/App/Services/FpgaFP.c (-0, +33) | History | Source | Diff
· /firmware/App/Services/FpgaFP.h (-0, +5) | History | Source | Diff
]]> LEAHI-RO-FIRMWARE-LDT-828-1: closed by Michael Garthwaite Wed, 03 Sep 2025 08:52:54 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 Michael Garthwaite Closed LEAHI-RO-FIRMWARE-LDT-828-1 ]]> LEAHI-RO-FIRMWARE-LDT-1242-1: closed by Michael Garthwaite Wed, 03 Sep 2025 08:52:47 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 Michael Garthwaite Closed LEAHI-RO-FIRMWARE-LDT-1242-1 ]]> LEAHI-RO-FIRMWARE-LDT-828-1: started by Dara Navaei Tue, 02 Sep 2025 10:03:23 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 Dara Navaei started review LEAHI-RO-FIRMWARE-LDT-828-1 ]]> LEAHI-RO-FIRMWARE-LDT-1242-1: started by Dara Navaei Tue, 02 Sep 2025 10:03:14 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 Dara Navaei started review LEAHI-RO-FIRMWARE-LDT-1242-1 ]]> RO-LDT-566-2: closed by Michael Garthwaite Wed, 06 Aug 2025 08:18:39 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-566-2 https://devapps.diality.us/cru/RO-LDT-566-2 Michael Garthwaite Closed RO-LDT-566-2 ]]> RO-LDT-566-2: reviewers finished Tue, 05 Aug 2025 17:13:28 -0700 https://devapps.diality.us/cru/RO-LDT-566-2 https://devapps.diality.us/cru/RO-LDT-566-2 Sean Nash and Vinayakam Mani finished reviewing RO-LDT-566-2 RO-LDT-566_Water Treatment And Degassing FP 2 ]]> RO-LDT-566-2: reviewers added to RO-LDT-566_Water Treatment And Degassing FP 2 Tue, 05 Aug 2025 09:28:45 -0700 https://devapps.diality.us/cru/RO-LDT-566-2 https://devapps.diality.us/cru/RO-LDT-566-2 Michael Garthwaite added Raghu Kallala to RO-LDT-566-2 RO-LDT-566_Water Treatment And Degassing FP 2 ]]> RO-LDT-566-2: comment by Michael Garthwaite "Added TODO. It'll be implemented in the next br..." Mon, 04 Aug 2025 09:25:48 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-566-2/#c23482 https://devapps.diality.us/cru/RO-LDT-566-2/#c23482 Michael Garthwaite replied to Sean Nash in RO-LDT-566-2

Added TODO. It'll be implemented in the next branch regarding stop/pauses states and alarm requirements.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:35:46 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23445 https://devapps.diality.us/cru/RO-LDT-566-2/#c23445 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "I think FP and DD need to handle alarm trigger,..." Fri, 01 Aug 2025 15:35:04 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23444 https://devapps.diality.us/cru/RO-LDT-566-2/#c23444 Sean Nash commented on RO-LDT-566-2

I think FP and DD need to handle alarm trigger, clear, and clear condition messages (msg ID 2,3,4) from other s/w stacks.

]]> RO-LDT-566-2: comment by Sean Nash "I would put normal messages above Dialin messag..." Fri, 01 Aug 2025 15:34:21 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23442 https://devapps.diality.us/cru/RO-LDT-566-2/#c23442 Sean Nash commented on RO-LDT-566-2

I would put normal messages above Dialin messages in this list - basically ordering this list in msg enum order.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:29:59 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23434 https://devapps.diality.us/cru/RO-LDT-566-2/#c23434 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:28:16 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23430 https://devapps.diality.us/cru/RO-LDT-566-2/#c23430 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:27:53 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23429 https://devapps.diality.us/cru/RO-LDT-566-2/#c23429 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:27:42 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23428 https://devapps.diality.us/cru/RO-LDT-566-2/#c23428 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:27:36 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23427 https://devapps.diality.us/cru/RO-LDT-566-2/#c23427 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:27:29 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23426 https://devapps.diality.us/cru/RO-LDT-566-2/#c23426 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:27:21 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23425 https://devapps.diality.us/cru/RO-LDT-566-2/#c23425 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:27:16 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23424 https://devapps.diality.us/cru/RO-LDT-566-2/#c23424 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Fix this." Fri, 01 Aug 2025 15:26:03 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23421 https://devapps.diality.us/cru/RO-LDT-566-2/#c23421 Sean Nash commented on RO-LDT-566-2

Fix this.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:25:13 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23420 https://devapps.diality.us/cru/RO-LDT-566-2/#c23420 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:24:05 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23419 https://devapps.diality.us/cru/RO-LDT-566-2/#c23419 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:21:00 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23417 https://devapps.diality.us/cru/RO-LDT-566-2/#c23417 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]>