Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pretty fast with no BC switching in that case.

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_)
And then, we don't need a TODO. These #defines are only possible in DEBUG builds. A RELEASE build will never allow thing build flags to disable things.

Remove start state.

Updated

updated

Yes, removed

Removed

yes, removed

Changed

Removed

Removed

Removed

Added

Added

Updated

Updated

Added

Updated

Updated

Same comment as duration confirmation. compare uf rate too.

Also check uf rate from confirmation message (request) is still the same as validated uf rate.
WARNING - uf rate will be a float and we shouldn't use == operator on floats.

I think validated variable here should be L/Hr and assigned to response.ufRate so that when we get confirmation, we can compare rates with same units.

I think validated variable here should be L/Hr and assigned to response.ufRate so that when we get confirmation, we can compare rates with same units.

Treatment mode will also need one of these (later). Should we add PreTx to the function name to differentiate?

I don't see you changing the GoalL. Recommend you use local presUFVolumeMl instead.