The FP signals are not included in the DD-pre gen/Gen dialysate transition functions. They have handled separately in the TD Interface.

You are right, modified in all places

FALSE?

FALSE?

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always happen regardless of how we got to pre-gen mode.

Add comment that these modes not (yet?) supported.

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we implemented in TD interface).

Done.

Done.

Done.

Done.

Done

Same as Gen Dialysate - this should be else if and switch statement should be in a final else.

stop should be capitalized.

Remove extra blank line.

I think these two conditions above the switch statement should end the state processing.
So the second condition should be an else if and combined i.e. if ( ( genDialysateState != DD_GEND_DIALYSATE_DELIVERY_PAUSE ) && ( TRUE == areInletWaterConditionsAlarmsActive() ) ).
And then another else where the switch statement should go.
Hydraulic chamber and updating treatment settings should maybe be moved above all of this so they always happen.

Done.

Want Gen Dialysate mode state machine to handle the mode change - so request function should set a flag that the state machine will act on in next pass.

Want Pre Gen mode state machine to handle the mode change - so request function should set a flag that the state machine will act on in next pass.

Signal Pre Gen mode and let it request standby mode.

Should signal Gen Dialysate mode and let it request transition to standby.