Fisheye on ro-firmware/firmware/App/Drivers/SafetyShutdown.c https://devapps.diality.us/changelog/~br%3DLDT-2116-iofp-evaluate-closing-p39/ro-firmware/firmware/App/Drivers/SafetyShutdown.c Recent activity in "ro-firmware" under directory /firmware/App/Drivers/SafetyShutdown.c ro-firmware (staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Thu, 18 Dec 2025 10:27:26 -0800 Dara Navaei https://devapps.diality.us/changelog/ro-firmware?cs=ca95dc70d5ef02c5c40b67d095e9a4d56783d967 https://devapps.diality.us/changelog/ro-firmware?cs=ca95dc70d5ef02c5c40b67d095e9a4d56783d967 Dara Navaei committed ca95dc7 on branch LDT-2116-iofp-evaluate-closing-p39, staging in ro-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BoostPump.c (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/BoostPump.h (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/PermeateTank.c (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/PermeateTank.h (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-4, +4) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-4, +4) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-3, +3) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensor.c (-6, +6) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensor.h (-6, +6) | History | Source | Diff
· /firmware/App/Drivers/FlowSensor.c (-3, +3) | History | Source | Diff
· /firmware/App/Drivers/FlowSensor.h (-3, +3) | History | Source | Diff
· /firmware/App/Drivers/FluidPump.c (-5, +5) | History | Source | Diff
· /firmware/App/Drivers/FluidPump.h (-5, +5) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.c (-0, +16) | History | Source | Diff
… 67 more files in changeset.
]]> LEAHI-RO-FIRMWARE-LDT-828-1: closed by Michael Garthwaite Wed, 03 Sep 2025 08:52:54 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 Michael Garthwaite Closed LEAHI-RO-FIRMWARE-LDT-828-1 ]]> LEAHI-RO-FIRMWARE-LDT-1242-1: closed by Michael Garthwaite Wed, 03 Sep 2025 08:52:47 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 Michael Garthwaite Closed LEAHI-RO-FIRMWARE-LDT-1242-1 ]]> LEAHI-RO-FIRMWARE-LDT-828-1: started by Dara Navaei Tue, 02 Sep 2025 10:03:23 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-828-1 Dara Navaei started review LEAHI-RO-FIRMWARE-LDT-828-1 ]]> LEAHI-RO-FIRMWARE-LDT-1242-1: started by Dara Navaei Tue, 02 Sep 2025 10:03:14 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 Dara Navaei started review LEAHI-RO-FIRMWARE-LDT-1242-1 ]]> RO-LDT-566-2: closed by Michael Garthwaite Wed, 06 Aug 2025 08:18:39 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-566-2 https://devapps.diality.us/cru/RO-LDT-566-2 Michael Garthwaite Closed RO-LDT-566-2 ]]> RO-LDT-566-2: reviewers finished Tue, 05 Aug 2025 17:13:28 -0700 https://devapps.diality.us/cru/RO-LDT-566-2 https://devapps.diality.us/cru/RO-LDT-566-2 Sean Nash and Vinayakam Mani finished reviewing RO-LDT-566-2 RO-LDT-566_Water Treatment And Degassing FP 2 ]]> RO-LDT-566-2: reviewers added to RO-LDT-566_Water Treatment And Degassing FP 2 Tue, 05 Aug 2025 09:28:45 -0700 https://devapps.diality.us/cru/RO-LDT-566-2 https://devapps.diality.us/cru/RO-LDT-566-2 Michael Garthwaite added Raghu Kallala to RO-LDT-566-2 RO-LDT-566_Water Treatment And Degassing FP 2 ]]> RO-LDT-566-2: comment by Michael Garthwaite "Added TODO. It'll be implemented in the next br..." Mon, 04 Aug 2025 09:25:48 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-566-2/#c23482 https://devapps.diality.us/cru/RO-LDT-566-2/#c23482 Michael Garthwaite replied to Sean Nash in RO-LDT-566-2

Added TODO. It'll be implemented in the next branch regarding stop/pauses states and alarm requirements.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:35:46 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23445 https://devapps.diality.us/cru/RO-LDT-566-2/#c23445 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "I think FP and DD need to handle alarm trigger,..." Fri, 01 Aug 2025 15:35:04 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23444 https://devapps.diality.us/cru/RO-LDT-566-2/#c23444 Sean Nash commented on RO-LDT-566-2

I think FP and DD need to handle alarm trigger, clear, and clear condition messages (msg ID 2,3,4) from other s/w stacks.

]]> RO-LDT-566-2: comment by Sean Nash "I would put normal messages above Dialin messag..." Fri, 01 Aug 2025 15:34:21 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23442 https://devapps.diality.us/cru/RO-LDT-566-2/#c23442 Sean Nash commented on RO-LDT-566-2

I would put normal messages above Dialin messages in this list - basically ordering this list in msg enum order.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:29:59 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23434 https://devapps.diality.us/cru/RO-LDT-566-2/#c23434 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:28:16 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23430 https://devapps.diality.us/cru/RO-LDT-566-2/#c23430 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:27:53 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23429 https://devapps.diality.us/cru/RO-LDT-566-2/#c23429 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:27:42 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23428 https://devapps.diality.us/cru/RO-LDT-566-2/#c23428 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:27:36 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23427 https://devapps.diality.us/cru/RO-LDT-566-2/#c23427 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:27:29 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23426 https://devapps.diality.us/cru/RO-LDT-566-2/#c23426 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:27:21 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23425 https://devapps.diality.us/cru/RO-LDT-566-2/#c23425 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:27:16 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23424 https://devapps.diality.us/cru/RO-LDT-566-2/#c23424 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Fix this." Fri, 01 Aug 2025 15:26:03 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23421 https://devapps.diality.us/cru/RO-LDT-566-2/#c23421 Sean Nash commented on RO-LDT-566-2

Fix this.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:25:13 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23420 https://devapps.diality.us/cru/RO-LDT-566-2/#c23420 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:24:05 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23419 https://devapps.diality.us/cru/RO-LDT-566-2/#c23419 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:21:00 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23417 https://devapps.diality.us/cru/RO-LDT-566-2/#c23417 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:19:50 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23416 https://devapps.diality.us/cru/RO-LDT-566-2/#c23416 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Remove blank line." Fri, 01 Aug 2025 15:16:10 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23415 https://devapps.diality.us/cru/RO-LDT-566-2/#c23415 Sean Nash commented on RO-LDT-566-2

Remove blank line.

]]> RO-LDT-566-2: comment by Sean Nash "Add blank line between functions." Fri, 01 Aug 2025 15:15:15 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23414 https://devapps.diality.us/cru/RO-LDT-566-2/#c23414 Sean Nash commented on RO-LDT-566-2

Add blank line between functions.

]]> RO-LDT-566-2: comment by Sean Nash "Update inputs/outputs" Fri, 01 Aug 2025 15:14:37 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23413 https://devapps.diality.us/cru/RO-LDT-566-2/#c23413 Sean Nash commented on RO-LDT-566-2

Update inputs/outputs

]]> RO-LDT-566-2: comment by Sean Nash "Update inputs/outputs" Fri, 01 Aug 2025 15:14:21 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23412 https://devapps.diality.us/cru/RO-LDT-566-2/#c23412 Sean Nash commented on RO-LDT-566-2

Update inputs/outputs

]]> RO-LDT-566-2: comment by Sean Nash "Check inputs/outputs" Fri, 01 Aug 2025 15:14:00 -0700 Sean Nash https://devapps.diality.us/cru/RO-LDT-566-2/#c23411 https://devapps.diality.us/cru/RO-LDT-566-2/#c23411 Sean Nash commented on RO-LDT-566-2

Check inputs/outputs

]]>