Fisheye on leahi-fwcommon/TestSupport.h https://devapps.diality.us/changelog/~br%3DLDT-2118-main-treatment-screen---td---vectorcast-tests-7-31-2026/leahi-fwcommon/TestSupport.h Recent activity in "leahi-fwcommon" under directory /TestSupport.h LEAHI-DD-FIRMWARE-LDT-5209-1: comment by Vinayakam Mani "Add the header description." Thu, 30 Jul 2026 12:08:16 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30898 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30898 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-5209-1

Add the header description.

]]> LEAHI-DD-FIRMWARE-LDT-5209-1: comment by Vinayakam Mani "Do we need to transition to next state DD_PREGE..." Thu, 30 Jul 2026 12:03:39 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30897 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30897 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-5209-1

Do we need to transition to next state DD_PREGEN_DRY_BICART_INITIAL_FILL here?

]]> LEAHI-DD-FIRMWARE-LDT-5209-1: comment by Vinayakam Mani "Remove empty lines." Thu, 30 Jul 2026 11:57:16 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30896 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30896 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-5209-1

Remove empty lines.

]]> LEAHI-DD-FIRMWARE-LDT-5209-1: comment by Vinayakam Mani "Add comments across the file." Thu, 30 Jul 2026 11:49:53 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30895 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30895 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-5209-1

Add comments across the file.

]]> LEAHI-DD-FIRMWARE-LDT-5209-1: comment by Vinayakam Mani "Add comment." Thu, 30 Jul 2026 11:42:11 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30894 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30894 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-5209-1

Add comment.

]]> LEAHI-DD-FIRMWARE-LDT-5209-1: comment by Vinayakam Mani "Add a test support for Pregen fill request." Thu, 30 Jul 2026 11:41:44 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30893 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30893 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-5209-1

Add a test support for Pregen fill request.

]]> LEAHI-DD-FIRMWARE-LDT-5209-1: comment by Vinayakam Mani "Update header description for all newly added f..." Thu, 30 Jul 2026 11:27:21 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30892 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30892 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-5209-1

Update header description for all newly added functions.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: closed by Vendor - TEL - Arpita Srivastava Thu, 30 Jul 2026 11:23:44 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1 Vendor - TEL - Arpita Srivastava Closed LEAHI-DD-FIRMWARE-LDT-3735-1 ]]> LEAHI-DD-FIRMWARE-LDT-5209-1: comment by Vinayakam Mani "You may need to check other flags such as DryBi..." Thu, 30 Jul 2026 10:54:00 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30883 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30883 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-5209-1

You may need to check other flags such as DryBicartFillRequested( Initial Fill), bicarbChamberFillRequested (Filling Chamber F), instead of 'bicarbChamberPregenFillRequested'. Keep Drain and DepressurizeRequest flag as is. This makes sure at any given point, dryBicartExec calls one of the service only.

]]> LEAHI-DD-FIRMWARE-LDT-5209-1: comment by Vinayakam Mani "Same here adding 'bicarbChamberPregenFillReques..." Thu, 30 Jul 2026 11:02:11 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30887 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30887 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-5209-1

Same here adding 'bicarbChamberPregenFillRequested' flag.

]]> LEAHI-DD-FIRMWARE-LDT-5209-1: comment by Vinayakam Mani "Same here adding 'bicarbChamberPregenFillReques..." Thu, 30 Jul 2026 11:02:02 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30886 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30886 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-5209-1

Same here adding 'bicarbChamberPregenFillRequested' flag.

]]> LEAHI-DD-FIRMWARE-LDT-5209-1: comment by Vinayakam Mani "Same here adding 'bicarbChamberPregenFillReques..." Thu, 30 Jul 2026 11:00:10 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30885 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30885 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-5209-1

Same here adding 'bicarbChamberPregenFillRequested' flag.

]]> LEAHI-DD-FIRMWARE-LDT-5209-1: comment by Vinayakam Mani "Retain the previous( dryBicartFillRequested) an..." Thu, 30 Jul 2026 10:58:40 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30884 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30884 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-5209-1

Retain the previous( dryBicartFillRequested) and add 'bicarbChamberPregenFillRequested' flag here.

]]> LEAHI-DD-FIRMWARE-LDT-5209-1: comment by Vinayakam Mani "PregenFillExecState? may be creating a new faul..." Thu, 30 Jul 2026 10:52:30 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30882 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30882 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-5209-1

PregenFillExecState? may be creating a new fault ID for pregen fill.

]]> LEAHI-DD-FIRMWARE-LDT-5209-1: comment by Vinayakam Mani "Update description as required." Thu, 30 Jul 2026 10:51:50 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30881 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30881 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-5209-1

Update description as required.

]]> LEAHI-DD-FIRMWARE-LDT-5209-1: comment by Vinayakam Mani "Add comment." Thu, 30 Jul 2026 10:51:09 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30880 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30880 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-5209-1

Add comment.

]]> LEAHI-DD-FIRMWARE-LDT-5209-1: comment by Vinayakam Mani "Add comment." Thu, 30 Jul 2026 10:50:43 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30879 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30879 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-5209-1

Add comment.

]]> LEAHI-DD-FIRMWARE-LDT-5209-1: comment by Vinayakam Mani "Add comment." Thu, 30 Jul 2026 10:50:30 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30878 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5209-1/#c30878 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-5209-1

Add comment.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: reviewers finished Thu, 30 Jul 2026 10:23:26 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3735-1 LEAHI-DD-FIRMWARE-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation ]]> LEAHI-DD-FIRMWARE-LDT-5102-2: started by Dara Navaei Wed, 29 Jul 2026 19:04:21 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5102-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5102-2 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-5102-2 ]]> LEAHI-DD-FIRMWARE-LDT-3735-1: reviewers finished Wed, 29 Jul 2026 17:37:37 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1 Dara Navaei finished reviewing LEAHI-DD-FIRMWARE-LDT-3735-1 LEAHI-DD-FIRMWARE-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation ]]> leahi-fwcommon (LDT-2118-main-treatment-screen---td---vectorcast-tests-7-31-2026): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Wed, 29 Jul 2026 11:06:22 -0700 Dara Navaei https://devapps.diality.us/changelog/leahi-fwcommon?cs=0b8f91f84aebe54470508381ec6381088901eeba https://devapps.diality.us/changelog/leahi-fwcommon?cs=0b8f91f84aebe54470508381ec6381088901eeba Dara Navaei committed 0b8f91f on branch LDT-2118-main-treatment-screen---td---vectorcast-tests-7-31-2026, LDT-3735-non-volatile-memory and 7 more in leahi-fwcommon Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /NVDriver.c (-2, +5) | History | Source | Diff
· /NVDriver.h (-2, +5) | History | Source | Diff
· /NVJobQ.c (-2, +5) | History | Source | Diff
· /NVJobQ.h (-2, +5) | History | Source | Diff
· /NVMgmt.c (-2, +5) | History | Source | Diff
· /NVMgmt.h (-2, +5) | History | Source | Diff
· /TestSupport.h (-2, +2) | History | Source | Diff
· /WatchdogMgmt.c (-2, +2) | History | Source | Diff
]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Vendor - TEL - Arpita Srivastava "Added but crucible is not showing this change. ..." Mon, 27 Jul 2026 11:21:48 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30743 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30743 Vendor - TEL - Arpita Srivastava replied to Dara Navaei in LEAHI-DD-FIRMWARE-LDT-3735-1

Added but crucible is not showing this change. Please check bitbucket.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Vendor - TEL - Arpita Srivastava "These variables are correctly initialized to th..." Mon, 27 Jul 2026 11:17:24 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30742 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30742 Vendor - TEL - Arpita Srivastava replied to Dara Navaei in LEAHI-DD-FIRMWARE-LDT-3735-1

These variables are correctly initialized to the first enum in the list.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Vendor - TEL - Arpita Srivastava "Not needed because the retry mechanism is going..." Mon, 27 Jul 2026 11:16:26 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30741 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30741 Vendor - TEL - Arpita Srivastava replied to Dara Navaei in LEAHI-DD-FIRMWARE-LDT-3735-1

Not needed because the retry mechanism is going to be deleted in the next ticket.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Vendor - TEL - Arpita Srivastava "I would rather keep it. Anyways, we need an els..." Mon, 27 Jul 2026 11:16:00 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30740 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30740 Vendor - TEL - Arpita Srivastava replied to Dara Navaei in LEAHI-DD-FIRMWARE-LDT-3735-1

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Vendor - TEL - Arpita Srivastava "I would rather keep it. Anyways, we need an els..." Mon, 27 Jul 2026 11:15:44 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30739 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30739 Vendor - TEL - Arpita Srivastava replied to Dara Navaei in LEAHI-DD-FIRMWARE-LDT-3735-1

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Vendor - TEL - Arpita Srivastava "Not needed because the retry mechanism is going..." Mon, 27 Jul 2026 11:14:24 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30738 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30738 Vendor - TEL - Arpita Srivastava replied to Dara Navaei in LEAHI-DD-FIRMWARE-LDT-3735-1

Not needed because the retry mechanism is going to be deleted in the next ticket.

]]> LEAHI-DD-FIRMWARE-LDT-4873-1: reviewers resumed Thu, 23 Jul 2026 16:57:15 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4873-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4873-1 Vendor - TEL - Jashwant Gantyada resumed reviewing LEAHI-DD-FIRMWARE-LDT-4873-1 LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault ]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Dara Navaei "Same question as above: should we alarm if the ..." Thu, 23 Jul 2026 11:22:59 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30669 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30669 Dara Navaei commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Same question as above: should we alarm if the retries failed?

]]>