Uncommented

Remove extra blank line.

Why is this service prefixed with "Tx"?
Also, Praneeth and I agreed to put these state machine services into a sub-folder of Services. See how he did it and do the same.

DrySelfTests unit.

DrySelfTests unit initialized.

Remove extra blank line.

.. handles dry self-tests execution for pre-treatment and treatment modes.

Should be in "", not <>. And should be placed alphabetically down before TxParams.h.

Calling signal function here seems circular (that's how we got here in the first place).
Shouldn't we set state to the install state here instead?

Put before TxParams.

I think Praneeth created a function for this. Make sure they're identical.

It looks like you deleted it instead of fixing it.

Need to request syringe pump to start a seek before we go to seek state. It's not implemented yet, so just put a TODO comment for now.

Need to check heparin bolus volume > 0 too.

Don't we need to check this too still?

Do we need to reset authStartTime here before we go to next state?

Put positive case first ( TRUE == ...), then alarm and reject cases.

No occlusion sensor in Leahi. Delete variable and references to it.

We should now send the scanned text to the UI s/w for authentication before we go to next state where we wait for UI response.

Remove extra l at end of flag name (mis-spelled). And why are we sending this flag with scan event? Seems like the Received flag is what you want here.

The barcode reader is under TD f/w control via the FPGA (not implemented yet). So asking UI s/w to do a scan doesn't make sense.

What is this flag for? And why is it only set here and not above where test passed.
Also, we are going to the loaded check state, but we are not requesting a scan first.

Local declarations should come first - move up above reset function above.

Leahi doesn't have occlusion sensor, so don't need this if statement. Not sure we need this start state. Maybe we can start in the wait for door close state.

start state function has same description as wait for door close state function. We shouldn't need 2 states to ensure door is closed.

I meant that you should move this function up, not init function down.

Change to initDrySelfTests() and move to top (should be first function).

prime state not yet implemented. comment this out w/ TODO comment and add an assignemtn to Rx state here for now.