I would keep blank line between library includes and regular includes.

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added.
I think you should just remove this new alarm 196 that you've added here.

Fix merge conflict stuff here.

Fix merge conflict stuff here.

Bubble status, Low and high level level sensors.

Input : Blood pump door status?

To be restored?

Are these being initialized in the init function?

Need to resolve the merge issues?

It looks like you have this as a T/F response from UI. UI should not be determining whether the modality matches - that's our job. UI should be telling us which type of tubing set was installed (HD or HDF type). Then when we get this response msg from UI, we will compare the type to the user selected modality (from TxParams) to see if it matches.

Add doxygen comments to the right of each structure field.

Why is this commented out? We will get stuck in this state if we don't move on to the pressure leak test states.

For now, we need to set authResponseReceived and authResponseValidTubingSet and authResponseModalityAccepted to TRUE until UI is properly responding to authentication request (TODO).

For now, we need to set barcodeScanResponseReceived to TRUE here until barcode scan command is implemented.

Add blank line before return statement.

Keep this blank line above group header.

Something is wrong here. We already had reg 33 at line 192 above. Reconcile with HDD.

· /firmware/App/Modes/ModePreTreat.c	(-13, +195)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreTreat.h	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-3, +12)	| History	| Source	| Diff
· /firmware/App/Services/FpgaTD.c	(-14, +253)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +20)	| History	| Source	| Diff
· /firmware/App/Services/StateServices/DrySelfTests.c	(-0, +1156)	| History	| Source
· /firmware/App/Services/StateServices/DrySelfTests.h	(-0, +55)	| History	| Source
· /firmware/App/Services/DrySelfTests.c	(-1156, +0)	| History	| Source	| Diff
· /firmware/App/Services/DrySelfTests.h	(-55, +0)	| History	| Source	| Diff

]]> Tue, 19 May 2026 17:38:43 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c29211 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c29211 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

Remove this blank line.

I missed updating this earlier, I’ll push the updated code.

Can't have 3 values. Maximum 2 values allowed.

Removedd

added

· /firmware/App/Services/DrySelfTests.c	(-14, +8)	| History	| Source	| Diff
· /firmware/App/Services/DrySelfTests.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-0, +1)	| History	| Source	| Diff

]]> Tue, 12 May 2026 17:06:29 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/changelog/td-firmware?cs=517b50e8915764d862fc9d38930c345c8f609196 https://devapps.diality.us/changelog/td-firmware?cs=517b50e8915764d862fc9d38930c345c8f609196 Vendor - TEL - Varshini Nagabooshanam committed 517b50e on branch LDT-2240-disposable-tube-set-self-test in td-firmware LDT-2240: Review comments addressed

· /firmware/App/Services/DrySelfTests.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/DrySelfTests.h	(-1, +1)	| History	| Source	| Diff

]]> Tue, 12 May 2026 09:40:37 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c29085 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c29085 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Updated

Remove start state.

Updated

updated