Fisheye on dd-firmware/firmware/App/Controllers/DryBiCart.h https://devapps.diality.us/changelog/~br%3DLDT-3103-closed-loop-control-pressure-threshold-fix/dd-firmware/firmware/App/Controllers/DryBiCart.h Recent activity in "dd-firmware" under directory /firmware/App/Controllers/DryBiCart.h LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Algin "=" to be consistent with those below." Wed, 01 Apr 2026 11:34:53 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28194 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28194 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Algin "=" to be consistent with those below.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Add blank line after declarations." Wed, 01 Apr 2026 11:34:27 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28193 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28193 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Add blank line after declarations.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Add blank line after declarations." Wed, 01 Apr 2026 11:33:58 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28192 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28192 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Add blank line after declarations.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Align comment." Wed, 01 Apr 2026 11:33:17 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28191 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28191 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Align comment.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Is it time to restore?" Wed, 01 Apr 2026 11:32:48 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28190 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28190 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Is it time to restore?

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Remove extra space after "="." Wed, 01 Apr 2026 11:31:43 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28189 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28189 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Remove extra space after "=".

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Are we going to restore this or not?" Wed, 01 Apr 2026 11:29:39 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28188 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28188 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Are we going to restore this or not?

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Are we going to restore this or not?" Wed, 01 Apr 2026 11:28:24 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28187 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28187 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Are we going to restore this or not?

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Are we going to restore this or not?" Wed, 01 Apr 2026 11:28:13 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28186 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28186 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Are we going to restore this or not?

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Remove this." Wed, 01 Apr 2026 11:27:32 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28185 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28185 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Remove this.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Remove this." Wed, 01 Apr 2026 11:26:07 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28184 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28184 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Remove this.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Remove spaces before "=" or align "="." Wed, 01 Apr 2026 11:23:26 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28183 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28183 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Remove spaces before "=" or align "=".

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Fix comment alignment." Wed, 01 Apr 2026 11:21:33 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28182 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28182 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Fix comment alignment.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Why are we commenting this out?" Wed, 01 Apr 2026 11:19:21 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28181 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28181 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Why are we commenting this out?

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Is it time to restore now?" Wed, 01 Apr 2026 11:18:55 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28180 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28180 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Is it time to restore now?

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Can we remove these 2 lines of code?" Wed, 01 Apr 2026 11:18:07 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28179 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28179 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Can we remove these 2 lines of code?

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Remove extra blank lines." Mon, 30 Mar 2026 10:15:09 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28142 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28142 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Remove extra blank lines.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "This "s" looks out of place." Mon, 30 Mar 2026 10:14:55 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28141 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28141 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

This "s" looks out of place.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "But this is a f/w shared unit (so both TD and D..." Mon, 30 Mar 2026 09:42:26 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28140 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28140 Sean Nash replied to Vendor - TEL - Sameer Poyil in LEAHI-DD-FIRMWARE-LDT-2004-9

But this is a f/w shared unit (so both TD and DD f/w include this unit in their build) and we may add a case later. Because it's a common unit, we should design it to work for both f/w builds.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vendor - TEL - Sameer Poyil "No, its deleted" Fri, 27 Mar 2026 07:56:50 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28139 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28139 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-2004-9

No, its deleted

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vendor - TEL - Sameer Poyil "I do not see TD use case in any of the PI contr..." Sat, 21 Mar 2026 07:56:33 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28129 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28129 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-2004-9

I do not see TD use case in any of the PI controller functions. so do we need TD here ?

]]> LEAHI-DD-FIRMWARE-LDT-2004-13: started by Dara Navaei Wed, 25 Mar 2026 04:01:46 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-13 ]]> LEAHI-DD-FIRMWARE-LDT-2004-11: started by Dara Navaei Thu, 19 Mar 2026 15:47:06 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-11 ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Why do we have a local sub state variable that ..." Thu, 19 Mar 2026 09:00:55 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28122 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28122 Sean Nash replied to Vendor - TEL - Sameer Poyil in LEAHI-DD-FIRMWARE-LDT-2004-9

Why do we have a local sub state variable that we don't do anything with?

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vendor - TEL - Sameer Poyil "This is to avoid compilation warning" Wed, 18 Mar 2026 20:29:34 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28121 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28121 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-2004-9

This is to avoid compilation warning

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "I don't think these coefficient access function..." Wed, 18 Mar 2026 13:05:49 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28118 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28118 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

I don't think these coefficient access functions need to be public. Consider making them private.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "These seem more like concentrate doses, not dia..." Wed, 18 Mar 2026 13:03:28 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28117 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28117 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

These seem more like concentrate doses, not dialysate doses. Consider renaming.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "What is this?" Wed, 18 Mar 2026 13:02:39 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28116 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28116 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

What is this?

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Add blank line after declarations." Wed, 18 Mar 2026 13:01:03 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28115 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28115 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Add blank line after declarations.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Are these coming back? If so, add TODO comment..." Wed, 18 Mar 2026 13:00:33 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28114 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28114 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

]]>