· /firmware/App/Controllers/BalancingChamber.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/DialysatePumps.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-6, +6)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.h	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Controllers/SpentChamberFill.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/DDCommon.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/FPOperationModes.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.c	(-2, +2)	| History	| Source	| Diff
… 3 more files in changeset.

]]> Tue, 10 Feb 2026 13:32:45 -0800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3 Vendor - TEL - Sameer Poyil and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-2004-3 LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD ]]> Tue, 10 Feb 2026 10:50:36 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3/#c27156 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-3/#c27156 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-3

Add TODO to comment.

Put () around the 2 conditions

Fixed it

Ya , I forgot the coding guide line .
Fixed it

fixed it

Fixed it

fixed it

Use explicit BOOL conditions (e.g. TRUE == isFreshDialysatePressureInRange).

I prefer to be explicit on BOOL conditions like this (e.g. TRUE == isFreshDialysatePressureInRange).

Remove extra blank line.

I don't think we need to check test config for variable initialization.

fixed it

Fixed it

fixed it

fixed it

fixed it

fixed it

fixed it

Since fill and drain is a single time request and it is not a frequent request similar to supply during dialysate generation. I removed and now run as idle

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress, anyone can request drain and both requests will be handled. even through new code run only one state machine at a time, this will ensure that only one request is submitted to drybicart

This was a concern reported by Sean and proposed for restructuring into a single state machine.

This doesn't look like a valid substate. We should have an enum for valid substates. In default case, we should trigger a s/w fault and also set the state to a valid state (idle or something like that).

I think /// was correct. // will not be seen by doxygen.

Not clear, why we are checking fill and supply request here?

we should use the functions defined in testsupport.c/h -> getU32OverrideValue, getF32OverrideValue based on data type. this needs to be fixed throughout the file.