Fisheye on dd-firmware/firmware/App/DDCommon.h https://devapps.diality.us/changelog/~br%3DLDT-3103-closed-loop-control-pressure-threshold-fix/dd-firmware/firmware/App/DDCommon.h Recent activity in "dd-firmware" under directory /firmware/App/DDCommon.h LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Yes, this needs to be corrected. I don't see an..." Mon, 13 Apr 2026 14:58:10 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28299 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28299 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Since feedforward output is same as control sig..." Mon, 13 Apr 2026 11:58:50 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28297 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28297 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Reduced gain and testing in progress." Mon, 13 Apr 2026 11:57:38 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28296 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28296 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Reduced gain and testing in progress.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Reduced gain and testing in progress." Mon, 13 Apr 2026 11:57:10 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28295 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28295 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Reduced gain and testing in progress.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Mon, 13 Apr 2026 11:56:28 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28294 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28294 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Mon, 13 Apr 2026 11:56:16 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28293 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28293 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> dd-firmware (staging): Bamboo Commit: Updated DDCommon.h with build versions from Bamboo. Fri, 10 Apr 2026 11:45:20 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=adc39742f3ba501e779e30e40553f27c45207446 https://devapps.diality.us/changelog/dd-firmware?cs=adc39742f3ba501e779e30e40553f27c45207446 Dara Navaei committed adc3974 on branch LDT-3103-closed-loop-control-pressure-threshold-fix, staging in dd-firmware Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h (-1, +1) | History | Source | Diff
]]> dd-firmware (staging): Bamboo Commit: Updated DDCommon.h with build versions from Bamboo. Fri, 10 Apr 2026 10:38:49 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=e2f19f2fbe7f211de357ce0ed7f23163695c27ca https://devapps.diality.us/changelog/dd-firmware?cs=e2f19f2fbe7f211de357ce0ed7f23163695c27ca Dara Navaei committed e2f19f2 on branch LDT-3103-closed-loop-control-pressure-threshold-fix, staging in dd-firmware Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h (-1, +1) | History | Source | Diff
]]> LEAHI-DD-FIRMWARE-LDT-2008-1: comment by Vendor - TEL - Sameer Poyil "its auto generated . should not change it manua..." Fri, 10 Apr 2026 10:25:29 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28290 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28290 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-2008-1

its auto generated . should not change it manually. any way when merging its added correct value

]]> LEAHI-DD-FIRMWARE-LDT-2008-1: comment by Vendor - TEL - Sameer Poyil "Now we don't need this macro ?" Fri, 10 Apr 2026 10:24:39 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28289 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28289 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-2008-1

Now we don't need this macro ?

]]> LEAHI-DD-FIRMWARE-LDT-2008-1: comment by Vendor - TEL - Sameer Poyil "now we are initializing sensor simultaneously?" Fri, 10 Apr 2026 10:17:08 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28288 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28288 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-2008-1

now we are initializing sensor simultaneously?

]]> LEAHI-DD-FIRMWARE-LDT-2008-1: comment by Vendor - TEL - Sameer Poyil "comments missing" Fri, 10 Apr 2026 10:16:04 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28287 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28287 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-2008-1

comments missing

]]> LEAHI-DD-FIRMWARE-LDT-2008-1: comment by Vendor - TEL - Sameer Poyil "comments missing" Fri, 10 Apr 2026 10:15:54 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28286 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28286 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-2008-1

comments missing

]]> LEAHI-DD-FIRMWARE-LDT-2008-1: comment by Vendor - TEL - Sameer Poyil "This is not clear- please give a detailed descr..." Fri, 10 Apr 2026 10:15:08 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28285 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28285 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-2008-1

This is not clear- please give a detailed description for this variable

]]> LEAHI-DD-FIRMWARE-LDT-2008-1: comment by Vendor - TEL - Sameer Poyil "use capital for starting letter" Fri, 10 Apr 2026 10:14:09 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28284 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28284 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-2008-1

use capital for starting letter

]]> LEAHI-DD-FIRMWARE-LDT-2008-1: comment by Vendor - TEL - Sameer Poyil "please align the comments" Fri, 10 Apr 2026 10:13:49 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28283 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28283 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-2008-1

please align the comments

]]> LEAHI-DD-FIRMWARE-LDT-2008-1: comment by Vendor - TEL - Sameer Poyil "please Alignment the comments" Fri, 10 Apr 2026 10:13:24 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28282 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28282 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-2008-1

please Alignment the comments

]]> LEAHI-DD-FIRMWARE-LDT-2008-1: comment by Vendor - TEL - Sameer Poyil "Why the order is important here ? please docume..." Fri, 10 Apr 2026 10:10:01 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28281 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28281 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-2008-1

Why the order is important here ? please document it

]]> LEAHI-DD-FIRMWARE-LDT-2008-1: reviewers joined LEAHI-DD-FIRMWARE-LDT-2008_Dialysate Composition -... Fri, 10 Apr 2026 10:06:32 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1 Vendor - TEL - Sameer Poyil joined LEAHI-DD-FIRMWARE-LDT-2008-1 LEAHI-DD-FIRMWARE-LDT-2008_Dialysate Composition - DD - 04: DEV - Feature Implementation ]]> LEAHI-DD-FIRMWARE-LDT-2008-1: comment by Vendor - TEL - Sameer Poyil "do we need bracket here ? all text should start..." Fri, 10 Apr 2026 10:06:03 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28280 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28280 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-2008-1

do we need bracket here ? all text should start with capital

]]> LEAHI-DD-FIRMWARE-LDT-2008-1: comment by Vendor - TEL - Sameer Poyil "Why a * here ?" Fri, 10 Apr 2026 10:00:34 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28279 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28279 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-2008-1

Why a * here ?

]]> LEAHI-DD-FIRMWARE-LDT-2008-1: comment by Vendor - TEL - Sameer Poyil "is it write states or read state ?" Fri, 10 Apr 2026 09:43:30 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28278 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28278 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-2008-1

is it write states or read state ?

]]> LEAHI-DD-FIRMWARE-LDT-2008-1: comment by Vendor - TEL - Sameer Poyil "is documentation correct ?" Fri, 10 Apr 2026 09:43:09 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28277 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28277 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-2008-1

is documentation correct ?

]]> LEAHI-DD-FIRMWARE-LDT-2008-1: comment by Sean Nash "Why do some functions take sensor as a U32 and ..." Wed, 08 Apr 2026 12:25:55 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28268 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28268 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2008-1

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

]]> LEAHI-DD-FIRMWARE-LDT-2008-1: comment by Sean Nash "Remove blank line." Wed, 08 Apr 2026 12:24:52 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28267 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28267 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2008-1

Remove blank line.

]]> LEAHI-DD-FIRMWARE-LDT-2008-1: comment by Sean Nash "Remove blank line." Wed, 08 Apr 2026 12:24:40 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28266 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28266 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2008-1

Remove blank line.

]]> LEAHI-DD-FIRMWARE-LDT-2008-1: comment by Sean Nash "Add blank line before return." Wed, 08 Apr 2026 12:23:48 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28265 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28265 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2008-1

Add blank line before return.

]]> LEAHI-DD-FIRMWARE-LDT-2008-1: comment by Sean Nash "Add blank line before return." Wed, 08 Apr 2026 12:22:13 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28264 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28264 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2008-1

Add blank line before return.

]]> LEAHI-DD-FIRMWARE-LDT-2008-1: comment by Sean Nash "Remove blank line." Wed, 08 Apr 2026 12:19:20 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28263 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28263 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2008-1

Remove blank line.

]]> dd-firmware (LDT-3103-closed-loop-control-pressure-threshold-fix): Bamboo Commit: Updated DDCommon.h with build versions from Bamboo. Mon, 06 Apr 2026 13:25:42 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=2a5e8f1c7b548d49be9b547001370470ff87c038 https://devapps.diality.us/changelog/dd-firmware?cs=2a5e8f1c7b548d49be9b547001370470ff87c038 Dara Navaei committed 2a5e8f1 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-2008-v2-conductivity-sensors-CLEAN and 5 more in dd-firmware Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h (-1, +1) | History | Source | Diff
]]>