· /firmware/App/Modes/FPModes/FPModeFault.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/FPModeFault.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/FPModeStandby.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/FPModeStandby.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/FPOperationModes.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/FPOperationModes.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModeGenPermeate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModeGenPermeate.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeate.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeateDefeatured.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeateDefeatured.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateInletPressureCheck.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateInletPressureCheck.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff

]]> Thu, 02 Apr 2026 07:11:40 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-1 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-3603-1 ]]> Thu, 02 Apr 2026 07:11:34 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-3603-2 ]]> Wed, 01 Apr 2026 12:26:32 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2 Vinayakam Mani , Michael Garthwaite and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3603-2 LEAHI-DD-FIRMWARE-LDT-3603_Ability to set operation sub mode on IOFP subsystem ]]> Tue, 31 Mar 2026 10:26:39 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2/#c28172 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2/#c28172 Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3603-2

Updated

Added

Add a comment:
result already FALSE - do nothing more for modes that do not support jump to sub-mode.

Add a comment here:
Do nothing for modes that do not support jump to sub-mode.

Updated

Updated, thanks

'genPermeateState' in the outputs. please update across the files as needed.

Validates the requested sub mode change is acceptable or not?

· /firmware/App/Modes/FPModes/FPModeFault.c	(-0, +62)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/FPModeFault.h	(-2, +5)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/FPModeStandby.c	(-0, +52)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/FPModeStandby.h	(-1, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/FPOperationModes.c	(-2, +166)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/FPOperationModes.h	(-1, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModeGenPermeate.c	(-0, +55)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModeGenPermeate.h	(-1, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.c	(-0, +58)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.h	(-0, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeate.c	(-0, +86)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeate.h	(-9, +11)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeateDefeatured.c	(-0, +67)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeateDefeatured.h	(-1, +3)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateInletPressureCheck.c	(-0, +13)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateInletPressureCheck.h	(-1, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-0, +1)	| History	| Source	| Diff

]]> Wed, 25 Mar 2026 04:01:46 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-13 ]]> Thu, 19 Mar 2026 15:47:06 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-11 ]]> Wed, 18 Mar 2026 14:30:07 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-1 Sean Nash and Michael Garthwaite finished reviewing LEAHI-DD-FIRMWARE-LDT-3603-1 LEAHI-DD-FIRMWARE-LDT-3603_Ability to set operation sub mode on IOFP sub system ]]> Thu, 12 Mar 2026 07:19:35 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-1/#c27906 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-1/#c27906 Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3603-1

That's a question for me, will that be required?

Fault has sub modes(3), Standby has 1 sub mode(I am adding code for this as this might be required)
Init don't have any and service is not defined yet

Updated

Updated

Changed and left them as static, as we don't need these outside this unit

You are right, (missed that while duplicating the functions)

if ( TRUE == result )

Since both states require no special handling, remove breaks and group with default - all modes.

Remove comment.

Add comment that all of these states require no special handling.

I think these functions (validate and signal) should be "test" functions and moved down to Dialin test functions section below - for all modes.

Add comment that no action is required for these modes - defaulting to invalid request.

I think this switch should be on requested mode - we haven't changed modes yet.