Fisheye on dd-firmware/firmware/App/Modes/FPModes/StateFlushPermeate.c https://devapps.diality.us/changelog/~br%3DLDT-3103-closed-loop-control-pressure-threshold-fix/dd-firmware/firmware/App/Modes/FPModes/StateFlushPermeate.c Recent activity in "dd-firmware" under directory /firmware/App/Modes/FPModes/StateFlushPermeate.c LEAHI-DD-FIRMWARE-LDT-3978-1: reviewers joined LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conduc... Thu, 23 Apr 2026 14:59:17 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Vinayakam Mani joined LEAHI-DD-FIRMWARE-LDT-3978-1 LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid ]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "instead of 0, we can use the level Enum 'LVL_ST..." Thu, 23 Apr 2026 14:56:16 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28636 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28636 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "lower? and change the D98 level sensor comment ..." Thu, 23 Apr 2026 14:49:10 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28635 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28635 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

lower? and change the D98 level sensor comment as well.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Remove empty line" Thu, 23 Apr 2026 14:47:11 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28634 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28634 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Remove empty line

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Space before LVL_STATE_LOW" Thu, 23 Apr 2026 14:45:56 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28633 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28633 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Space before LVL_STATE_LOW

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "space inside array index." Thu, 23 Apr 2026 14:43:35 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28632 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28632 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

space inside array index.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Space inside parenthesis." Thu, 23 Apr 2026 14:41:03 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28631 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28631 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Space inside parenthesis.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Change this to LEVEL_T enum." Thu, 23 Apr 2026 14:39:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28630 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28630 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Change this to LEVEL_T enum.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Is this macro still being used? if not, delete ..." Thu, 23 Apr 2026 14:38:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28629 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28629 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Is this macro still being used? if not, delete it.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: started by Dara Navaei Thu, 23 Apr 2026 07:47:26 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3978-1 ]]> LEAHI-DD-FIRMWARE-LDT-2004-13: started by Dara Navaei Wed, 25 Mar 2026 04:01:46 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-13 ]]> LEAHI-DD-FIRMWARE-LDT-2004-11: started by Dara Navaei Thu, 19 Mar 2026 15:47:06 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-11 ]]> LEAHI-DD-FIRMWARE-LDT-3218-1: closed by Raghu Kallala Thu, 29 Jan 2026 14:43:22 -0800 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-1 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-3218-1 ]]> LEAHI-DD-FIRMWARE-LDT-3218-1: reviewers finished Thu, 29 Jan 2026 14:43:00 -0800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-1 Michael Garthwaite and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3218-1 LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed) ]]> LEAHI-DD-FIRMWARE-LDT-3218-1: reviewers added to LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate ta... Thu, 29 Jan 2026 14:34:19 -0800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-1 Raghu Kallala added Michael Garthwaite to LEAHI-DD-FIRMWARE-LDT-3218-1 LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed) ]]> LEAHI-DD-FIRMWARE-LDT-3218-1: reviewers left LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate ta... Thu, 29 Jan 2026 14:34:19 -0800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-1 Raghu Kallala left LEAHI-DD-FIRMWARE-LDT-3218-1 LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed) ]]> LEAHI-DD-FIRMWARE-LDT-3218-1: started by Dara Navaei Thu, 29 Jan 2026 14:31:28 -0800 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3218-1 ]]> LEAHI-DD-FIRMWARE-LDT-1925-1: closed by Raghu Kallala Wed, 21 Jan 2026 10:10:21 -0800 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-1925-1 ]]> LEAHI-DD-FIRMWARE-LDT-1925-1: reviewers finished Wed, 21 Jan 2026 09:46:06 -0800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1 Michael Garthwaite finished reviewing LEAHI-DD-FIRMWARE-LDT-1925-1 LEAHI-DD-FIRMWARE-LDT-1925_IOFP - Understand lag in P16 flow measurement vs. P7 flow measurement after RO pump startup ]]> LEAHI-DD-FIRMWARE-LDT-1925-1: reviewers finished Tue, 20 Jan 2026 14:19:07 -0800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-1925-1 LEAHI-DD-FIRMWARE-LDT-1925_IOFP - Understand lag in P16 flow measurement vs. P7 flow measurement after RO pump startup ]]> LEAHI-DD-FIRMWARE-LDT-1925-1: comment by Raghu Kallala "Updated" Tue, 20 Jan 2026 14:14:53 -0800 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26471 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26471 Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-1925-1

Updated

]]> LEAHI-DD-FIRMWARE-LDT-1925-1: comment by Raghu Kallala "Added" Tue, 20 Jan 2026 14:14:43 -0800 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26470 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26470 Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-1925-1

Added

]]> LEAHI-DD-FIRMWARE-LDT-1925-1: comment by Raghu Kallala "Updated" Tue, 20 Jan 2026 14:14:34 -0800 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26469 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26469 Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-1925-1

Updated

]]> LEAHI-DD-FIRMWARE-LDT-1925-1: comment by Raghu Kallala "Fixed" Tue, 20 Jan 2026 14:14:25 -0800 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26468 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26468 Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-1925-1

Fixed

]]> LEAHI-DD-FIRMWARE-LDT-1925-1: comment by Sean Nash "TRUE if low flow alarm is exempt, FALSE if not." Tue, 20 Jan 2026 14:12:53 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26467 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26467 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-1925-1

TRUE if low flow alarm is exempt, FALSE if not.

]]> LEAHI-DD-FIRMWARE-LDT-1925-1: comment by Sean Nash "timeSinceP12Started?" Tue, 20 Jan 2026 14:08:17 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26466 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26466 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-1925-1

timeSinceP12Started?

]]> LEAHI-DD-FIRMWARE-LDT-1925-1: comment by Sean Nash "Should we have a comment for this one too?" Tue, 20 Jan 2026 14:07:49 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26465 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26465 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-1925-1

Should we have a comment for this one too?

]]> LEAHI-DD-FIRMWARE-LDT-1925-1: comment by Sean Nash "Should we rename this function to "isROPumpLowf..." Tue, 20 Jan 2026 14:06:47 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26464 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26464 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-1925-1

Should we rename this function to "isROPumpLowflowAlarmExempt"? The current name makes me think it will set the alarm to be exempt.

]]> LEAHI-DD-FIRMWARE-LDT-1925-1: comment by Raghu Kallala "Updated to use isPersistentAlarmTriggered" Tue, 20 Jan 2026 13:43:41 -0800 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26463 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26463 Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-1925-1

Updated to use isPersistentAlarmTriggered

]]> LEAHI-DD-FIRMWARE-LDT-1925-1: comment by Raghu Kallala "Fixed" Tue, 20 Jan 2026 13:43:24 -0800 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26462 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26462 Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-1925-1

Fixed

]]>