Fisheye on dd-firmware/firmware/App/Modes/ModePreGenDialysate.h https://devapps.diality.us/changelog/~br%3DLDT-3103-closed-loop-control-pressure-threshold-fix/dd-firmware/firmware/App/Modes/ModePreGenDialysate.h Recent activity in "dd-firmware" under directory /firmware/App/Modes/ModePreGenDialysate.h LEAHI-DD-FIRMWARE-LDT-3749-2: comment by Vinayakam Mani "The FP signals are not included in the DD-pre g..." Fri, 10 Apr 2026 11:44:22 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28291 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28291 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3749-2

The FP signals are not included in the DD-pre gen/Gen dialysate transition functions. They have handled separately in the TD Interface.

]]> LEAHI-DD-FIRMWARE-LDT-3749-2: comment by Raghu Kallala "You are right, modified in all places" Fri, 10 Apr 2026 08:21:51 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28276 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28276 Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3749-2

You are right, modified in all places

]]> LEAHI-DD-FIRMWARE-LDT-3749-2: comment by Sean Nash "FALSE?" Wed, 08 Apr 2026 13:51:58 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28275 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28275 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3749-2

FALSE?

]]> LEAHI-DD-FIRMWARE-LDT-3749-2: comment by Sean Nash "FALSE?" Wed, 08 Apr 2026 13:50:58 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28273 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28273 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3749-2

FALSE?

]]> LEAHI-DD-FIRMWARE-LDT-3749-2: comment by Sean Nash "Should default be TRUE? If we are being asked ..." Wed, 08 Apr 2026 13:46:15 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28271 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28271 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3749-2

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

]]> LEAHI-DD-FIRMWARE-LDT-3749-2: comment by Sean Nash "[~vmani], how does that signal happen normally?..." Wed, 08 Apr 2026 13:42:55 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28270 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28270 Sean Nash replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-3749-2

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always happen regardless of how we got to pre-gen mode.

]]> LEAHI-DD-FIRMWARE-LDT-3749-2: comment by Sean Nash "Add comment that these modes not (yet?) support..." Wed, 08 Apr 2026 13:41:15 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28269 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28269 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3749-2

Add comment that these modes not (yet?) supported.

]]> LEAHI-DD-FIRMWARE-LDT-3749-2: reviewers added to LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operatio... Wed, 08 Apr 2026 08:24:15 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 Dara Navaei added Vinayakam Mani to LEAHI-DD-FIRMWARE-LDT-3749-2 LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem ]]> LEAHI-DD-FIRMWARE-LDT-3749-2: comment by Vinayakam Mani "Probably, we need to signal FP as well when the..." Tue, 07 Apr 2026 14:49:15 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28251 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28251 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3749-2

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we implemented in TD interface).

]]> LEAHI-DD-FIRMWARE-LDT-3749-2: started by Dara Navaei Mon, 06 Apr 2026 13:00:58 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3749-2 ]]> LEAHI-DD-FIRMWARE-LDT-3749-1: closed by Raghu Kallala Mon, 06 Apr 2026 12:45:29 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-1 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-3749-1 ]]> LEAHI-DD-FIRMWARE-LDT-2004-13: started by Dara Navaei Wed, 25 Mar 2026 04:01:46 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-13 ]]> LEAHI-DD-FIRMWARE-LDT-2004-11: started by Dara Navaei Thu, 19 Mar 2026 15:47:06 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-11 ]]> LEAHI-DD-FIRMWARE-LDT-3749-1: started by Dara Navaei Tue, 17 Mar 2026 07:22:29 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3749-1 ]]> dd-firmware (LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test-3-30-2026): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 09 Jan 2026 10:07:55 -0800 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=830213bc6dcc1a684610caf78c79d55f2cb41e93 https://devapps.diality.us/changelog/dd-firmware?cs=830213bc6dcc1a684610caf78c79d55f2cb41e93 Dara Navaei committed 830213b on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 60 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BalancingChamber.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/BalancingChamber.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/BoostPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/BoostPump.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DialysatePumps.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DialysatePumps.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/PermeateTank.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/PermeateTank.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/RinsePump.c (-3, +3) | History | Source | Diff
… 107 more files in changeset.
]]> dd-firmware (LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test-3-30-2026): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 05 Dec 2025 13:26:33 -0800 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=3417933e6edf61a914c428e2fa944b3b349272a4 https://devapps.diality.us/changelog/dd-firmware?cs=3417933e6edf61a914c428e2fa944b3b349272a4 Dara Navaei committed 3417933 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 66 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BalancingChamber.c (-4, +4) | History | Source | Diff
· /firmware/App/Controllers/BalancingChamber.h (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/BoostPump.c (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/BoostPump.h (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/DialysatePumps.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/DialysatePumps.h (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/PermeateTank.c (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/PermeateTank.h (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/RinsePump.c (-3, +3) | History | Source | Diff
… 107 more files in changeset.
]]> DD-LDT-815-1: closed by Vinayakam Mani Mon, 07 Jul 2025 10:21:08 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-815-1 https://devapps.diality.us/cru/DD-LDT-815-1 Vinayakam Mani Closed DD-LDT-815-1 ]]> DD-LDT-815-1: reviewers finished Mon, 07 Jul 2025 09:32:40 -0700 https://devapps.diality.us/cru/DD-LDT-815-1 https://devapps.diality.us/cru/DD-LDT-815-1 Michael Garthwaite finished reviewing DD-LDT-815-1 DD-LDT-815_Stop State DD ]]> DD-LDT-815-1: reviewers finished Thu, 03 Jul 2025 13:21:05 -0700 https://devapps.diality.us/cru/DD-LDT-815-1 https://devapps.diality.us/cru/DD-LDT-815-1 Sean Nash finished reviewing DD-LDT-815-1 DD-LDT-815_Stop State DD ]]> DD-LDT-815-1: comment by Vinayakam Mani "Done." Thu, 03 Jul 2025 12:45:18 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-815-1/#c22733 https://devapps.diality.us/cru/DD-LDT-815-1/#c22733 Vinayakam Mani replied to Sean Nash in DD-LDT-815-1

Done.

]]> DD-LDT-815-1: comment by Vinayakam Mani "Done." Thu, 03 Jul 2025 12:42:04 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-815-1/#c22732 https://devapps.diality.us/cru/DD-LDT-815-1/#c22732 Vinayakam Mani replied to Sean Nash in DD-LDT-815-1

Done.

]]> DD-LDT-815-1: comment by Vinayakam Mani "Removed." Thu, 03 Jul 2025 12:41:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-815-1/#c22731 https://devapps.diality.us/cru/DD-LDT-815-1/#c22731 Vinayakam Mani replied to Sean Nash in DD-LDT-815-1

Removed.

]]> DD-LDT-815-1: comment by Vinayakam Mani "Done." Thu, 03 Jul 2025 12:41:46 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-815-1/#c22730 https://devapps.diality.us/cru/DD-LDT-815-1/#c22730 Vinayakam Mani replied to Sean Nash in DD-LDT-815-1

Done.

]]> DD-LDT-815-1: comment by Vinayakam Mani "Done." Thu, 03 Jul 2025 12:41:34 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-815-1/#c22729 https://devapps.diality.us/cru/DD-LDT-815-1/#c22729 Vinayakam Mani replied to Sean Nash in DD-LDT-815-1

Done.

]]> DD-LDT-815-1: comment by Sean Nash "Mark these questions with TODO to aid in follow..." Thu, 03 Jul 2025 12:12:10 -0700 Sean Nash https://devapps.diality.us/cru/DD-LDT-815-1/#c22720 https://devapps.diality.us/cru/DD-LDT-815-1/#c22720 Sean Nash commented on DD-LDT-815-1

Mark these questions with TODO to aid in follow-up.

]]> DD-LDT-815-1: comment by Sean Nash "Reset to start state in default." Thu, 03 Jul 2025 12:10:24 -0700 Sean Nash https://devapps.diality.us/cru/DD-LDT-815-1/#c22719 https://devapps.diality.us/cru/DD-LDT-815-1/#c22719 Sean Nash commented on DD-LDT-815-1

Reset to start state in default.

]]> DD-LDT-815-1: comment by Sean Nash "Is this complete state needed? I don't see how..." Thu, 03 Jul 2025 12:09:44 -0700 Sean Nash https://devapps.diality.us/cru/DD-LDT-815-1/#c22718 https://devapps.diality.us/cru/DD-LDT-815-1/#c22718 Sean Nash commented on DD-LDT-815-1

Is this complete state needed? I don't see how we even get here.

]]> DD-LDT-815-1: comment by Sean Nash "Add a TODO comment to complete when NV POST imp..." Thu, 03 Jul 2025 12:08:47 -0700 Sean Nash https://devapps.diality.us/cru/DD-LDT-815-1/#c22717 https://devapps.diality.us/cru/DD-LDT-815-1/#c22717 Sean Nash commented on DD-LDT-815-1

Add a TODO comment to complete when NV POST implemented.

]]> DD-LDT-815-1: comment by Sean Nash "Keep a blank line between banner and variables." Thu, 03 Jul 2025 11:54:03 -0700 Sean Nash https://devapps.diality.us/cru/DD-LDT-815-1/#c22716 https://devapps.diality.us/cru/DD-LDT-815-1/#c22716 Sean Nash commented on DD-LDT-815-1

Keep a blank line between banner and variables.

]]> dd-firmware (LDT-1873-dialysate-flow-rate---dd-1): LDT-815 code update Thu, 26 Jun 2025 11:42:47 -0700 Vinayakam Mani https://devapps.diality.us/changelog/dd-firmware?cs=f6fb03f1e20395a61a5d5996f11f802ab8eacb2f https://devapps.diality.us/changelog/dd-firmware?cs=f6fb03f1e20395a61a5d5996f11f802ab8eacb2f Vinayakam Mani committed f6fb03f on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1195-dd-request-for-a-variable-ALPHA and 89 more in dd-firmware LDT-815 code update

· /firmware/App/Controllers/Heaters.c (-5, +9) | History | Source | Diff
· /firmware/App/DDCommon.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-19, +189) | History | Source | Diff
· /firmware/App/Modes/ModeGenDialysate.c (-25, +5) | History | Source | Diff
· /firmware/App/Modes/ModeGenDialysate.h (-2, +1) | History | Source | Diff
· /firmware/App/Modes/ModePreGenDialysate.c (-50, +10) | History | Source | Diff
· /firmware/App/Modes/ModePreGenDialysate.h (-2, +0) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-25, +5) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.h (-2, +0) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-5, +95) | History | Source | Diff
· /firmware/App/Monitors/Temperature.h (-0, +4) | History | Source | Diff
· /firmware/App/Services/FpgaDD.c (-13, +20) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-4, +0) | History | Source | Diff
]]>