Fisheye on dd-firmware/firmware/App/Monitors/Temperature.h https://devapps.diality.us/changelog/~br%3DLDT-3103-closed-loop-control-pressure-threshold-fix/dd-firmware/firmware/App/Monitors/Temperature.h Recent activity in "dd-firmware" under directory /firmware/App/Monitors/Temperature.h LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Yes, this needs to be corrected. I don't see an..." Mon, 13 Apr 2026 14:58:10 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28299 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28299 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Since feedforward output is same as control sig..." Mon, 13 Apr 2026 11:58:50 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28297 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28297 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Reduced gain and testing in progress." Mon, 13 Apr 2026 11:57:38 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28296 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28296 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Reduced gain and testing in progress.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Reduced gain and testing in progress." Mon, 13 Apr 2026 11:57:10 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28295 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28295 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Reduced gain and testing in progress.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Mon, 13 Apr 2026 11:56:28 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28294 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28294 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Mon, 13 Apr 2026 11:56:16 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28293 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28293 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-1477-1: closed by Vinayakam Mani Mon, 06 Apr 2026 14:12:43 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1 Vinayakam Mani Closed LEAHI-DD-FIRMWARE-LDT-1477-1 ]]> dd-firmware (LDT-3103-closed-loop-control-pressure-threshold-fix): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Mon, 06 Apr 2026 12:26:48 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=623587d96bf6c0bafd3ff94d47f8c783b4b999f0 https://devapps.diality.us/changelog/dd-firmware?cs=623587d96bf6c0bafd3ff94d47f8c783b4b999f0 Dara Navaei committed 623587d on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-2008-v2-conductivity-sensors-CLEAN and 6 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BalancingChamber.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Ultrafiltration.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeGenDialysate.c (-2, +2) | History | Source | Diff
· /firmware/App/Monitors/Temperature.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/TDInterface.c (-2, +2) | History | Source | Diff
]]> LEAHI-DD-FIRMWARE-LDT-1477-1: reviewers finished Mon, 06 Apr 2026 11:52:00 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1 Vendor - TEL - Jashwant Gantyada and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-1477-1 LEAHI-DD-FIRMWARE-LDT-1477_Ultrafiltration - DD - 04: DEV - Feature Implementation ]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "Not sure these min/max are right here either." Mon, 06 Apr 2026 10:30:32 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28230 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28230 Sean Nash replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-3352-1

Not sure these min/max are right here either.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "So we have all temp sensors getting averaged no..." Mon, 06 Apr 2026 10:27:34 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28229 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28229 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "Remove extra blank lines." Mon, 06 Apr 2026 10:24:54 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28227 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28227 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

Remove extra blank lines.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Fri, 03 Apr 2026 15:35:04 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28219 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28219 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done" Fri, 03 Apr 2026 15:34:48 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28218 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28218 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Fri, 03 Apr 2026 15:34:30 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28217 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28217 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "Same comment." Fri, 03 Apr 2026 13:20:23 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28216 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28216 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

Same comment.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "Having much larger P coeff is likely to cause a..." Fri, 03 Apr 2026 13:18:56 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28215 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28215 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "Input is d78TempAvgC" Fri, 03 Apr 2026 13:14:56 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28214 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28214 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

Input is d78TempAvgC

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "I don't think these min/max (for control output..." Fri, 03 Apr 2026 13:11:46 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28213 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28213 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:43:57 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28210 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28210 Vinayakam Mani replied to Vendor - TEL - Sameer Poyil in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Just following the current style of code implem..." Thu, 02 Apr 2026 15:42:21 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28209 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28209 Vinayakam Mani replied to Vendor - TEL - Sameer Poyil in LEAHI-DD-FIRMWARE-LDT-3352-1

Just following the current style of code implementation to keep it uniform. These defines are temporary and will be removed.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:40:23 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28208 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28208 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:39:59 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28207 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28207 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:39:30 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28206 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28206 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-1477-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:28:25 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28205 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28205 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-1477-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-1477-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:28:17 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28204 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28204 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-1477-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-1477-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:27:47 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28203 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28203 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-1477-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-1477-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:27:38 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28202 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28202 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-1477-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-1477-1: reviewers added to LEAHI-DD-FIRMWARE-LDT-1477_Ultrafiltration - DD - ... Thu, 02 Apr 2026 09:04:57 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1 Sean Nash added Vendor - TEL - Jashwant Gantyada , Vendor - TEL - Praneeth Bunne and Vendor - TEL - Sameer Poyil to LEAHI-DD-FIRMWARE-LDT-1477-1 LEAHI-DD-FIRMWARE-LDT-1477_Ultrafiltration - DD - 04: DEV - Feature Implementation ]]> LEAHI-DD-FIRMWARE-LDT-1477-1: comment by Sean Nash "Reverse order of comparison" Thu, 02 Apr 2026 09:04:04 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28199 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28199 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-1477-1

Reverse order of comparison

]]>