Fisheye on dd-firmware/firmware/App/Modes/ModeService.c https://devapps.diality.us/changelog/~br%3DLDT-319-basic-dialysis-treatment-dd-UIT/dd-firmware/firmware/App/Modes/ModeService.c Recent activity in "dd-firmware" under directory /firmware/App/Modes/ModeService.c LEAHI-DD-FIRMWARE-LDT-1195-2: reviewers finished Fri, 10 Apr 2026 11:38:33 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-1195-2 LEAHI-DD-FIRMWARE-LDT-1195_DD: Request for a variable for balancing chamber switching to be active (T/F) ]]> LEAHI-DD-FIRMWARE-LDT-1195-2: comment by Vinayakam Mani "Balancing chamber switching control" Mon, 06 Apr 2026 11:36:05 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2/#c28242 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2/#c28242 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-1195-2

Balancing chamber switching control

]]> LEAHI-DD-FIRMWARE-LDT-1195-2: comment by Vinayakam Mani "remove the space before false." Mon, 06 Apr 2026 11:29:39 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2/#c28240 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2/#c28240 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-1195-2

remove the space before false.

]]> LEAHI-DD-FIRMWARE-LDT-1195-2: comment by Vinayakam Mani "Remove blank line" Mon, 06 Apr 2026 11:23:51 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2/#c28239 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2/#c28239 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-1195-2

Remove blank line

]]> LEAHI-DD-FIRMWARE-LDT-1195-2: comment by Vinayakam Mani "Remove blank line." Mon, 06 Apr 2026 11:23:12 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2/#c28238 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2/#c28238 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-1195-2

Remove blank line.

]]> LEAHI-DD-FIRMWARE-LDT-1195-2: reviewers added to LEAHI-DD-FIRMWARE-LDT-1195_DD: Request for a varia... Mon, 06 Apr 2026 11:00:47 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2 Sean Nash added Vinayakam Mani to LEAHI-DD-FIRMWARE-LDT-1195-2 LEAHI-DD-FIRMWARE-LDT-1195_DD: Request for a variable for balancing chamber switching to be active (T/F) ]]> LEAHI-DD-FIRMWARE-LDT-1195-2: comment by Vendor - TEL - Arpita Srivastava "I tried the suggested change and tested. But it..." Mon, 06 Apr 2026 10:41:32 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2/#c28231 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2/#c28231 Vendor - TEL - Arpita Srivastava replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-1195-2

I tried the suggested change and tested. But it did not provide the expected results.
If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without the actual request being processed and the off request was never executed.

]]> LEAHI-DD-FIRMWARE-LDT-2004-13: started by Dara Navaei Wed, 25 Mar 2026 04:01:46 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-13 ]]> LEAHI-DD-FIRMWARE-LDT-2004-11: started by Dara Navaei Thu, 19 Mar 2026 15:47:06 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-11 ]]> LEAHI-DD-FIRMWARE-LDT-1195-2: comment by Sean Nash "Remove blank line and comment saying we're not ..." Wed, 11 Mar 2026 14:07:39 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2/#c27881 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2/#c27881 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-1195-2

Remove blank line and comment saying we're not doing anything (because now we're doing something).

]]> LEAHI-DD-FIRMWARE-LDT-1195-2: comment by Sean Nash "isBalChamberSwitchingOffRequested is an output." Wed, 11 Mar 2026 14:05:24 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2/#c27880 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2/#c27880 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-1195-2

isBalChamberSwitchingOffRequested is an output.

]]> LEAHI-DD-FIRMWARE-LDT-1195-2: comment by Sean Nash "Should we set the other switch to FALSE, just i..." Wed, 11 Mar 2026 14:03:35 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2/#c27879 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2/#c27879 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-1195-2

Should we set the other switch to FALSE, just in case?

]]> LEAHI-DD-FIRMWARE-LDT-1195-2: started by Dara Navaei Wed, 25 Feb 2026 15:31:28 -0800 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-1195-2 ]]> DD-LEAH-236-1: closed by Vinayakam Mani Fri, 15 Nov 2024 13:04:13 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-236-1 https://devapps.diality.us/cru/DD-LEAH-236-1 Vinayakam Mani Closed DD-LEAH-236-1 ]]> DD-LEAH-236-1: reviewers finished Fri, 15 Nov 2024 11:27:55 -0800 https://devapps.diality.us/cru/DD-LEAH-236-1 https://devapps.diality.us/cru/DD-LEAH-236-1 Dara Navaei and Sean Nash finished reviewing DD-LEAH-236-1 DD-LEAH-236_FW DD Operation Modes ]]> DD-LEAH-236-1: comment by Vinayakam Mani "Done." Thu, 14 Nov 2024 15:39:13 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-236-1/#c20929 https://devapps.diality.us/cru/DD-LEAH-236-1/#c20929 Vinayakam Mani replied to Sean Nash in DD-LEAH-236-1

Done.

]]> DD-LEAH-236-1: comment by Vinayakam Mani "Done." Thu, 14 Nov 2024 15:39:05 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-236-1/#c20928 https://devapps.diality.us/cru/DD-LEAH-236-1/#c20928 Vinayakam Mani replied to Sean Nash in DD-LEAH-236-1

Done.

]]> DD-LEAH-236-1: comment by Vinayakam Mani "Done." Thu, 14 Nov 2024 15:38:50 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-236-1/#c20927 https://devapps.diality.us/cru/DD-LEAH-236-1/#c20927 Vinayakam Mani replied to Sean Nash in DD-LEAH-236-1

Done.

]]> DD-LEAH-236-1: comment by Vinayakam Mani "Done." Thu, 14 Nov 2024 15:38:40 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-236-1/#c20926 https://devapps.diality.us/cru/DD-LEAH-236-1/#c20926 Vinayakam Mani replied to Sean Nash in DD-LEAH-236-1

Done.

]]> DD-LEAH-236-1: comment by Vinayakam Mani "Done." Thu, 14 Nov 2024 15:38:34 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-236-1/#c20925 https://devapps.diality.us/cru/DD-LEAH-236-1/#c20925 Vinayakam Mani replied to Sean Nash in DD-LEAH-236-1

Done.

]]> DD-LEAH-236-1: comment by Vinayakam Mani "Done." Thu, 14 Nov 2024 15:38:23 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-236-1/#c20924 https://devapps.diality.us/cru/DD-LEAH-236-1/#c20924 Vinayakam Mani replied to Sean Nash in DD-LEAH-236-1

Done.

]]> DD-LEAH-236-1: comment by Vinayakam Mani "Done." Thu, 14 Nov 2024 15:37:58 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-236-1/#c20923 https://devapps.diality.us/cru/DD-LEAH-236-1/#c20923 Vinayakam Mani replied to Sean Nash in DD-LEAH-236-1

Done.

]]> DD-LEAH-236-1: comment by Vinayakam Mani "Done." Thu, 14 Nov 2024 15:36:56 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-236-1/#c20922 https://devapps.diality.us/cru/DD-LEAH-236-1/#c20922 Vinayakam Mani replied to Sean Nash in DD-LEAH-236-1

Done.

]]> DD-LEAH-236-1: comment by Vinayakam Mani "Done." Thu, 14 Nov 2024 15:36:43 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-236-1/#c20921 https://devapps.diality.us/cru/DD-LEAH-236-1/#c20921 Vinayakam Mani replied to Sean Nash in DD-LEAH-236-1

Done.

]]> DD-LEAH-236-1: comment by Vinayakam Mani "Done." Thu, 14 Nov 2024 15:36:23 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-236-1/#c20920 https://devapps.diality.us/cru/DD-LEAH-236-1/#c20920 Vinayakam Mani replied to Sean Nash in DD-LEAH-236-1

Done.

]]> DD-LEAH-236-1: comment by Sean Nash "Change "&&" to "||". Also, I think we need ano..." Thu, 14 Nov 2024 09:13:19 -0800 Sean Nash https://devapps.diality.us/cru/DD-LEAH-236-1/#c20918 https://devapps.diality.us/cru/DD-LEAH-236-1/#c20918 Sean Nash commented on DD-LEAH-236-1

Change "&&" to "||". Also, I think we need another condition added here because I don't think we should be setting all of these values if things above aren't right.

]]> DD-LEAH-236-1: comment by Sean Nash "I don't think the "|=" is accomplishing anythin..." Thu, 14 Nov 2024 09:15:10 -0800 Sean Nash https://devapps.diality.us/cru/DD-LEAH-236-1/#c20919 https://devapps.diality.us/cru/DD-LEAH-236-1/#c20919 Sean Nash commented on DD-LEAH-236-1

I don't think the "|=" is accomplishing anything useful here - this is effectively setting result to TRUE in all cases.
And I don't think we should be setting result to TRUE here necessarily. If we set result to FALSE above, it should stay FALSE.

]]> DD-LEAH-236-1: comment by Sean Nash "ModeGenDialysate should move up before ModeInit..." Thu, 14 Nov 2024 09:12:30 -0800 Sean Nash https://devapps.diality.us/cru/DD-LEAH-236-1/#c20917 https://devapps.diality.us/cru/DD-LEAH-236-1/#c20917 Sean Nash commented on DD-LEAH-236-1

ModeGenDialysate should move up before ModeInitPOST to be in alphabetical order.

]]> DD-LEAH-236-1: comment by Sean Nash "Indent function name more to align like others." Thu, 14 Nov 2024 09:11:13 -0800 Sean Nash https://devapps.diality.us/cru/DD-LEAH-236-1/#c20916 https://devapps.diality.us/cru/DD-LEAH-236-1/#c20916 Sean Nash commented on DD-LEAH-236-1

Indent function name more to align like others.

]]> DD-LEAH-236-1: comment by Sean Nash "Fix "Dialysatey" (remove y). And I think "Gend..." Thu, 14 Nov 2024 09:00:13 -0800 Sean Nash https://devapps.diality.us/cru/DD-LEAH-236-1/#c20911 https://devapps.diality.us/cru/DD-LEAH-236-1/#c20911 Sean Nash commented on DD-LEAH-236-1

Fix "Dialysatey" (remove y). And I think "Gend" should be GenD" in all of these function names.

]]>