instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

lower? and change the D98 level sensor comment as well.

Remove empty line

Space before LVL_STATE_LOW

space inside array index.

Space inside parenthesis.

Change this to LEVEL_T enum.

Is this macro still being used? if not, delete it.

· /firmware/App/Controllers/BalancingChamber.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/Heaters.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/Heaters.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/Ultrafiltration.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/DDCommon.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Drivers/TemperatureSensors.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Temperature.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Temperature.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff

]]> Tue, 14 Apr 2026 19:47:34 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 Sean Nash and Vendor - TEL - Sameer Poyil finished reviewing LEAHI-DD-FIRMWARE-LDT-3352-1 LEAHI-DD-FIRMWARE-LDT-3352_DD - revisit D3 level control logic ]]> Tue, 14 Apr 2026 16:39:54 -0700 Vinayakam Mani https://devapps.diality.us/changelog/dd-firmware?cs=4cdcb589ad34efa472c94180e6de938132cbc89b https://devapps.diality.us/changelog/dd-firmware?cs=4cdcb589ad34efa472c94180e6de938132cbc89b Vinayakam Mani committed 4cdcb58 on branch LDT-2004-dialysate-composition-dosing-control--dd, LDT-3218-update-iofp-permeate-target-flow-CLEAN and 12 more in dd-firmware LDT-3352 resolving merge issues

· /firmware/App/Controllers/BalancingChamber.c	(-78, +428)	| History	| Source	| Diff
· /firmware/App/Controllers/Heaters.c	(-7, +14)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.c	(-1, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/Ultrafiltration.c	(-14, +29)	| History	| Source	| Diff
· /firmware/App/DDCommon.h	(-6, +3)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-16, +40)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.h	(-2, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/Temperature.c	(-28, +26)	| History	| Source	| Diff
· /firmware/App/Monitors/Temperature.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-4, +5)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-25, +20)	| History	| Source	| Diff

]]> Tue, 14 Apr 2026 09:32:25 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=b04db69f541f245e543df343257bcbdb73fbbc3d https://devapps.diality.us/changelog/dd-firmware?cs=b04db69f541f245e543df343257bcbdb73fbbc3d Dara Navaei committed b04db69 on branch LDT-2004-dialysate-composition-dosing-control--dd, LDT-3218-update-iofp-permeate-target-flow-CLEAN and 12 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/Heaters.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/DDCommon.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivitySensors.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivitySensors.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivityTeensy.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivityTeensy.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/Temperature.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Interrupts.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff

]]> Tue, 14 Apr 2026 09:24:59 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1 Michael Garthwaite Closed LEAHI-DD-FIRMWARE-LDT-2008-1 ]]> Tue, 14 Apr 2026 09:24:17 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1 Vendor - TEL - Sameer Poyil and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-2008-1 LEAHI-DD-FIRMWARE-LDT-2008_Dialysate Composition - DD - 04: DEV - Feature Implementation ]]> Tue, 14 Apr 2026 08:39:30 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28310 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28310 Michael Garthwaite replied to Vendor - TEL - Sameer Poyil in LEAHI-DD-FIRMWARE-LDT-2008-1

per formatting for the test support function header. it is format used across many files

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

both drivers need to be initialized since we dont know what Beta unit we are running until the FW receives test configuration(s).

Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.