Fisheye on dd-firmware/firmware/App/Modes/FPModes/StateFlushPermeate.c

LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Sean Nash "Declare local variables at top of scope."

Sean Nash — Sun, 26 Apr 2026 12:36:19 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Declare local variables at top of scope.

LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Sean Nash "Add space between ( and ?"

Sean Nash — Sun, 26 Apr 2026 12:34:47 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Add space between ( and ?

LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Sean Nash "Remove blank line."

Sean Nash — Sun, 26 Apr 2026 12:33:06 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Sean Nash "Why redeclare result?"

Sean Nash — Sun, 26 Apr 2026 12:31:45 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Why redeclare result?

LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Sean Nash "Remove blank line."

Sean Nash — Sun, 26 Apr 2026 12:31:20 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Sean Nash "Why are you redeclaring result? This assignmen..."

Sean Nash — Sun, 26 Apr 2026 12:30:57 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Why are you redeclaring result? This assignment will not survive outside of the if statement.

LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Sean Nash "Remove blank line."

Sean Nash — Sun, 26 Apr 2026 12:30:04 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Sean Nash "Remove blank line."

Sean Nash — Sun, 26 Apr 2026 12:29:45 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-3978-1: reviewers resumed

Fri, 24 Apr 2026 22:17:00 -0700

Vinayakam Mani resumed reviewing LEAHI-DD-FIRMWARE-LDT-3978-1

LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid

LEAHI-DD-FIRMWARE-LDT-3978-1: reviewers joined LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conduc...

Thu, 23 Apr 2026 14:59:17 -0700

Vinayakam Mani joined LEAHI-DD-FIRMWARE-LDT-3978-1

LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid

LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "instead of 0, we can use the level Enum 'LVL_ST..."

Vinayakam Mani — Thu, 23 Apr 2026 14:56:16 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "lower? and change the D98 level sensor comment ..."

Vinayakam Mani — Thu, 23 Apr 2026 14:49:10 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

lower? and change the D98 level sensor comment as well.

LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Remove empty line"

Vinayakam Mani — Thu, 23 Apr 2026 14:47:11 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Remove empty line

LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Space before LVL_STATE_LOW"

Vinayakam Mani — Thu, 23 Apr 2026 14:45:56 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Space before LVL_STATE_LOW

LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "space inside array index."

Vinayakam Mani — Thu, 23 Apr 2026 14:43:35 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

space inside array index.

LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Space inside parenthesis."

Vinayakam Mani — Thu, 23 Apr 2026 14:41:03 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Space inside parenthesis.

LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Change this to LEVEL_T enum."

Vinayakam Mani — Thu, 23 Apr 2026 14:39:55 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Change this to LEVEL_T enum.

LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Is this macro still being used? if not, delete ..."

Vinayakam Mani — Thu, 23 Apr 2026 14:38:55 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Is this macro still being used? if not, delete it.

LEAHI-DD-FIRMWARE-LDT-3978-1: started by Dara Navaei

Dara Navaei — Thu, 23 Apr 2026 07:47:26 -0700

Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3978-1

LEAHI-DD-FIRMWARE-LDT-2004-13: started by Dara Navaei

Dara Navaei — Wed, 25 Mar 2026 04:01:46 -0700

Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-13

LEAHI-DD-FIRMWARE-LDT-2004-11: started by Dara Navaei

Dara Navaei — Thu, 19 Mar 2026 15:47:06 -0700

Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-11

dd-firmware (LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test-3-30-2026): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 29 Jan 2026 14:45:12 -0800

Dara Navaei committed 973f790 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 54 more in dd-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/FPModes/ModeGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPModes/StateFlushPermeate.c	(-1, +1)	\| History	\| Source	\| Diff

LEAHI-DD-FIRMWARE-LDT-3218-1: closed by Raghu Kallala

Raghu Kallala — Thu, 29 Jan 2026 14:43:22 -0800

Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-3218-1

LEAHI-DD-FIRMWARE-LDT-3218-1: reviewers finished

Thu, 29 Jan 2026 14:43:00 -0800

Michael Garthwaite and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3218-1

LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)

LEAHI-DD-FIRMWARE-LDT-3218-1: reviewers added to LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate ta...

Thu, 29 Jan 2026 14:34:19 -0800

Raghu Kallala added Michael Garthwaite to LEAHI-DD-FIRMWARE-LDT-3218-1

LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)

LEAHI-DD-FIRMWARE-LDT-3218-1: reviewers left LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate ta...

Thu, 29 Jan 2026 14:34:19 -0800

Raghu Kallala left LEAHI-DD-FIRMWARE-LDT-3218-1

LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)

LEAHI-DD-FIRMWARE-LDT-3218-1: started by Dara Navaei

Dara Navaei — Thu, 29 Jan 2026 14:31:28 -0800

Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3218-1

dd-firmware (LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test-3-30-2026): LDT-3218 updated RO target flow from 750 to 800

Raghu Kallala — Thu, 29 Jan 2026 14:13:49 -0800

Raghu Kallala committed dfa0c83 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 55 more in dd-firmware

LDT-3218 updated RO target flow from 750 to 800

· /firmware/App/Modes/FPModes/ModeGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPModes/StateFlushPermeate.c	(-1, +1)	\| History	\| Source	\| Diff

dd-firmware (LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test-3-30-2026): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 21 Jan 2026 10:13:45 -0800

Dara Navaei committed f1de042 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 59 more in dd-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ROPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPModes/StateFlushPermeate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/WaterQualityMonitor.c	(-1, +1)	\| History	\| Source	\| Diff

LEAHI-DD-FIRMWARE-LDT-1925-1: closed by Raghu Kallala

Raghu Kallala — Wed, 21 Jan 2026 10:10:21 -0800

Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-1925-1