reverted back

This code is removed and not required

· /firmware/App/Controllers/AirTrap.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Bubbles.c	(-2, +2)	| History	| Source	| Diff

]]> Fri, 13 Mar 2026 15:21:43 -0700 Vendor - TEL - Praneeth Bunne https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1 Vendor - TEL - Praneeth Bunne Closed LEAHI-TD-FIRMWARE-LDT-3600-1 ]]> Fri, 13 Mar 2026 14:47:47 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1 Vinayakam Mani , Vendor - TEL - Jashwant Gantyada and Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-3600-1 LEAHI-TD-FIRMWARE-LDT-3600_Request for TD Test Config for Testing without Tubing Set on TD ]]> Fri, 13 Mar 2026 14:41:33 -0700 Vendor - TEL - Praneeth Bunne https://devapps.diality.us/changelog/td-firmware?cs=ec17f9086547f77425601122ded579bbc0d785c5 https://devapps.diality.us/changelog/td-firmware?cs=ec17f9086547f77425601122ded579bbc0d785c5 Vendor - TEL - Praneeth Bunne committed ec17f90 on branch LDT-1415-pressures-monitoring-td-baro, LDT-1886-blood-set-auto-load-and-auto-ej and 14 more in td-firmware Remove spaces after if/else if.

· /firmware/App/Controllers/AirTrap.c

(-3, +0)

| History

| Source

| Diff

]]> Fri, 13 Mar 2026 14:23:39 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1 Sean Nash added Vendor - TEL - Jashwant Gantyada and Vinayakam Mani to LEAHI-TD-FIRMWARE-LDT-3600-1 LEAHI-TD-FIRMWARE-LDT-3600_Request for TD Test Config for Testing without Tubing Set on TD ]]> Fri, 13 Mar 2026 13:45:19 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1/#c28029 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1/#c28029 Vinayakam Mani commented on LEAHI-TD-FIRMWARE-LDT-3600-1

Can we remove the empty lines after if / else if blocks in this function?

· /firmware/App/Controllers/AirTrap.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/Bubbles.c	(-1, +1)	| History	| Source	| Diff

]]> Wed, 11 Mar 2026 17:40:08 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9/#c27899 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9/#c27899 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-9

You are calling setAirPumpState in if and else. Consider just calling once after the if/else.

· /firmware/App/Controllers/AirTrap.c	(-0, +7)	| History	| Source	| Diff
· /firmware/App/Monitors/Bubbles.c	(-1, +6)	| History	| Source	| Diff

]]> Wed, 11 Mar 2026 17:30:35 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9/#c27897 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9/#c27897 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-9

Add space between if and (

Fixed

Comment to right no longer makes sense.

Should this event be TD_EVENT_AIR_TRAP_FILL?

· /firmware/App/Controllers/AirPump.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/AirPump.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/AirTrap.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/AirTrap.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/GLXferPump.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/GLXferPump.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/FpgaTD.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/FpgaTD.h	(-2, +2)	| History	| Source	| Diff

]]> Mon, 02 Mar 2026 20:46:01 -0800 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8 Sean Nash resumed reviewing LEAHI-TD-FIRMWARE-LDT-1903-8 LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation ]]> Mon, 02 Mar 2026 11:54:51 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27695 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27695 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

fixed in latest code

implemented

fixed

· /firmware/App/Controllers/AirTrap.c

(-10, +1)

| History

| Source

| Diff

]]> Mon, 02 Mar 2026 11:41:04 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/td-firmware?cs=c70a43525f1db35c45d79d4e1b2f87f7ea84e579 https://devapps.diality.us/changelog/td-firmware?cs=c70a43525f1db35c45d79d4e1b2f87f7ea84e579 Vendor - TEL - Sameer Poyil committed c70a435 on branch LDT-1394-blood-flow-rate-h4-rotor-count, LDT-1415-pressures-monitoring-td-baro and 21 more in td-firmware LDT-1903 Air Trap adding duty cycle out of range software fault alarm

· /firmware/App/Controllers/AirPump.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/AirTrap.c	(-2, +5)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-0, +1)	| History	| Source	| Diff

]]> Mon, 02 Mar 2026 09:52:52 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27674 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27674 Sean Nash replied to Vendor - TEL - Sameer Poyil in LEAHI-TD-FIRMWARE-LDT-1903-8

I think this would be a TD s/w fault (alarm already define). Just need a new TD s/w fault ID in AlarmMgmtSWFaults.h.

This structure doesn't seem necessary - it's just a middle man. Why not just pass the #defines directly into the quadratic macro?