Fisheye on leahi-fwcommon/MessageSupport.c https://devapps.diality.us/changelog/~br%3DLDT-3722-non-volatile-memory/leahi-fwcommon/MessageSupport.c Recent activity in "leahi-fwcommon" under directory /MessageSupport.c LEAHI-DD-FIRMWARE-LDT-2004-13: started by Dara Navaei Wed, 25 Mar 2026 04:01:46 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-13 ]]> LEAHI-DD-FIRMWARE-LDT-2004-11: started by Dara Navaei Thu, 19 Mar 2026 15:47:06 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-11 ]]> LEAHI-DD-FIRMWARE-LDT-2004-10: started by Dara Navaei Thu, 19 Mar 2026 15:47:05 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-10 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-10 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-10 ]]> LEAHI-RO-FIRMWARE-LDT-1242-1: closed by Michael Garthwaite Wed, 03 Sep 2025 08:52:47 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 Michael Garthwaite Closed LEAHI-RO-FIRMWARE-LDT-1242-1 ]]> LEAHI-RO-FIRMWARE-LDT-1242-1: started by Dara Navaei Tue, 02 Sep 2025 10:03:14 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1242-1 Dara Navaei started review LEAHI-RO-FIRMWARE-LDT-1242-1 ]]> TD-LEAH-60-1: closed by Sean Nash Mon, 17 Mar 2025 10:21:09 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-60-1 https://devapps.diality.us/cru/TD-LEAH-60-1 Sean Nash Closed TD-LEAH-60-1 ]]> TD-LEAH-60-1: reviewers finished Mon, 17 Mar 2025 10:02:05 -0700 https://devapps.diality.us/cru/TD-LEAH-60-1 https://devapps.diality.us/cru/TD-LEAH-60-1 Michael Garthwaite and Vinayakam Mani finished reviewing TD-LEAH-60-1 TD-LEAH-60_FW TD Valves Controller Monitor ]]> TD-LEAH-60-1: comment by Vinayakam Mani "RESOLVED IN CODE WALKTHROUGH." Mon, 17 Mar 2025 09:40:48 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-60-1/#c21753 https://devapps.diality.us/cru/TD-LEAH-60-1/#c21753 Vinayakam Mani replied to Sean Nash in TD-LEAH-60-1

RESOLVED IN CODE WALKTHROUGH.

]]> TD-LEAH-60-1: comment by Vinayakam Mani "RESOLVED IN CODE WALKTHROUGH." Mon, 17 Mar 2025 09:40:24 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-60-1/#c21752 https://devapps.diality.us/cru/TD-LEAH-60-1/#c21752 Vinayakam Mani replied to Sean Nash in TD-LEAH-60-1

RESOLVED IN CODE WALKTHROUGH.

]]> TD-LEAH-60-1: comment by Sean Nash "Added." Mon, 17 Mar 2025 09:35:42 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-60-1/#c21751 https://devapps.diality.us/cru/TD-LEAH-60-1/#c21751 Sean Nash replied to Vinayakam Mani in TD-LEAH-60-1

Added.

]]> TD-LEAH-60-1: comment by Sean Nash "Fixed." Mon, 17 Mar 2025 09:35:32 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-60-1/#c21750 https://devapps.diality.us/cru/TD-LEAH-60-1/#c21750 Sean Nash replied to Vinayakam Mani in TD-LEAH-60-1

Fixed.

]]> TD-LEAH-60-1: comment by Vinayakam Mani "Will you be adding override message later?" Sun, 16 Mar 2025 21:53:23 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-60-1/#c21749 https://devapps.diality.us/cru/TD-LEAH-60-1/#c21749 Vinayakam Mani commented on TD-LEAH-60-1

Will you be adding override message later?

]]> TD-LEAH-60-1: comment by Vinayakam Mani "DG to DD" Sun, 16 Mar 2025 21:51:23 -0700 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-60-1/#c21748 https://devapps.diality.us/cru/TD-LEAH-60-1/#c21748 Vinayakam Mani commented on TD-LEAH-60-1

DG to DD

]]> TD-LEAH-60-1: started by Dara Navaei Fri, 28 Feb 2025 09:45:15 -0800 Dara Navaei https://devapps.diality.us/cru/TD-LEAH-60-1 https://devapps.diality.us/cru/TD-LEAH-60-1 Dara Navaei started review TD-LEAH-60-1 ]]> DD-LEAH-210-5: closed by Vinayakam Mani Thu, 05 Sep 2024 12:01:47 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-210-5 https://devapps.diality.us/cru/DD-LEAH-210-5 Vinayakam Mani Closed DD-LEAH-210-5 ]]> TD-LEAH-32-4: closed by Sean Nash Thu, 05 Sep 2024 11:06:46 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-32-4 https://devapps.diality.us/cru/TD-LEAH-32-4 Sean Nash Closed TD-LEAH-32-4 ]]> TD-LEAH-32-4: reviewers finished Thu, 05 Sep 2024 09:10:30 -0700 https://devapps.diality.us/cru/TD-LEAH-32-4 https://devapps.diality.us/cru/TD-LEAH-32-4 Vinayakam Mani finished reviewing TD-LEAH-32-4 TD-LEAH-32_FW TD Fpga Interface ]]> TD-LEAH-32-4: reviewers finished Wed, 04 Sep 2024 22:06:23 -0700 https://devapps.diality.us/cru/TD-LEAH-32-4 https://devapps.diality.us/cru/TD-LEAH-32-4 Dara Navaei finished reviewing TD-LEAH-32-4 TD-LEAH-32_FW TD Fpga Interface ]]> TD-LEAH-32-4: comment by Dara Navaei "I can update the numbers." Wed, 04 Sep 2024 22:06:00 -0700 Dara Navaei https://devapps.diality.us/cru/TD-LEAH-32-4/#c20198 https://devapps.diality.us/cru/TD-LEAH-32-4/#c20198 Dara Navaei replied to Sean Nash in TD-LEAH-32-4

I can update the numbers.

]]> TD-LEAH-32-4: comment by Sean Nash "But what is 0x3000?" Wed, 04 Sep 2024 21:45:01 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-32-4/#c20197 https://devapps.diality.us/cru/TD-LEAH-32-4/#c20197 Sean Nash replied to Dara Navaei in TD-LEAH-32-4

But what is 0x3000?

]]> TD-LEAH-32-4: comment by Sean Nash "Some day. I don't even know what it is and if ..." Wed, 04 Sep 2024 21:42:29 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-32-4/#c20196 https://devapps.diality.us/cru/TD-LEAH-32-4/#c20196 Sean Nash replied to Dara Navaei in TD-LEAH-32-4

Some day. I don't even know what it is and if we even used it in Denali. For now, I want to close this out and merge to staging.

]]> DD-LEAH-210-5: reviewers finished Wed, 04 Sep 2024 16:02:21 -0700 https://devapps.diality.us/cru/DD-LEAH-210-5 https://devapps.diality.us/cru/DD-LEAH-210-5 Michael Garthwaite , Dara Navaei and Sean Nash finished reviewing DD-LEAH-210-5 DD-LEAH-210_FW DD Fpga Interface ]]> DD-LEAH-210-5: comment by Sean Nash "RO and DD will be via FPGA, but otherwise shoul..." Wed, 04 Sep 2024 12:53:38 -0700 Sean Nash https://devapps.diality.us/cru/DD-LEAH-210-5/#c20194 https://devapps.diality.us/cru/DD-LEAH-210-5/#c20194 Sean Nash commented on DD-LEAH-210-5

RO and DD will be via FPGA, but otherwise should be handled the same (e.g. same pins).
Let's consider this later.

]]> TD-LEAH-32-4: comment by Dara Navaei "Do you think we need it? So we should ask Noe t..." Wed, 04 Sep 2024 12:31:36 -0700 Dara Navaei https://devapps.diality.us/cru/TD-LEAH-32-4/#c20189 https://devapps.diality.us/cru/TD-LEAH-32-4/#c20189 Dara Navaei replied to Sean Nash in TD-LEAH-32-4

Do you think we need it? So we should ask Noe to add it?

]]> TD-LEAH-32-4: comment by Sean Nash "Noe didn't include it." Wed, 04 Sep 2024 12:30:31 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-32-4/#c20188 https://devapps.diality.us/cru/TD-LEAH-32-4/#c20188 Sean Nash replied to Dara Navaei in TD-LEAH-32-4

Noe didn't include it.

]]> TD-LEAH-32-4: comment by Dara Navaei "This function is used to calculate the baro sen..." Wed, 04 Sep 2024 12:29:49 -0700 Dara Navaei https://devapps.diality.us/cru/TD-LEAH-32-4/#c20187 https://devapps.diality.us/cru/TD-LEAH-32-4/#c20187 Dara Navaei replied to Sean Nash in TD-LEAH-32-4

This function is used to calculate the baro sensor's CRC.

]]> TD-LEAH-32-4: comment by Sean Nash "I kept these out of common because it's doing s..." Wed, 04 Sep 2024 12:29:19 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-32-4/#c20186 https://devapps.diality.us/cru/TD-LEAH-32-4/#c20186 Sean Nash replied to Dara Navaei in TD-LEAH-32-4

I kept these out of common because it's doing some specific things like broadcasting alarm trigger message.

]]> TD-LEAH-32-4: comment by Sean Nash "Removed." Wed, 04 Sep 2024 12:28:01 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-32-4/#c20185 https://devapps.diality.us/cru/TD-LEAH-32-4/#c20185 Sean Nash replied to Dara Navaei in TD-LEAH-32-4

Removed.

]]> TD-LEAH-32-4: comment by Sean Nash "Details are in the header file where the group ..." Wed, 04 Sep 2024 12:25:31 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-32-4/#c20183 https://devapps.diality.us/cru/TD-LEAH-32-4/#c20183 Sean Nash replied to Dara Navaei in TD-LEAH-32-4

Details are in the header file where the group is defined. This is just saying that all of the code below goes into this group.

]]> TD-LEAH-32-4: comment by Sean Nash "This one masks off lowest nibble. I will make ..." Wed, 04 Sep 2024 12:22:18 -0700 Sean Nash https://devapps.diality.us/cru/TD-LEAH-32-4/#c20182 https://devapps.diality.us/cru/TD-LEAH-32-4/#c20182 Sean Nash replied to Dara Navaei in TD-LEAH-32-4

This one masks off lowest nibble. I will make a #define for it.

]]>