DD-LEAH-210_FW DD Fpga Interface

Activity

DD-LEAH-210-5 237

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 8h 51m 116 Ok. Will check and update in next versions.
    Reviewer - Complete 4h 2m 121 Add one for RO too.
    Reviewer - Complete 8m    
    Reviewer - Complete 20m    
    jpaguio  (deleted user)
    Reviewer - 0% reviewed      
    Total   13h 22m 237  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /firmware/App/Controllers/Valves.c Added 24
    /firmware/App/Controllers/Valves.h Added 6
    Open in IDE #permalink
    /firmware/App/Drivers/GPIO.c Added
    Open in IDE #permalink
    /firmware/App/Drivers/GPIO.h Added
    Open in IDE #permalink
    /firmware/App/Drivers/InternalADC.c Changed 2
    /firmware/App/Drivers/InternalADC.h Changed 2
    /firmware/App/Drivers/PAL.c Changed 2
    Open in IDE #permalink
    /firmware/App/Drivers/PAL.h Changed
    Open in IDE #permalink
    /firmware/App/Drivers/SafetyShutdown.c Changed
    Open in IDE #permalink
    /firmware/App/Drivers/SafetyShutdown.h Changed 2
    Open in IDE #permalink
    /firmware/App/Modes/ModeFault.c Changed 6
    Open in IDE #permalink
    /firmware/App/Modes/ModeFault.h Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModeInitPOST.c Changed 32
    Open in IDE #permalink
    /firmware/App/Modes/ModeInitPOST.h Changed
    Open in IDE #permalink
    /firmware/App/Modes/ModeService.c Changed 4
    Open in IDE #permalink
    /firmware/App/Modes/ModeService.h Changed 2
    Open in IDE #permalink
    /firmware/App/Modes/ModeStandby.c Changed 8
    Open in IDE #permalink
    /firmware/App/Modes/ModeStandby.h Changed 2
    Open in IDE #permalink
    /firmware/App/Modes/OperationModes.c Changed 20
    Open in IDE #permalink
    /firmware/App/Modes/OperationModes.h Changed 2
    Open in IDE #permalink
    /firmware/App/Services/AlarmMgmtDD.c Changed 18
    Open in IDE #permalink
    /firmware/App/Services/AlarmMgmtDD.h Changed 6
    Open in IDE #permalink
    /firmware/App/Services/AlarmMgmtSWFaults.h Changed 6
    /firmware/App/Services/CommBuffers.c Changed 2
    /firmware/App/Services/CommBuffers.h Changed
    /firmware/App/Services/FPGADD.c Deleted
    Open in IDE #permalink
    /firmware/App/Services/FPGADD.h Deleted
    Open in IDE #permalink
    /firmware/App/Services/FpgaDD.c Added 28
    /firmware/App/Services/FpgaDD.h Added 7
    /firmware/App/Services/Interrupts.c Changed 6
    Open in IDE #permalink
    /firmware/App/Services/Interrupts.h Changed
    Open in IDE #permalink
    /firmware/App/Services/Messaging.c Changed 2
    Open in IDE #permalink
    /firmware/App/Services/Messaging.h Changed
    Open in IDE #permalink
    /firmware/App/Services/MsgQueues.c Changed 2
    Open in IDE #permalink
    /firmware/App/Services/MsgQueues.h Changed
    Open in IDE #permalink
    /firmware/App/Services/SystemCommDD.c Changed 13
    Open in IDE #permalink
    /firmware/App/Services/SystemCommDD.h Changed
    Open in IDE #permalink
    /firmware/App/Tasks/TaskBG.c Changed
    Open in IDE #permalink
    /firmware/App/Tasks/TaskBG.h Changed
    Open in IDE #permalink
    /firmware/App/Tasks/TaskGeneral.c Changed 2
    /firmware/App/Tasks/TaskGeneral.h Changed
    Open in IDE #permalink
    /firmware/App/Tasks/TaskPriority.c Changed
    /firmware/App/Tasks/TaskPriority.h Changed
    Open in IDE #permalink
    /firmware/App/Tasks/TaskTimer.c Changed
    Open in IDE #permalink
    /firmware/App/Tasks/TaskTimer.h Changed
    Open in IDE #permalink
    /firmware/App/DDCommon.h Changed 2
    Open in IDE #permalink
    /firmware/source/sys_main.c Changed 9
    /AlarmDefs.h Changed
    /DDDefs.h Changed 16
    Open in IDE #permalink
    /MsgDefs.h Changed 2
    /FPGA.c Changed
    /MessageSupport.c Changed
    Open in IDE #permalink
    /SystemComm.c Changed
    /WatchdogMgmt.c Changed 2

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time