Fisheye on td-firmware/firmware/App/Controllers/AirTrap.c

LEAHI-TD-FIRMWARE-LDT-1903-10: started by Dara Navaei

Dara Navaei — Wed, 25 Mar 2026 06:46:59 -0700

Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-1903-10

LEAHI-TD-FIRMWARE-LDT-1903-9: closed by Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil — Mon, 23 Mar 2026 17:37:19 -0700

Vendor - TEL - Sameer Poyil Closed LEAHI-TD-FIRMWARE-LDT-1903-9

td-firmware (LDT-2240-disposable-tube-set-self-test): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 23 Mar 2026 17:36:06 -0700

Dara Navaei committed 7f3bf72 on branch LDT-1415-pressures-monitoring-td-baro, LDT-1886-blood-set-auto-load-and-auto-ej and 7 more in td-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirTrap.c

(-2, +2)

| History

| Source

| Diff

td-firmware (LDT-2240-disposable-tube-set-self-test): Merge branch LDT-1903-air-trap-level-control-delay-adjust-after-fill-fix---td---0 into staging

Vendor - TEL - Sameer Poyil — Mon, 23 Mar 2026 17:31:49 -0700

Vendor - TEL - Sameer Poyil committed 5b25cf8 on branch LDT-1415-pressures-monitoring-td-baro, LDT-1886-blood-set-auto-load-and-auto-ej and 7 more in td-firmware

Merge branch LDT-1903-air-trap-level-control-delay-adjust-after-fill-fix---td---0 into staging

· /firmware/App/Controllers/AirTrap.c

(-8, +34)

| History

| Source

| Diff

LEAHI-TD-FIRMWARE-LDT-1903-9: reviewers finished

Mon, 23 Mar 2026 10:30:28 -0700

Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-1903-9

LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation

td-firmware (LDT-2240-disposable-tube-set-self-test): LDT-1903 Air Trap reverting to original valve state

Vendor - TEL - Sameer Poyil — Mon, 23 Mar 2026 10:21:40 -0700

Vendor - TEL - Sameer Poyil committed b61fbe4 on branch LDT-1415-pressures-monitoring-td-baro, LDT-1886-blood-set-auto-load-and-auto-ej and 8 more in td-firmware

LDT-1903 Air Trap reverting to original valve state

· /firmware/App/Controllers/AirTrap.c

(-1, +1)

| History

| Source

| Diff

LEAHI-TD-FIRMWARE-LDT-1903-9: comment by Vendor - TEL - Sameer Poyil "reverted back"

Vendor - TEL - Sameer Poyil — Tue, 17 Mar 2026 23:05:22 -0700

Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-9

reverted back

LEAHI-TD-FIRMWARE-LDT-1903-9: comment by Vendor - TEL - Sameer Poyil "This code is removed and not required"

Vendor - TEL - Sameer Poyil — Tue, 17 Mar 2026 23:05:09 -0700

Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-9

This code is removed and not required

td-firmware (LDT-2240-disposable-tube-set-self-test): LDT-1903 Air Trap Final implementation

Vendor - TEL - Sameer Poyil — Tue, 17 Mar 2026 23:03:35 -0700

Vendor - TEL - Sameer Poyil committed 8d31b20 on branch LDT-1415-pressures-monitoring-td-baro, LDT-1886-blood-set-auto-load-and-auto-ej and 8 more in td-firmware

LDT-1903 Air Trap Final implementation

· /firmware/App/Controllers/AirTrap.c

(-26, +31)

| History

| Source

| Diff

td-firmware (LDT-2240-disposable-tube-set-self-test): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 13 Mar 2026 16:43:39 -0700

Dara Navaei committed 1e5bc8d on branch LDT-1415-pressures-monitoring-td-baro, LDT-1886-blood-set-auto-load-and-auto-ej and 11 more in td-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirTrap.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Bubbles.c	(-2, +2)	\| History	\| Source	\| Diff

LEAHI-TD-FIRMWARE-LDT-3600-1: closed by Vendor - TEL - Praneeth Bunne

Vendor - TEL - Praneeth Bunne — Fri, 13 Mar 2026 15:21:43 -0700

Vendor - TEL - Praneeth Bunne Closed LEAHI-TD-FIRMWARE-LDT-3600-1

LEAHI-TD-FIRMWARE-LDT-3600-1: reviewers finished

Fri, 13 Mar 2026 14:47:47 -0700

Vinayakam Mani , Vendor - TEL - Jashwant Gantyada and Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-3600-1

LEAHI-TD-FIRMWARE-LDT-3600_Request for TD Test Config for Testing without Tubing Set on TD

td-firmware (LDT-2240-disposable-tube-set-self-test): Remove spaces after if/else if.

Vendor - TEL - Praneeth Bunne — Fri, 13 Mar 2026 14:41:33 -0700

Vendor - TEL - Praneeth Bunne committed ec17f90 on branch LDT-1415-pressures-monitoring-td-baro, LDT-1886-blood-set-auto-load-and-auto-ej and 12 more in td-firmware

Remove spaces after if/else if.

· /firmware/App/Controllers/AirTrap.c

(-3, +0)

| History

| Source

| Diff

LEAHI-TD-FIRMWARE-LDT-3600-1: reviewers added to LEAHI-TD-FIRMWARE-LDT-3600_Request for TD Test Con...

Fri, 13 Mar 2026 14:23:39 -0700

Sean Nash added Vendor - TEL - Jashwant Gantyada and Vinayakam Mani to LEAHI-TD-FIRMWARE-LDT-3600-1

LEAHI-TD-FIRMWARE-LDT-3600_Request for TD Test Config for Testing without Tubing Set on TD

LEAHI-TD-FIRMWARE-LDT-3600-1: comment by Vinayakam Mani "Can we remove the empty lines after if / else i..."

Vinayakam Mani — Fri, 13 Mar 2026 13:45:19 -0700

Vinayakam Mani commented on LEAHI-TD-FIRMWARE-LDT-3600-1

Can we remove the empty lines after if / else if blocks in this function?

td-firmware (LDT-2240-disposable-tube-set-self-test): Minor formatting and logic cleanup.

Vendor - TEL - Praneeth Bunne — Thu, 12 Mar 2026 13:47:28 -0700

Vendor - TEL - Praneeth Bunne committed 539f383 on branch LDT-1415-pressures-monitoring-td-baro, LDT-1886-blood-set-auto-load-and-auto-ej and 12 more in td-firmware

Minor formatting and logic cleanup.

· /firmware/App/Controllers/AirTrap.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Bubbles.c	(-1, +1)	\| History	\| Source	\| Diff

LEAHI-TD-FIRMWARE-LDT-1903-9: comment by Sean Nash "You are calling setAirPumpState in if and else...."

Sean Nash — Wed, 11 Mar 2026 17:40:08 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-9

You are calling setAirPumpState in if and else. Consider just calling once after the if/else.

td-firmware (LDT-2240-disposable-tube-set-self-test): LDT-3600: Skip air trap fill, lowerevents and venous bubble alarm when testing without tubing set.

Vendor - TEL - Praneeth Bunne — Wed, 11 Mar 2026 17:38:36 -0700

Vendor - TEL - Praneeth Bunne committed 17d7a28 on branch LDT-1415-pressures-monitoring-td-baro, LDT-1886-blood-set-auto-load-and-auto-ej and 12 more in td-firmware

LDT-3600: Skip air trap fill, lowerevents and venous bubble alarm when testing without tubing set.

· /firmware/App/Controllers/AirTrap.c	(-0, +7)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Bubbles.c	(-1, +6)	\| History	\| Source	\| Diff

LEAHI-TD-FIRMWARE-LDT-1903-9: comment by Sean Nash "Add space between if and ("

Sean Nash — Wed, 11 Mar 2026 17:30:35 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-9

Add space between if and (

LEAHI-TD-FIRMWARE-LDT-1903-9: comment by Vendor - TEL - Sameer Poyil "Fixed"

Vendor - TEL - Sameer Poyil — Wed, 11 Mar 2026 16:55:15 -0700

Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-9

Fixed

LEAHI-TD-FIRMWARE-LDT-3600-1: started by Dara Navaei

Dara Navaei — Wed, 11 Mar 2026 15:31:36 -0700

Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-3600-1

td-firmware (LDT-2240-disposable-tube-set-self-test): LDT-1903 Air Trap changing the first lowering event duty cycle

Vendor - TEL - Sameer Poyil — Wed, 11 Mar 2026 07:22:43 -0700

Vendor - TEL - Sameer Poyil committed 32763ee on branch LDT-1415-pressures-monitoring-td-baro, LDT-1886-blood-set-auto-load-and-auto-ej and 8 more in td-firmware

LDT-1903 Air Trap changing the first lowering event duty cycle

· /firmware/App/Controllers/AirTrap.c

(-4, +22)

| History

| Source

| Diff

LEAHI-TD-FIRMWARE-LDT-1903-9: comment by Sean Nash "Comment to right no longer makes sense."

Sean Nash — Tue, 10 Mar 2026 13:58:06 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-9

Comment to right no longer makes sense.

td-firmware (LDT-2240-disposable-tube-set-self-test): LDT-1907 IAr trap FW uses the stabilised H14 long filtered pressure right before the AP fill event

Vendor - TEL - Sameer Poyil — Mon, 09 Mar 2026 15:34:32 -0700

Vendor - TEL - Sameer Poyil committed ff9c1ff on branch LDT-1415-pressures-monitoring-td-baro, LDT-1886-blood-set-auto-load-and-auto-ej and 8 more in td-firmware

LDT-1907 IAr trap FW uses the stabilised H14 long filtered pressure right before the AP fill event

· /firmware/App/Controllers/AirTrap.c

(-1, +3)

| History

| Source

| Diff

td-firmware (LDT-2240-disposable-tube-set-self-test): LDT-1903 Air Trap Addressed the review comments

Vendor - TEL - Sameer Poyil — Mon, 09 Mar 2026 14:59:48 -0700

Vendor - TEL - Sameer Poyil committed 7398059 on branch LDT-1415-pressures-monitoring-td-baro, LDT-1886-blood-set-auto-load-and-auto-ej and 8 more in td-firmware

LDT-1903 Air Trap Addressed the review comments

· /firmware/App/Controllers/AirTrap.c

(-1, +1)

| History

| Source

| Diff

td-firmware (LDT-2240-disposable-tube-set-self-test): LDT-1903 Air Trap -both H13 and H20 valves are closed at the end of the fill during the 1 sec delay before the AP turns ...

Vendor - TEL - Sameer Poyil — Mon, 09 Mar 2026 14:40:39 -0700

Vendor - TEL - Sameer Poyil committed 25bc8be on branch LDT-1415-pressures-monitoring-td-baro, LDT-1886-blood-set-auto-load-and-auto-ej and 8 more in td-firmware

LDT-1903 Air Trap -both H13 and H20 valves are closed at the end of the fill during the 1 sec delay before the AP turns on to lower the level

· /firmware/App/Controllers/AirTrap.c

(-2, +2)

| History

| Source

| Diff

LEAHI-TD-FIRMWARE-LDT-1903-9: comment by Sean Nash "Should this event be TD_EVENT_AIR_TRAP_FILL?"

Sean Nash — Fri, 06 Mar 2026 14:26:19 -0800

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-9

Should this event be TD_EVENT_AIR_TRAP_FILL?

td-firmware (LDT-2240-disposable-tube-set-self-test): LDT-1903 Air Trap fixing the air pump turn on after 1 sec when raise event is completed

Vendor - TEL - Sameer Poyil — Fri, 06 Mar 2026 06:13:43 -0800

Vendor - TEL - Sameer Poyil committed 9d8c992 on branch LDT-1415-pressures-monitoring-td-baro, LDT-1886-blood-set-auto-load-and-auto-ej and 8 more in td-firmware

LDT-1903 Air Trap fixing the air pump turn on after 1 sec when raise event is completed

· /firmware/App/Controllers/AirTrap.c

(-1, +1)

| History

| Source

| Diff

LEAHI-TD-FIRMWARE-LDT-1903-8: closed by Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil — Wed, 04 Mar 2026 20:22:26 -0800

Vendor - TEL - Sameer Poyil Closed LEAHI-TD-FIRMWARE-LDT-1903-8

LEAHI-TD-FIRMWARE-LDT-1903-9: started by Dara Navaei

Dara Navaei — Wed, 04 Mar 2026 04:01:28 -0800

Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-1903-9