· /firmware/App/Controllers/AirPump.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/AirPump.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/AirTrap.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/AirTrap.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/AlarmAudio.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/AlarmAudio.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/AlarmLamp.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/AlarmLamp.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/BloodFlow.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/BloodFlow.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Ejector.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Ejector.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/BubbleDetector.c	(-1, +1)	| History	| Source	| Diff
… 82 more files in changeset.

]]> Fri, 12 Dec 2025 14:20:00 -0800 Dara Navaei https://devapps.diality.us/changelog/td-firmware?cs=b824ef4b479578c5aa702abd9147aef505a6fb04 https://devapps.diality.us/changelog/td-firmware?cs=b824ef4b479578c5aa702abd9147aef505a6fb04 Dara Navaei committed b824ef4 on branch LDT-1394-blood-flow-rate-h4-rotor-count, LDT-1415-pressures-monitoring-td and 33 more in td-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/AirPump.h	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/AirTrap.c	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/AirTrap.h	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/AlarmAudio.c	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/AlarmAudio.h	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/AlarmLamp.c	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/AlarmLamp.h	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/BloodFlow.c	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/BloodFlow.h	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/Ejector.c	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Controllers/Ejector.h	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.c	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.h	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Drivers/BubbleDetector.c	(-4, +4)	| History	| Source	| Diff
… 80 more files in changeset.

]]> Mon, 24 Feb 2025 15:26:06 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1 https://devapps.diality.us/cru/TD-LEAH-838-1 Sean Nash Closed TD-LEAH-838-1 ]]> Mon, 24 Feb 2025 13:46:57 -0800 https://devapps.diality.us/cru/TD-LEAH-838-1 https://devapps.diality.us/cru/TD-LEAH-838-1 Vinayakam Mani and Michael Garthwaite finished reviewing TD-LEAH-838-1 TD-LEAH-838_FW TD Gas Liquid Transfer Pump ]]> Mon, 24 Feb 2025 13:22:23 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1 https://devapps.diality.us/cru/TD-LEAH-838-1 Sean Nash started review TD-LEAH-838-1 ]]> Fri, 21 Feb 2025 15:02:48 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21541 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21541 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

Fixed.

Done.

Done.

Done.

Done.

Done.

Done.

I would say we are required to explicitly typecast if any of the following are true:
1) compiler warning if you don't
2) byte count/mem size matters (e.g. message payload) and might not match desired size if you don't cast it

I don't think either is true in this case.

Removed TODO.

Done.

Done.

Done.

Done.

Yes. Done.

Change has not happened yet in Denali. I will follow up with Dara after change is made.

Done.

Do we want to change STATE_CLOSED to CMN_TO_NO_OPEN (or similar?), STATE_OPEN to CMN _TO_NC_OPEN?

3-way

May be add a check to validate the power level between 0 to 255.

No Alarm, Add Event ID.

MotorState to MotorPowerLevel - across file.

Please adjust the alignment(few #defines)

isAutoControlling?

please add description/details along with the Message ID