Updated

Added

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

I was thinking that comment should go above the first if statement.

Updated

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below:
#define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall condition must persist before alarming.

OR use persistent alarm.

Added

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).

Added

Should probably initialize your new stall counter variable.

Sean Nash I need your help for writing this Alarm properties.

· /firmware/App/Controllers/BloodFlow.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/PeristalticPump.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/PeristalticPump.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/FpgaTD.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/FpgaTD.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff

]]> Fri, 13 Mar 2026 12:04:13 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1394-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1394-1 Vendor - TEL - Jashwant Gantyada Closed LEAHI-TD-FIRMWARE-LDT-1394-1 ]]> Fri, 13 Mar 2026 12:03:13 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1394-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1394-1 Sean Nash and Raghu Kallala finished reviewing LEAHI-TD-FIRMWARE-LDT-1394-1 LEAHI-TD-FIRMWARE-LDT-1394_Blood Flow Rate - TD - 04: DEV - Feature Implementation ]]> Fri, 13 Mar 2026 11:59:35 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1394-1/#c28023 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1394-1/#c28023 Vendor - TEL - Jashwant Gantyada replied to Raghu Kallala in LEAHI-TD-FIRMWARE-LDT-1394-1

done updated below in the function as well.

done.

Intentional?

update the header and field comments in later commits

If we don't think we need this, let's just delete it. If we think it's coming back, let's keep it and just set the max count to something really high (e.g. 1,000,000).

· /firmware/App/Controllers/AirPump.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/AirPump.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/AirTrap.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/AirTrap.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/GLXferPump.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/GLXferPump.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/FpgaTD.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/FpgaTD.h	(-2, +2)	| History	| Source	| Diff

]]> Mon, 02 Mar 2026 20:46:01 -0800 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8 Sean Nash resumed reviewing LEAHI-TD-FIRMWARE-LDT-1903-8 LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation ]]> Mon, 02 Mar 2026 14:13:30 -0800 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1394-1/#c27700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1394-1/#c27700 Vendor - TEL - Jashwant Gantyada replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1394-1

done.