Fisheye on dd-firmware/firmware/App/Tasks/TaskGeneral.c

LEAHI-DD-FIRMWARE-LDT-2004-13: started by Dara Navaei

Dara Navaei — Wed, 25 Mar 2026 04:01:46 -0700

Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-13

LEAHI-DD-FIRMWARE-LDT-2004-11: started by Dara Navaei

Dara Navaei — Thu, 19 Mar 2026 15:47:06 -0700

Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-11

LEAHI-DD-FIRMWARE-LDT-1195-2: comment by Sean Nash "I believe we will want BC control during ISO UF..."

Sean Nash — Wed, 11 Mar 2026 14:09:24 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-1195-2

I believe we will want BC control during ISO UF state.

LEAHI-DD-FIRMWARE-LDT-1195-2: comment by Sean Nash "Remove blank line and comment saying we're not ..."

Sean Nash — Wed, 11 Mar 2026 14:07:39 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-1195-2

Remove blank line and comment saying we're not doing anything (because now we're doing something).

LEAHI-DD-FIRMWARE-LDT-1195-2: comment by Sean Nash "isBalChamberSwitchingOffRequested is an output."

Sean Nash — Wed, 11 Mar 2026 14:05:24 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-1195-2

isBalChamberSwitchingOffRequested is an output.

LEAHI-DD-FIRMWARE-LDT-1195-2: comment by Sean Nash "Should we set the other switch to FALSE, just i..."

Sean Nash — Wed, 11 Mar 2026 14:03:35 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-1195-2

Should we set the other switch to FALSE, just in case?

LEAHI-DD-FIRMWARE-LDT-1195-2: started by Dara Navaei

Dara Navaei — Wed, 25 Feb 2026 15:31:28 -0800

Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-1195-2

LEAHI-DD-FIRMWARE-LDT-2004-3: closed by Vinayakam Mani

Vinayakam Mani — Fri, 13 Feb 2026 09:40:18 -0800

Vinayakam Mani Closed LEAHI-DD-FIRMWARE-LDT-2004-3

dd-firmware (LDT-553-water-treatment-and-degassing-baro): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 10 Feb 2026 13:55:18 -0800

Dara Navaei committed d210786 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 41 more in dd-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BalancingChamber.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/DialysatePumps.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/DryBiCart.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/DryBiCart.h

(-4, +4)

| History

| Source

| Diff

· /firmware/App/Controllers/SpentChamberFill.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/DDCommon.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/FPModes/FPOperationModes.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenDialysate.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenDialysate.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModePreGenDialysate.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeStandby.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Monitors/Level.c

(-2, +2)

| History

| Source

| Diff

… 3 more files in changeset.

LEAHI-DD-FIRMWARE-LDT-2004-3: reviewers finished

Tue, 10 Feb 2026 13:32:45 -0800

Vendor - TEL - Sameer Poyil and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-2004-3

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD

LEAHI-DD-FIRMWARE-LDT-2004-3: comment by Sean Nash "Add TODO to comment."

Sean Nash — Tue, 10 Feb 2026 10:50:36 -0800

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-3

Add TODO to comment.

LEAHI-DD-FIRMWARE-LDT-2004-3: comment by Sean Nash "Put () around the 2 conditions"

Sean Nash — Tue, 10 Feb 2026 10:48:46 -0800

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-3

Put () around the 2 conditions

LEAHI-DD-FIRMWARE-LDT-2004-3: comment by Vendor - TEL - Sameer Poyil "Fixed it"

Vendor - TEL - Sameer Poyil — Fri, 06 Feb 2026 19:35:16 -0800

Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-2004-3

Fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3: comment by Vendor - TEL - Sameer Poyil "Ya , I forgot the coding guide line . Fixed it"

Vendor - TEL - Sameer Poyil — Fri, 06 Feb 2026 19:34:52 -0800

Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-2004-3

Ya , I forgot the coding guide line .
Fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3: comment by Vendor - TEL - Sameer Poyil "fixed it"

Vendor - TEL - Sameer Poyil — Fri, 06 Feb 2026 19:34:27 -0800

Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-2004-3

fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3: comment by Vendor - TEL - Sameer Poyil "Fixed it"

Vendor - TEL - Sameer Poyil — Fri, 06 Feb 2026 19:34:05 -0800

Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-2004-3

Fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3: comment by Vendor - TEL - Sameer Poyil "fixed it"

Vendor - TEL - Sameer Poyil — Fri, 06 Feb 2026 19:32:17 -0800

Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-2004-3

fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3: reviewers removed from LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition -...

Fri, 06 Feb 2026 15:56:27 -0800

Sean Nash removed Behrouz NematiPour , Stephen Quong and Tiffany Mejia from LEAHI-DD-FIRMWARE-LDT-2004-3

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD

LEAHI-DD-FIRMWARE-LDT-2004-3: comment by Sean Nash "Use explicit BOOL conditions (e.g. TRUE == isFr..."

Sean Nash — Fri, 06 Feb 2026 14:22:30 -0800

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-3

Use explicit BOOL conditions (e.g. TRUE == isFreshDialysatePressureInRange).

LEAHI-DD-FIRMWARE-LDT-2004-3: comment by Sean Nash "I prefer to be explicit on BOOL conditions like..."

Sean Nash — Fri, 06 Feb 2026 10:52:41 -0800

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-3

I prefer to be explicit on BOOL conditions like this (e.g. TRUE == isFreshDialysatePressureInRange).

LEAHI-DD-FIRMWARE-LDT-2004-3: comment by Sean Nash "Remove extra blank line."

Sean Nash — Fri, 06 Feb 2026 10:51:14 -0800

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-3

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-2004-3: comment by Vinayakam Mani "I don't think we need to check test config for ..."

Vinayakam Mani — Fri, 06 Feb 2026 09:25:46 -0800

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-2004-3

I don't think we need to check test config for variable initialization.

LEAHI-DD-FIRMWARE-LDT-2004-3: comment by Vendor - TEL - Sameer Poyil "fixed it"

Vendor - TEL - Sameer Poyil — Fri, 06 Feb 2026 09:13:32 -0800

Vendor - TEL - Sameer Poyil replied to Vendor - TEL - Sameer Poyil in LEAHI-DD-FIRMWARE-LDT-2004-3

fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3: comment by Vendor - TEL - Sameer Poyil "Fixed it"

Vendor - TEL - Sameer Poyil — Fri, 06 Feb 2026 09:10:53 -0800

Vendor - TEL - Sameer Poyil replied to Vendor - TEL - Sameer Poyil in LEAHI-DD-FIRMWARE-LDT-2004-3

Fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3: comment by Vendor - TEL - Sameer Poyil "fixed it"

Vendor - TEL - Sameer Poyil — Fri, 06 Feb 2026 09:04:45 -0800

Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-2004-3

fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3: comment by Vendor - TEL - Sameer Poyil "fixed it"

Vendor - TEL - Sameer Poyil — Fri, 06 Feb 2026 09:04:30 -0800

Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-2004-3

fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3: comment by Vendor - TEL - Sameer Poyil "fixed it"

Vendor - TEL - Sameer Poyil — Fri, 06 Feb 2026 09:03:22 -0800

Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-2004-3

fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3: comment by Vendor - TEL - Sameer Poyil "fixed it"

Vendor - TEL - Sameer Poyil — Fri, 06 Feb 2026 09:03:08 -0800

Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-2004-3

fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3: comment by Vendor - TEL - Sameer Poyil "fixed it"

Vendor - TEL - Sameer Poyil — Fri, 06 Feb 2026 09:01:37 -0800

Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-2004-3

fixed it

dd-firmware (LDT-553-water-treatment-and-degassing-baro): LDT-2004-3 dry bicart review comment implementation

Vendor - TEL - Sameer Poyil — Fri, 06 Feb 2026 08:58:59 -0800

Vendor - TEL - Sameer Poyil committed f7f6305 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 42 more in dd-firmware

LDT-2004-3 dry bicart review comment implementation

· /firmware/App/Controllers/BalancingChamber.c	(-26, +37)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DryBiCart.c	(-103, +144)	\| History	\| Source	\| Diff
· /firmware/App/DDCommon.h	(-3, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-21, +33)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenDialysate.c	(-10, +10)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-2, +5)	\| History	\| Source	\| Diff