Fisheye on dd-firmware/firmware/App/Modes/FPModes/ModePreGenPermeate.c https://devapps.diality.us/changelog/~br%3DLDT-3777-sprint-25-fixes-AS/dd-firmware/firmware/App/Modes/FPModes/ModePreGenPermeate.c Recent activity in "dd-firmware" under directory /firmware/App/Modes/FPModes/ModePreGenPermeate.c LEAHI-DD-FIRMWARE-LDT-3978-1: reviewers resumed Fri, 24 Apr 2026 22:17:00 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Vinayakam Mani resumed reviewing LEAHI-DD-FIRMWARE-LDT-3978-1 LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid ]]> LEAHI-DD-FIRMWARE-LDT-3978-1: reviewers joined LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conduc... Thu, 23 Apr 2026 14:59:17 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Vinayakam Mani joined LEAHI-DD-FIRMWARE-LDT-3978-1 LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid ]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "instead of 0, we can use the level Enum 'LVL_ST..." Thu, 23 Apr 2026 14:56:16 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28636 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28636 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "lower? and change the D98 level sensor comment ..." Thu, 23 Apr 2026 14:49:10 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28635 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28635 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

lower? and change the D98 level sensor comment as well.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Remove empty line" Thu, 23 Apr 2026 14:47:11 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28634 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28634 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Remove empty line

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Space before LVL_STATE_LOW" Thu, 23 Apr 2026 14:45:56 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28633 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28633 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Space before LVL_STATE_LOW

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "space inside array index." Thu, 23 Apr 2026 14:43:35 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28632 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28632 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

space inside array index.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Space inside parenthesis." Thu, 23 Apr 2026 14:41:03 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28631 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28631 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Space inside parenthesis.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Change this to LEVEL_T enum." Thu, 23 Apr 2026 14:39:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28630 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28630 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Change this to LEVEL_T enum.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Is this macro still being used? if not, delete ..." Thu, 23 Apr 2026 14:38:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28629 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28629 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Is this macro still being used? if not, delete it.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: started by Dara Navaei Thu, 23 Apr 2026 07:47:26 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3978-1 ]]> LEAHI-DD-FIRMWARE-LDT-3603-1: closed by Raghu Kallala Thu, 02 Apr 2026 07:11:40 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-1 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-3603-1 ]]> LEAHI-DD-FIRMWARE-LDT-3603-2: closed by Raghu Kallala Thu, 02 Apr 2026 07:11:34 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-3603-2 ]]> LEAHI-DD-FIRMWARE-LDT-3603-2: reviewers finished Wed, 01 Apr 2026 12:26:32 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2 Vinayakam Mani , Michael Garthwaite and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3603-2 LEAHI-DD-FIRMWARE-LDT-3603_Ability to set operation sub mode on IOFP subsystem ]]> LEAHI-DD-FIRMWARE-LDT-3603-2: comment by Raghu Kallala "Updated" Tue, 31 Mar 2026 10:26:39 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2/#c28172 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2/#c28172 Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3603-2

Updated

]]> LEAHI-DD-FIRMWARE-LDT-3603-2: comment by Raghu Kallala "Added" Tue, 31 Mar 2026 10:17:26 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2/#c28171 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2/#c28171 Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3603-2

Added

]]> LEAHI-DD-FIRMWARE-LDT-3603-2: comment by Sean Nash "Add a comment: \\ result already FALSE - do not..." Tue, 31 Mar 2026 09:43:06 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2/#c28170 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2/#c28170 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3603-2

Add a comment:
result already FALSE - do nothing more for modes that do not support jump to sub-mode.

]]> LEAHI-DD-FIRMWARE-LDT-3603-2: comment by Sean Nash "Add a comment here: \\ Do nothing for modes tha..." Tue, 31 Mar 2026 09:41:46 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2/#c28169 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2/#c28169 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3603-2

Add a comment here:
Do nothing for modes that do not support jump to sub-mode.

]]> LEAHI-DD-FIRMWARE-LDT-3603-2: comment by Raghu Kallala "Updated" Tue, 31 Mar 2026 07:04:20 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2/#c28168 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2/#c28168 Raghu Kallala replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-3603-2

Updated

]]> LEAHI-DD-FIRMWARE-LDT-3603-2: comment by Raghu Kallala "Updated, thanks" Tue, 31 Mar 2026 07:04:05 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2/#c28167 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2/#c28167 Raghu Kallala replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-3603-2

Updated, thanks

]]> LEAHI-DD-FIRMWARE-LDT-3603-2: reviewers joined LEAHI-DD-FIRMWARE-LDT-3603_Ability to set operatio... Mon, 30 Mar 2026 16:58:04 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2 Michael Garthwaite and Vinayakam Mani joined LEAHI-DD-FIRMWARE-LDT-3603-2 LEAHI-DD-FIRMWARE-LDT-3603_Ability to set operation sub mode on IOFP subsystem ]]> LEAHI-DD-FIRMWARE-LDT-3603-2: comment by Vinayakam Mani "'genPermeateState' in the outputs. please updat..." Mon, 30 Mar 2026 16:55:22 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2/#c28156 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2/#c28156 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3603-2

'genPermeateState' in the outputs. please update across the files as needed.

]]> LEAHI-DD-FIRMWARE-LDT-3603-2: comment by Vinayakam Mani "Validates the requested sub mode change is acce..." Mon, 30 Mar 2026 16:34:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2/#c28154 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2/#c28154 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3603-2

Validates the requested sub mode change is acceptable or not?

]]> LEAHI-DD-FIRMWARE-LDT-3603-2: started by Dara Navaei Mon, 30 Mar 2026 13:46:42 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-2 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3603-2 ]]> LEAHI-DD-FIRMWARE-LDT-2004-13: started by Dara Navaei Wed, 25 Mar 2026 04:01:46 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-13 ]]> LEAHI-DD-FIRMWARE-LDT-2004-11: started by Dara Navaei Thu, 19 Mar 2026 15:47:06 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-11 ]]> LEAHI-DD-FIRMWARE-LDT-3603-1: reviewers finished Wed, 18 Mar 2026 14:30:07 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-1 Sean Nash and Michael Garthwaite finished reviewing LEAHI-DD-FIRMWARE-LDT-3603-1 LEAHI-DD-FIRMWARE-LDT-3603_Ability to set operation sub mode on IOFP sub system ]]> LEAHI-DD-FIRMWARE-LDT-3603-1: comment by Raghu Kallala "That's a question for me, will that be required..." Thu, 12 Mar 2026 07:19:35 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-1/#c27906 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-1/#c27906 Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3603-1

That's a question for me, will that be required?

Fault has sub modes(3), Standby has 1 sub mode(I am adding code for this as this might be required)
Init don't have any and service is not defined yet

]]> LEAHI-DD-FIRMWARE-LDT-3603-1: comment by Raghu Kallala "Updated" Thu, 12 Mar 2026 06:37:54 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-1/#c27905 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-1/#c27905 Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3603-1

Updated

]]> LEAHI-DD-FIRMWARE-LDT-3603-1: comment by Raghu Kallala "Updated" Thu, 12 Mar 2026 06:37:03 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-1/#c27904 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3603-1/#c27904 Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3603-1

Updated

]]>