· /PIDControllers.c	(-5, +5)	| History	| Source	| Diff
· /PIDControllers.h	(-4, +4)	| History	| Source	| Diff

]]> Thu, 16 Apr 2026 08:15:43 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 Michael Garthwaite Closed LEAHI-DD-FIRMWARE-LDT-3218-4 ]]> Wed, 15 Apr 2026 17:31:50 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3218-4 LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed) ]]> Wed, 15 Apr 2026 16:12:48 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28431 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28431 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-3218-4

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. else, just a PI control signal would work. (something similar to Feed forward enabled flag)

· /PIDControllers.c

(-35, +0)

| History

| Source

| Diff

]]> Wed, 15 Apr 2026 10:14:27 -0700 Michael Garthwaite https://devapps.diality.us/changelog/leahi-fwcommon?cs=9be535ca3ef8126630e0754d78f8f74c4bab02d7 https://devapps.diality.us/changelog/leahi-fwcommon?cs=9be535ca3ef8126630e0754d78f8f74c4bab02d7 Michael Garthwaite committed 9be535c on branch LDT-2004-dialysate-composition-dosing-control--dd, LDT-2240-disposable-tube-set-self-test and 5 more in leahi-fwcommon LDT-3218: fixed compiler error where fault id no longer exists

· /PIDControllers.c

(-6, +0)

| History

| Source

| Diff

]]> Wed, 15 Apr 2026 09:52:57 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28375 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28375 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3218-4

nope. removed.

fixed

fixed

fixed

fixed

Add blank line before return.

Add blank line after declarations.

Why U32? Why not RECOVER_STATE_T?

Lower case x

Is blood flow in need of a PID controller too?

· /PIDControllers.c

(-2, +5)

| History

| Source

| Diff

]]> Thu, 26 Mar 2026 12:23:55 -0700 Michael Garthwaite https://devapps.diality.us/changelog/leahi-fwcommon?cs=aa6bdd3bfc3bd8bc1a56670c2bdadc32c99b33c3 https://devapps.diality.us/changelog/leahi-fwcommon?cs=aa6bdd3bfc3bd8bc1a56670c2bdadc32c99b33c3 Michael Garthwaite committed aa6bdd3 on branch LDT-2004-dialysate-composition-dosing-control--dd, LDT-2240-disposable-tube-set-self-test and 5 more in leahi-fwcommon LDT-3218: integration fixes.

· /PIDControllers.c	(-12, +12)	| History	| Source	| Diff
· /PIDControllers.h	(-15, +15)	| History	| Source	| Diff

]]> Thu, 26 Mar 2026 12:04:47 -0700 Michael Garthwaite https://devapps.diality.us/changelog/leahi-fwcommon?cs=0ead56df33c1583486ca3a8f8eeeeadfa5f11eb5 https://devapps.diality.us/changelog/leahi-fwcommon?cs=0ead56df33c1583486ca3a8f8eeeeadfa5f11eb5 Michael Garthwaite committed 0ead56d on branch LDT-2004-dialysate-composition-dosing-control--dd, LDT-2240-disposable-tube-set-self-test and 5 more in leahi-fwcommon LDT-3218: Added PID controller temporary to mitigate RO flow control reaction to new behavior of D3 opening and closing.

· /PIDControllers.c	(-0, +398)	| History	| Source
· /PIDControllers.h	(-0, +91)	| History	| Source

]]> Wed, 25 Mar 2026 11:16:55 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3218-4 ]]>