Fisheye on dd-firmware/firmware/App/Controllers/ROPump.c https://devapps.diality.us/changelog/~br%3DLDT-3928-fw-implementation-fp-boost-pump/dd-firmware/firmware/App/Controllers/ROPump.c Recent activity in "dd-firmware" under directory /firmware/App/Controllers/ROPump.c LEAHI-DD-FIRMWARE-LDT-3218-4: closed by Michael Garthwaite Thu, 16 Apr 2026 08:15:43 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 Michael Garthwaite Closed LEAHI-DD-FIRMWARE-LDT-3218-4 ]]> LEAHI-DD-FIRMWARE-LDT-3218-4: reviewers finished Wed, 15 Apr 2026 17:31:50 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3218-4 LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed) ]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite "by the end of S27 we will know if we need to ke..." Wed, 15 Apr 2026 16:12:48 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28431 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28431 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-3218-4

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Vinayakam Mani "If this is the core change, can we introduce th..." Wed, 15 Apr 2026 15:34:19 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28426 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28426 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3218-4

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. else, just a PI control signal would work. (something similar to Feed forward enabled flag)

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite "nope. removed." Wed, 15 Apr 2026 09:52:57 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28375 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28375 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3218-4

nope. removed.

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite "fixed" Wed, 15 Apr 2026 09:52:50 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28374 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28374 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3218-4

fixed

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite "fixed" Wed, 15 Apr 2026 09:52:35 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28373 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28373 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3218-4

fixed

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite "fixed" Wed, 15 Apr 2026 09:52:20 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28372 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28372 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3218-4

fixed

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite "fixed" Wed, 15 Apr 2026 09:52:04 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28371 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28371 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3218-4

fixed

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash "Add blank line before return." Tue, 14 Apr 2026 14:08:22 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28328 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28328 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3218-4

Add blank line before return.

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash "Add blank line after declarations." Tue, 14 Apr 2026 14:07:02 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28327 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28327 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3218-4

Add blank line after declarations.

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash "Why U32? Why not RECOVER_STATE_T?" Tue, 14 Apr 2026 14:05:42 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28326 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28326 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3218-4

Why U32? Why not RECOVER_STATE_T?

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash "Lower case x" Tue, 14 Apr 2026 14:04:13 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28325 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28325 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3218-4

Lower case x

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash "Is blood flow in need of a PID controller too?" Tue, 14 Apr 2026 14:02:40 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28324 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28324 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3218-4

Is blood flow in need of a PID controller too?

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: started by Dara Navaei Wed, 25 Mar 2026 11:16:55 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3218-4 ]]> LEAHI-DD-FIRMWARE-LDT-2004-13: started by Dara Navaei Wed, 25 Mar 2026 04:01:46 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-13 ]]> LEAHI-DD-FIRMWARE-LDT-2004-11: started by Dara Navaei Thu, 19 Mar 2026 15:47:06 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-11 ]]> dd-firmware (LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test-3-30-2026): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 23 Jan 2026 13:07:22 -0800 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=a2ebc68ef586c213fd6e5e56c61e4b1e8cbb749c https://devapps.diality.us/changelog/dd-firmware?cs=a2ebc68ef586c213fd6e5e56c61e4b1e8cbb749c Dara Navaei committed a2ebc68 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 56 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
]]> LEAHI-DD-FIRMWARE-LDT-2977-1: closed by Michael Garthwaite Fri, 23 Jan 2026 13:03:18 -0800 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1 Michael Garthwaite Closed LEAHI-DD-FIRMWARE-LDT-2977-1 ]]> LEAHI-DD-FIRMWARE-LDT-2977-1: reviewers finished Fri, 23 Jan 2026 13:02:17 -0800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1 Sean Nash and Raghu Kallala finished reviewing LEAHI-DD-FIRMWARE-LDT-2977-1 LEAHI-DD-FIRMWARE-LDT-2977_IOFP - Update starting flow estimations based on recovery mode ]]> dd-firmware (LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test-3-30-2026): LDT-2977: code review adjust Fri, 23 Jan 2026 12:55:02 -0800 Michael Garthwaite https://devapps.diality.us/changelog/dd-firmware?cs=a59557e653a712fcdebb7928a74514b2108f44ea https://devapps.diality.us/changelog/dd-firmware?cs=a59557e653a712fcdebb7928a74514b2108f44ea Michael Garthwaite committed a59557e on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 57 more in dd-firmware LDT-2977: code review adjust

· /firmware/App/Controllers/ROPump.c (-2, +0) | History | Source | Diff
]]> LEAHI-DD-FIRMWARE-LDT-2977-1: comment by Michael Garthwaite "fixed." Fri, 23 Jan 2026 12:51:22 -0800 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26590 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26590 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-2977-1

fixed.

]]> dd-firmware (LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test-3-30-2026): LDT-2977: code review comments. Fri, 23 Jan 2026 12:51:00 -0800 Michael Garthwaite https://devapps.diality.us/changelog/dd-firmware?cs=b9410f03da0a767684f35843a0b3d4a0733c622b https://devapps.diality.us/changelog/dd-firmware?cs=b9410f03da0a767684f35843a0b3d4a0733c622b Michael Garthwaite committed b9410f0 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 57 more in dd-firmware LDT-2977: code review comments.

· /firmware/App/Controllers/ROPump.c (-0, +5) | History | Source | Diff
]]> dd-firmware (LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test-3-30-2026): LDT-2977: code review comments. Fri, 23 Jan 2026 12:49:14 -0800 Michael Garthwaite https://devapps.diality.us/changelog/dd-firmware?cs=f9d0e15ba8e25a69666ed0231721ea58e2145f2f https://devapps.diality.us/changelog/dd-firmware?cs=f9d0e15ba8e25a69666ed0231721ea58e2145f2f Michael Garthwaite committed f9d0e15 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 57 more in dd-firmware LDT-2977: code review comments.

· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
]]> LEAHI-DD-FIRMWARE-LDT-2977-1: comment by Sean Nash "When comment is above, use /// instead of ///<...." Fri, 23 Jan 2026 12:45:04 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26589 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26589 Sean Nash replied to Michael Garthwaite in LEAHI-DD-FIRMWARE-LDT-2977-1

When comment is above, use /// instead of ///<. And add blank lines before/after - doxygen seems to get confused about where to apply the comment without clear separation.

]]> LEAHI-DD-FIRMWARE-LDT-2977-1: comment by Michael Garthwaite "fixed for both _TO_PWM macros" Fri, 23 Jan 2026 12:09:30 -0800 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26588 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26588 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-2977-1

fixed for both _TO_PWM macros

]]> LEAHI-DD-FIRMWARE-LDT-2977-1: comment by Michael Garthwaite "its been removed. looks like we send everything..." Fri, 23 Jan 2026 12:09:09 -0800 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26587 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26587 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-2977-1

its been removed. looks like we send everything down as a percentage now and the fluid pump driver will change it counts.

]]> dd-firmware (LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test-3-30-2026): LDT-2977: code review updates. Removed macro for flow that used counts Fri, 23 Jan 2026 12:08:25 -0800 Michael Garthwaite https://devapps.diality.us/changelog/dd-firmware?cs=644186b74908ecb1c61a2af06a2bfb43b5618c8e https://devapps.diality.us/changelog/dd-firmware?cs=644186b74908ecb1c61a2af06a2bfb43b5618c8e Michael Garthwaite committed 644186b on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 57 more in dd-firmware LDT-2977: code review updates. Removed macro for flow that used counts

· /firmware/App/Controllers/ROPump.c (-6, +4) | History | Source | Diff
]]> dd-firmware (LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test-3-30-2026): Merge branch &#039;staging&#039; into LDT-2977-iofp-update Fri, 23 Jan 2026 12:06:09 -0800 Michael Garthwaite https://devapps.diality.us/changelog/dd-firmware?cs=19dd28ed9c1c81d3bbf50e7a6bf691f19be0b54e https://devapps.diality.us/changelog/dd-firmware?cs=19dd28ed9c1c81d3bbf50e7a6bf691f19be0b54e Michael Garthwaite committed 19dd28e on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 57 more in dd-firmware Merge branch 'staging' into LDT-2977-iofp-update

· /firmware/App/Controllers/ROPump.c (-19, +51) | History | Source | Diff
]]> LEAHI-DD-FIRMWARE-LDT-2977-1: comment by Sean Nash "For long macros, consider moving doxygen commen..." Fri, 23 Jan 2026 09:50:58 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26585 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26585 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2977-1

For long macros, consider moving doxygen comment from right side to line above with /// since right side won't line up with others.

]]>