<?xml version="1.0"?>
<rss version="2.0">













































<channel>
    <title>Fisheye on dd-firmware/firmware/App/Controllers/ROPump.c</title>
    <link>https://devapps.diality.us/changelog/~br%3DLDT-3928-fw-implementation-fp-boost-pump/dd-firmware/firmware/App/Controllers/ROPump.c</link>
    <description>Recent activity in "dd-firmware" under directory /firmware/App/Controllers/ROPump.c</description>

    
    
    
        

        

        
            

            

            
                
                

















    
    
        
        
        
        
    
    
    
    
    
    



    
        












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-3218-4: closed by Michael Garthwaite</title>
        <pubDate>Thu, 16 Apr 2026 08:15:43 -0700</pubDate>
        <author>Michael Garthwaite</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                    <tr>
                        <td>
                            




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/mgarthwaite?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/mgarthwaite"  title="">
        
                <span class="linkText">Michael Garthwaite</span>
            
        </a>
        
    
    






                            Closed
                            














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-3218-4">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-3218-4
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-3218-4"></a>
    

</span>


                        </td>
                    </tr>
                    
                </table>
        ]]>
        </description>
</item>


    
    



                
            

            

            

            

            

        
    
        

        

        
            

            

            

            

            
                
                
                    
                    
                        
                        
                    
                
                














    
        












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-3218-4: reviewers finished</title>
        <pubDate>Wed, 15 Apr 2026 17:31:50 -0700</pubDate>
        <author></author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                    <tr>
                        <td>
                            
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/snash?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/snash"  title="">
        
                <span class="linkText">Sean Nash</span>
            
        </a>
        
    
    






                                
                                    and
                                
                            
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/vmani?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/vmani"  title="">
        
                <span class="linkText">Vinayakam Mani</span>
            
        </a>
        
    
    






                                
                            

                            finished reviewing 















    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-3218-4">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-3218-4
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-3218-4"></a>
    

</span>


                        </td>
                    </tr>
                    <tr>
                        <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                            LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)
                        </td>
                    </tr>
                </table>
        ]]>
        </description>
</item>


    
    


            

            

            

        
    
        

        

        
            

            

            

            
                
                

























    

    
        
            












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite &#034;by the end of S27 we will know if we need to ke...&#034;</title>
        <pubDate>Wed, 15 Apr 2026 16:12:48 -0700</pubDate>
        <author>Michael Garthwaite</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28431</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28431</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                        <tr>
                            <td>
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/mgarthwaite?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/mgarthwaite"  title="">
        
                <span class="linkText">Michael Garthwaite</span>
            
        </a>
        
    
    






                                
                                    
                                        <a href="https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28431">replied</a> to
                                        <span title="If this is the core change, can we introduce th...">
                                            




































    
        
            
        
        
    
    








    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user  userorcommitter-parent"  href="/user/vmani"  title="">
        
                <span class="linkText">Vinayakam Mani</span>
            
        </a>
        
    
    






                                        </span>
                                        in
                                    
                                    
                                
                                














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-3218-4">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-3218-4
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-3218-4"></a>
    

</span>


                            </td>
                        </tr>
                        <tr>
                            <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                                <p>by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c</p>
                            </td>
                        </tr>
                    </table>
        ]]>
        </description>
</item>


        
        
    


                
            

            

            

            

        
    
        

        

        
            

            

            

            
                
                

























    

    
        
            












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Vinayakam Mani &#034;If this is the core change, can we introduce th...&#034;</title>
        <pubDate>Wed, 15 Apr 2026 15:34:19 -0700</pubDate>
        <author>Vinayakam Mani</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28426</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28426</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                        <tr>
                            <td>
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/vmani?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/vmani"  title="">
        
                <span class="linkText">Vinayakam Mani</span>
            
        </a>
        
    
    






                                
                                    
                                    
                                        <a href="https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28426">commented</a> on
                                    
                                
                                














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-3218-4">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-3218-4
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-3218-4"></a>
    

</span>


                            </td>
                        </tr>
                        <tr>
                            <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                                <p>If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if &#39;IsDerivativeEnabled&quot; set to true, add the derivative signal to Control signal. else, just a PI control signal would work. (something similar to Feed forward enabled flag)</p>
                            </td>
                        </tr>
                    </table>
        ]]>
        </description>
</item>


        
        
    


                
            

            

            

            

        
    
        

        

        
            

            

            

            
                
                

























    

    
        
            












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite &#034;nope. removed.&#034;</title>
        <pubDate>Wed, 15 Apr 2026 09:52:57 -0700</pubDate>
        <author>Michael Garthwaite</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28375</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28375</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                        <tr>
                            <td>
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/mgarthwaite?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/mgarthwaite"  title="">
        
                <span class="linkText">Michael Garthwaite</span>
            
        </a>
        
    
    






                                
                                    
                                        <a href="https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28375">replied</a> to
                                        <span title="Is blood flow in need of a PID controller too?">
                                            




































    
        
            
        
        
    
    








    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user  userorcommitter-parent"  href="/user/snash"  title="">
        
                <span class="linkText">Sean Nash</span>
            
        </a>
        
    
    






                                        </span>
                                        in
                                    
                                    
                                
                                














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-3218-4">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-3218-4
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-3218-4"></a>
    

</span>


                            </td>
                        </tr>
                        <tr>
                            <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                                <p>nope. removed.</p>
                            </td>
                        </tr>
                    </table>
        ]]>
        </description>
</item>


        
        
    


                
            

            

            

            

        
    
        

        

        
            

            

            

            
                
                

























    

    
        
            












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite &#034;fixed&#034;</title>
        <pubDate>Wed, 15 Apr 2026 09:52:50 -0700</pubDate>
        <author>Michael Garthwaite</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28374</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28374</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                        <tr>
                            <td>
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/mgarthwaite?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/mgarthwaite"  title="">
        
                <span class="linkText">Michael Garthwaite</span>
            
        </a>
        
    
    






                                
                                    
                                        <a href="https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28374">replied</a> to
                                        <span title="Lower case x">
                                            




































    
        
            
        
        
    
    








    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user  userorcommitter-parent"  href="/user/snash"  title="">
        
                <span class="linkText">Sean Nash</span>
            
        </a>
        
    
    






                                        </span>
                                        in
                                    
                                    
                                
                                














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-3218-4">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-3218-4
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-3218-4"></a>
    

</span>


                            </td>
                        </tr>
                        <tr>
                            <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                                <p>fixed</p>
                            </td>
                        </tr>
                    </table>
        ]]>
        </description>
</item>


        
        
    


                
            

            

            

            

        
    
        

        

        
            

            

            

            
                
                

























    

    
        
            












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite &#034;fixed&#034;</title>
        <pubDate>Wed, 15 Apr 2026 09:52:35 -0700</pubDate>
        <author>Michael Garthwaite</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28373</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28373</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                        <tr>
                            <td>
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/mgarthwaite?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/mgarthwaite"  title="">
        
                <span class="linkText">Michael Garthwaite</span>
            
        </a>
        
    
    






                                
                                    
                                        <a href="https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28373">replied</a> to
                                        <span title="Why U32?  Why not RECOVER_STATE_T?">
                                            




































    
        
            
        
        
    
    








    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user  userorcommitter-parent"  href="/user/snash"  title="">
        
                <span class="linkText">Sean Nash</span>
            
        </a>
        
    
    






                                        </span>
                                        in
                                    
                                    
                                
                                














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-3218-4">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-3218-4
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-3218-4"></a>
    

</span>


                            </td>
                        </tr>
                        <tr>
                            <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                                <p>fixed</p>
                            </td>
                        </tr>
                    </table>
        ]]>
        </description>
</item>


        
        
    


                
            

            

            

            

        
    
        

        

        
            

            

            

            
                
                

























    

    
        
            












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite &#034;fixed&#034;</title>
        <pubDate>Wed, 15 Apr 2026 09:52:20 -0700</pubDate>
        <author>Michael Garthwaite</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28372</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28372</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                        <tr>
                            <td>
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/mgarthwaite?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/mgarthwaite"  title="">
        
                <span class="linkText">Michael Garthwaite</span>
            
        </a>
        
    
    






                                
                                    
                                        <a href="https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28372">replied</a> to
                                        <span title="Add blank line after declarations.">
                                            




































    
        
            
        
        
    
    








    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user  userorcommitter-parent"  href="/user/snash"  title="">
        
                <span class="linkText">Sean Nash</span>
            
        </a>
        
    
    






                                        </span>
                                        in
                                    
                                    
                                
                                














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-3218-4">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-3218-4
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-3218-4"></a>
    

</span>


                            </td>
                        </tr>
                        <tr>
                            <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                                <p>fixed</p>
                            </td>
                        </tr>
                    </table>
        ]]>
        </description>
</item>


        
        
    


                
            

            

            

            

        
    
        

        

        
            

            

            

            
                
                

























    

    
        
            












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite &#034;fixed&#034;</title>
        <pubDate>Wed, 15 Apr 2026 09:52:04 -0700</pubDate>
        <author>Michael Garthwaite</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28371</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28371</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                        <tr>
                            <td>
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/mgarthwaite?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/mgarthwaite"  title="">
        
                <span class="linkText">Michael Garthwaite</span>
            
        </a>
        
    
    






                                
                                    
                                        <a href="https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28371">replied</a> to
                                        <span title="Add blank line before return.">
                                            




































    
        
            
        
        
    
    








    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user  userorcommitter-parent"  href="/user/snash"  title="">
        
                <span class="linkText">Sean Nash</span>
            
        </a>
        
    
    






                                        </span>
                                        in
                                    
                                    
                                
                                














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-3218-4">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-3218-4
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-3218-4"></a>
    

</span>


                            </td>
                        </tr>
                        <tr>
                            <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                                <p>fixed</p>
                            </td>
                        </tr>
                    </table>
        ]]>
        </description>
</item>


        
        
    


                
            

            

            

            

        
    
        

        

        
            

            

            

            
                
                

























    

    
        
            












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash &#034;Add blank line before return.&#034;</title>
        <pubDate>Tue, 14 Apr 2026 14:08:22 -0700</pubDate>
        <author>Sean Nash</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28328</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28328</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                        <tr>
                            <td>
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/snash?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/snash"  title="">
        
                <span class="linkText">Sean Nash</span>
            
        </a>
        
    
    






                                
                                    
                                    
                                        <a href="https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28328">commented</a> on
                                    
                                
                                














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-3218-4">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-3218-4
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-3218-4"></a>
    

</span>


                            </td>
                        </tr>
                        <tr>
                            <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                                <p>Add blank line before return.</p>
                            </td>
                        </tr>
                    </table>
        ]]>
        </description>
</item>


        
        
    


                
            

            

            

            

        
    
        

        

        
            

            

            

            
                
                

























    

    
        
            












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash &#034;Add blank line after declarations.&#034;</title>
        <pubDate>Tue, 14 Apr 2026 14:07:02 -0700</pubDate>
        <author>Sean Nash</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28327</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28327</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                        <tr>
                            <td>
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/snash?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/snash"  title="">
        
                <span class="linkText">Sean Nash</span>
            
        </a>
        
    
    






                                
                                    
                                    
                                        <a href="https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28327">commented</a> on
                                    
                                
                                














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-3218-4">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-3218-4
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-3218-4"></a>
    

</span>


                            </td>
                        </tr>
                        <tr>
                            <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                                <p>Add blank line after declarations.</p>
                            </td>
                        </tr>
                    </table>
        ]]>
        </description>
</item>


        
        
    


                
            

            

            

            

        
    
        

        

        
            

            

            

            
                
                

























    

    
        
            












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash &#034;Why U32?  Why not RECOVER_STATE_T?&#034;</title>
        <pubDate>Tue, 14 Apr 2026 14:05:42 -0700</pubDate>
        <author>Sean Nash</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28326</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28326</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                        <tr>
                            <td>
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/snash?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/snash"  title="">
        
                <span class="linkText">Sean Nash</span>
            
        </a>
        
    
    






                                
                                    
                                    
                                        <a href="https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28326">commented</a> on
                                    
                                
                                














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-3218-4">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-3218-4
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-3218-4"></a>
    

</span>


                            </td>
                        </tr>
                        <tr>
                            <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                                <p>Why U32?  Why not RECOVER_STATE_T?</p>
                            </td>
                        </tr>
                    </table>
        ]]>
        </description>
</item>


        
        
    


                
            

            

            

            

        
    
        

        

        
            

            

            

            
                
                

























    

    
        
            












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash &#034;Lower case x&#034;</title>
        <pubDate>Tue, 14 Apr 2026 14:04:13 -0700</pubDate>
        <author>Sean Nash</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28325</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28325</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                        <tr>
                            <td>
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/snash?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/snash"  title="">
        
                <span class="linkText">Sean Nash</span>
            
        </a>
        
    
    






                                
                                    
                                    
                                        <a href="https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28325">commented</a> on
                                    
                                
                                














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-3218-4">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-3218-4
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-3218-4"></a>
    

</span>


                            </td>
                        </tr>
                        <tr>
                            <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                                <p>Lower case x</p>
                            </td>
                        </tr>
                    </table>
        ]]>
        </description>
</item>


        
        
    


                
            

            

            

            

        
    
        

        

        
            

            

            

            
                
                

























    

    
        
            












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash &#034;Is blood flow in need of a PID controller too?&#034;</title>
        <pubDate>Tue, 14 Apr 2026 14:02:40 -0700</pubDate>
        <author>Sean Nash</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28324</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28324</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                        <tr>
                            <td>
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/snash?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/snash"  title="">
        
                <span class="linkText">Sean Nash</span>
            
        </a>
        
    
    






                                
                                    
                                    
                                        <a href="https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28324">commented</a> on
                                    
                                
                                














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-3218-4">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-3218-4
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-3218-4"></a>
    

</span>


                            </td>
                        </tr>
                        <tr>
                            <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                                <p>Is blood flow in need of a PID controller too?</p>
                            </td>
                        </tr>
                    </table>
        ]]>
        </description>
</item>


        
        
    


                
            

            

            

            

        
    
        

        

        
            

            

            
                
                

















    
        
        
        
    
    
    
    
    
    
    



    
        












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-3218-4: started by Dara Navaei</title>
        <pubDate>Wed, 25 Mar 2026 11:16:55 -0700</pubDate>
        <author>Dara Navaei</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                    <tr>
                        <td>
                            




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/dnavaei?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/dnavaei"  title="">
        
                <span class="linkText">Dara Navaei</span>
            
        </a>
        
    
    






                            started review
                            














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-3218-4">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-3218-4
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-3218-4"></a>
    

</span>


                        </td>
                    </tr>
                    
                </table>
        ]]>
        </description>
</item>


    
    



                
            

            

            

            

            

        
    
        

        

        
            

            

            
                
                

















    
        
        
        
    
    
    
    
    
    
    



    
        












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-2004-13: started by Dara Navaei</title>
        <pubDate>Wed, 25 Mar 2026 04:01:46 -0700</pubDate>
        <author>Dara Navaei</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                    <tr>
                        <td>
                            




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/dnavaei?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/dnavaei"  title="">
        
                <span class="linkText">Dara Navaei</span>
            
        </a>
        
    
    






                            started review
                            














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewOpen" href="/cru/LEAHI-DD-FIRMWARE-LDT-2004-13">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-2004-13
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-2004-13"></a>
    

</span>


                        </td>
                    </tr>
                    
                </table>
        ]]>
        </description>
</item>


    
    



                
            

            

            

            

            

        
    
        

        

        
            

            

            
                
                

















    
        
        
        
    
    
    
    
    
    
    



    
        












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-2004-11: started by Dara Navaei</title>
        <pubDate>Thu, 19 Mar 2026 15:47:06 -0700</pubDate>
        <author>Dara Navaei</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                    <tr>
                        <td>
                            




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/dnavaei?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/dnavaei"  title="">
        
                <span class="linkText">Dara Navaei</span>
            
        </a>
        
    
    






                            started review
                            














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewOpen" href="/cru/LEAHI-DD-FIRMWARE-LDT-2004-11">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-2004-11
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-2004-11"></a>
    

</span>


                        </td>
                    </tr>
                    
                </table>
        ]]>
        </description>
</item>


    
    



                
            

            

            

            

            

        
    
        

        

        
            

            

            
                
                

















    
    
        
        
        
        
    
    
    
    
    
    



    
        












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-2977-1: closed by Michael Garthwaite</title>
        <pubDate>Fri, 23 Jan 2026 13:03:18 -0800</pubDate>
        <author>Michael Garthwaite</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                    <tr>
                        <td>
                            




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/mgarthwaite?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/mgarthwaite"  title="">
        
                <span class="linkText">Michael Garthwaite</span>
            
        </a>
        
    
    






                            Closed
                            














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-2977-1">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-2977-1
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-2977-1"></a>
    

</span>


                        </td>
                    </tr>
                    
                </table>
        ]]>
        </description>
</item>


    
    



                
            

            

            

            

            

        
    
        

        

        
            

            

            

            

            
                
                
                    
                    
                        
                        
                    
                
                














    
        












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-2977-1: reviewers finished</title>
        <pubDate>Fri, 23 Jan 2026 13:02:17 -0800</pubDate>
        <author></author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                    <tr>
                        <td>
                            
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/snash?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/snash"  title="">
        
                <span class="linkText">Sean Nash</span>
            
        </a>
        
    
    






                                
                                    and
                                
                            
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/rkallala?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/rkallala"  title="">
        
                <span class="linkText">Raghu Kallala</span>
            
        </a>
        
    
    






                                
                            

                            finished reviewing 















    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-2977-1">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-2977-1
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-2977-1"></a>
    

</span>


                        </td>
                    </tr>
                    <tr>
                        <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                            LEAHI-DD-FIRMWARE-LDT-2977_IOFP - Update starting flow estimations based on recovery mode
                        </td>
                    </tr>
                </table>
        ]]>
        </description>
</item>


    
    


            

            

            

        
    
        

        

        
            

            

            

            
                
                

























    

    
        
            












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-2977-1: comment by Michael Garthwaite &#034;fixed.&#034;</title>
        <pubDate>Fri, 23 Jan 2026 12:51:22 -0800</pubDate>
        <author>Michael Garthwaite</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26590</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26590</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                        <tr>
                            <td>
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/mgarthwaite?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/mgarthwaite"  title="">
        
                <span class="linkText">Michael Garthwaite</span>
            
        </a>
        
    
    






                                
                                    
                                        <a href="https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26590">replied</a> to
                                        <span title="When comment is above, use /// instead of ///&lt;....">
                                            




































    
        
            
        
        
    
    








    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user  userorcommitter-parent"  href="/user/snash"  title="">
        
                <span class="linkText">Sean Nash</span>
            
        </a>
        
    
    






                                        </span>
                                        in
                                    
                                    
                                
                                














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-2977-1">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-2977-1
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-2977-1"></a>
    

</span>


                            </td>
                        </tr>
                        <tr>
                            <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                                <p>fixed.</p>
                            </td>
                        </tr>
                    </table>
        ]]>
        </description>
</item>


        
        
    


                
            

            

            

            

        
    
        

        

        
            

            

            

            
                
                

























    

    
        
            












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-2977-1: comment by Sean Nash &#034;When comment is above, use /// instead of ///&lt;....&#034;</title>
        <pubDate>Fri, 23 Jan 2026 12:45:04 -0800</pubDate>
        <author>Sean Nash</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26589</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26589</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                        <tr>
                            <td>
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/snash?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/snash"  title="">
        
                <span class="linkText">Sean Nash</span>
            
        </a>
        
    
    






                                
                                    
                                        <a href="https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26589">replied</a> to
                                        <span title="fixed for both _TO_PWM macros">
                                            




































    
        
            
        
        
    
    








    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user  userorcommitter-parent"  href="/user/mgarthwaite"  title="">
        
                <span class="linkText">Michael Garthwaite</span>
            
        </a>
        
    
    






                                        </span>
                                        in
                                    
                                    
                                
                                














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-2977-1">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-2977-1
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-2977-1"></a>
    

</span>


                            </td>
                        </tr>
                        <tr>
                            <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                                <p>When comment is above, use /// instead of ///&lt;.  And add blank lines before/after - doxygen seems to get confused about where to apply the comment without clear separation.</p>
                            </td>
                        </tr>
                    </table>
        ]]>
        </description>
</item>


        
        
    


                
            

            

            

            

        
    
        

        

        
            

            

            

            
                
                

























    

    
        
            












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-2977-1: comment by Michael Garthwaite &#034;fixed for both _TO_PWM macros&#034;</title>
        <pubDate>Fri, 23 Jan 2026 12:09:30 -0800</pubDate>
        <author>Michael Garthwaite</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26588</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26588</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                        <tr>
                            <td>
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/mgarthwaite?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/mgarthwaite"  title="">
        
                <span class="linkText">Michael Garthwaite</span>
            
        </a>
        
    
    






                                
                                    
                                        <a href="https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26588">replied</a> to
                                        <span title="For long macros, consider moving doxygen commen...">
                                            




































    
        
            
        
        
    
    








    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user  userorcommitter-parent"  href="/user/snash"  title="">
        
                <span class="linkText">Sean Nash</span>
            
        </a>
        
    
    






                                        </span>
                                        in
                                    
                                    
                                
                                














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-2977-1">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-2977-1
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-2977-1"></a>
    

</span>


                            </td>
                        </tr>
                        <tr>
                            <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                                <p>fixed for both _TO_PWM macros</p>
                            </td>
                        </tr>
                    </table>
        ]]>
        </description>
</item>


        
        
    


                
            

            

            

            

        
    
        

        

        
            

            

            

            
                
                

























    

    
        
            












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-2977-1: comment by Michael Garthwaite &#034;its been removed. looks like we send everything...&#034;</title>
        <pubDate>Fri, 23 Jan 2026 12:09:09 -0800</pubDate>
        <author>Michael Garthwaite</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26587</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26587</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                        <tr>
                            <td>
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/mgarthwaite?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/mgarthwaite"  title="">
        
                <span class="linkText">Michael Garthwaite</span>
            
        </a>
        
    
    






                                
                                    
                                        <a href="https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26587">replied</a> to
                                        <span title="I don&#039;t see this macro being used anywhere.">
                                            




































    
        
            
        
        
    
    








    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user  userorcommitter-parent"  href="/user/snash"  title="">
        
                <span class="linkText">Sean Nash</span>
            
        </a>
        
    
    






                                        </span>
                                        in
                                    
                                    
                                
                                














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-2977-1">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-2977-1
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-2977-1"></a>
    

</span>


                            </td>
                        </tr>
                        <tr>
                            <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                                <p>its been removed. looks like we send everything down as a percentage now and the fluid pump driver will change it counts.</p>
                            </td>
                        </tr>
                    </table>
        ]]>
        </description>
</item>


        
        
    


                
            

            

            

            

        
    
        

        

        
            

            

            

            
                
                

























    

    
        
            












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-2977-1: comment by Sean Nash &#034;For long macros, consider moving doxygen commen...&#034;</title>
        <pubDate>Fri, 23 Jan 2026 09:50:58 -0800</pubDate>
        <author>Sean Nash</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26585</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26585</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                        <tr>
                            <td>
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/snash?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/snash"  title="">
        
                <span class="linkText">Sean Nash</span>
            
        </a>
        
    
    






                                
                                    
                                    
                                        <a href="https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26585">commented</a> on
                                    
                                
                                














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-2977-1">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-2977-1
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-2977-1"></a>
    

</span>


                            </td>
                        </tr>
                        <tr>
                            <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                                <p>For long macros, consider moving doxygen comment from right side to line above with /// since right side won&#39;t line up with others.</p>
                            </td>
                        </tr>
                    </table>
        ]]>
        </description>
</item>


        
        
    


                
            

            

            

            

        
    
        

        

        
            

            

            

            
                
                

























    

    
        
            












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-2977-1: comment by Sean Nash &#034;I don&#039;t see this macro being used anywhere.&#034;</title>
        <pubDate>Fri, 23 Jan 2026 09:49:58 -0800</pubDate>
        <author>Sean Nash</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26584</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26584</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                        <tr>
                            <td>
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/snash?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/snash"  title="">
        
                <span class="linkText">Sean Nash</span>
            
        </a>
        
    
    






                                
                                    
                                    
                                        <a href="https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26584">commented</a> on
                                    
                                
                                














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-2977-1">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-2977-1
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-2977-1"></a>
    

</span>


                            </td>
                        </tr>
                        <tr>
                            <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                                <p>I don&#39;t see this macro being used anywhere.</p>
                            </td>
                        </tr>
                    </table>
        ]]>
        </description>
</item>


        
        
    


                
            

            

            

            

        
    
        

        

        
            

            

            
                
                

















    
    
        
        
        
        
    
    
    
    
    
    



    
        












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-1925-1: closed by Raghu Kallala</title>
        <pubDate>Wed, 21 Jan 2026 10:10:21 -0800</pubDate>
        <author>Raghu Kallala</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                    <tr>
                        <td>
                            




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/rkallala?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/rkallala"  title="">
        
                <span class="linkText">Raghu Kallala</span>
            
        </a>
        
    
    






                            Closed
                            














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-1925-1">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-1925-1
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-1925-1"></a>
    

</span>


                        </td>
                    </tr>
                    
                </table>
        ]]>
        </description>
</item>


    
    



                
            

            

            

            

            

        
    
        

        

        
            

            

            

            

            
                
                
                    
                        
                        
                    
                    
                
                














    
        












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-1925-1: reviewers finished</title>
        <pubDate>Wed, 21 Jan 2026 09:46:06 -0800</pubDate>
        <author></author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                    <tr>
                        <td>
                            
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/mgarthwaite?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/mgarthwaite"  title="">
        
                <span class="linkText">Michael Garthwaite</span>
            
        </a>
        
    
    






                                
                            

                            finished reviewing 















    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-1925-1">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-1925-1
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-1925-1"></a>
    

</span>


                        </td>
                    </tr>
                    <tr>
                        <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                            LEAHI-DD-FIRMWARE-LDT-1925_IOFP - Understand lag in P16 flow measurement vs. P7 flow measurement after RO pump startup
                        </td>
                    </tr>
                </table>
        ]]>
        </description>
</item>


    
    


            

            

            

        
    
        

        

        
            

            

            

            

            
                
                
                    
                        
                        
                    
                    
                
                














    
        












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-1925-1: reviewers finished</title>
        <pubDate>Tue, 20 Jan 2026 14:19:07 -0800</pubDate>
        <author></author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                    <tr>
                        <td>
                            
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/snash?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/snash"  title="">
        
                <span class="linkText">Sean Nash</span>
            
        </a>
        
    
    






                                
                            

                            finished reviewing 















    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-1925-1">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-1925-1
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-1925-1"></a>
    

</span>


                        </td>
                    </tr>
                    <tr>
                        <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                            LEAHI-DD-FIRMWARE-LDT-1925_IOFP - Understand lag in P16 flow measurement vs. P7 flow measurement after RO pump startup
                        </td>
                    </tr>
                </table>
        ]]>
        </description>
</item>


    
    


            

            

            

        
    
        

        

        
            

            

            

            
                
                

























    

    
        
            












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-1925-1: comment by Raghu Kallala &#034;Updated&#034;</title>
        <pubDate>Tue, 20 Jan 2026 14:14:53 -0800</pubDate>
        <author>Raghu Kallala</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26471</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26471</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                        <tr>
                            <td>
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/rkallala?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/rkallala"  title="">
        
                <span class="linkText">Raghu Kallala</span>
            
        </a>
        
    
    






                                
                                    
                                        <a href="https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26471">replied</a> to
                                        <span title="Should we rename this function to &#034;isROPumpLowf...">
                                            




































    
        
            
        
        
    
    








    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user  userorcommitter-parent"  href="/user/snash"  title="">
        
                <span class="linkText">Sean Nash</span>
            
        </a>
        
    
    






                                        </span>
                                        in
                                    
                                    
                                
                                














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-1925-1">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-1925-1
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-1925-1"></a>
    

</span>


                            </td>
                        </tr>
                        <tr>
                            <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                                <p>Updated</p>
                            </td>
                        </tr>
                    </table>
        ]]>
        </description>
</item>


        
        
    


                
            

            

            

            

        
    
        

        

        
            

            

            

            
                
                

























    

    
        
            












<item>
        <title>LEAHI-DD-FIRMWARE-LDT-1925-1: comment by Raghu Kallala &#034;Added&#034;</title>
        <pubDate>Tue, 20 Jan 2026 14:14:43 -0800</pubDate>
        <author>Raghu Kallala</author>
        <link>https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26470</link>

        <guid isPermaLink="false">https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26470</guid>
        <description>
        <![CDATA[
            <table width="100%" cellpadding="5px">
                        <tr>
                            <td>
                                




































    
        
            
        
        
    
    




    
        
        
            
        
        
    
    
    





    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user avatar userorcommitter-parent" style='background-image:url(https://devapps.diality.us/avatar/rkallala?s=16);
        padding-left:20px ;
        
        background-repeat: no-repeat; background-position: 0 0;' href="/user/rkallala"  title="">
        
                <span class="linkText">Raghu Kallala</span>
            
        </a>
        
    
    






                                
                                    
                                        <a href="https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26470">replied</a> to
                                        <span title="Should we have a comment for this one too?">
                                            




































    
        
            
        
        
    
    








    
        
    
    
    





    
        
            
                
            
            
            
        
        <a class="user  userorcommitter-parent"  href="/user/snash"  title="">
        
                <span class="linkText">Sean Nash</span>
            
        </a>
        
    
    






                                        </span>
                                        in
                                    
                                    
                                
                                














    


    


    
    

    


    


<span class=" crulinkspan"
       >

    
    
    
        
        
        
            
                
                    <a class="drop-review reviewClosed" href="/cru/LEAHI-DD-FIRMWARE-LDT-1925-1">
                
                
            
        
        LEAHI-DD-FIRMWARE-LDT-1925-1
        <input type="hidden" class="permaId" value="LEAHI-DD-FIRMWARE-LDT-1925-1"></a>
    

</span>


                            </td>
                        </tr>
                        <tr>
                            <td style="border-top: 1px solid #CCC; border-bottom: 1px solid #CCC">
                                <p>Added</p>
                            </td>
                        </tr>
                    </table>
        ]]>
        </description>
</item>


        
        
    


                
            

            

            

            

        
    

</channel>











</rss>
