by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. else, just a PI control signal would work. (something similar to Feed forward enabled flag)

nope. removed.

fixed

fixed

fixed

fixed

Add blank line before return.

Add blank line after declarations.

Why U32? Why not RECOVER_STATE_T?

Lower case x

Is blood flow in need of a PID controller too?

· /firmware/App/Controllers/RinsePump.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/OperationModes.h	(-2, +2)	| History	| Source	| Diff

]]> Fri, 03 Apr 2026 09:31:01 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Vendor - TEL - Jashwant Gantyada Closed LEAHI-DD-FIRMWARE-LDT-3627-1 ]]> Fri, 03 Apr 2026 08:32:42 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3627-1 LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valves sensed state values in the broadcast are always 1 ]]> Thu, 02 Apr 2026 15:35:36 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3627-1 LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valves sensed state values in the broadcast are always 1 ]]> Tue, 31 Mar 2026 09:36:56 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Sean Nash added Michael Garthwaite and Vinayakam Mani to LEAHI-DD-FIRMWARE-LDT-3627-1 LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valves sensed state values in the broadcast are always 1 ]]> Mon, 30 Mar 2026 16:37:38 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/changelog/dd-firmware?cs=dc3485eb476a2b2a3be335b179e087beeee8e8fe https://devapps.diality.us/changelog/dd-firmware?cs=dc3485eb476a2b2a3be335b179e087beeee8e8fe Vendor - TEL - Jashwant Gantyada committed dc3485e on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-2004-dialysate-composition-dosing-control--dd and 17 more in dd-firmware LDT-3627 reversed valve state enum to match other modules

· /firmware/App/Controllers/Valves.c	(-3, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/Valves.h	(-2, +2)	| History	| Source	| Diff

]]> Wed, 25 Mar 2026 11:16:55 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3218-4 ]]> Wed, 25 Mar 2026 04:01:46 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-13 ]]> Thu, 19 Mar 2026 15:47:06 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-11 ]]> Mon, 16 Mar 2026 13:52:13 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3627-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3627-1 ]]> Fri, 20 Feb 2026 17:07:01 -0800 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3552-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3552-1 Dara Navaei Closed LEAHI-DD-FIRMWARE-LDT-3552-1 ]]> Fri, 20 Feb 2026 15:12:22 -0800 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=dc4b4fddff7b3ceb6de191eed9c181d2508544ee https://devapps.diality.us/changelog/dd-firmware?cs=dc4b4fddff7b3ceb6de191eed9c181d2508544ee Dara Navaei committed dc4b4fd on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 43 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/Valves.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/BloodLeakDriver.h	(-2, +2)	| History	| Source	| Diff

]]> Fri, 20 Feb 2026 14:46:13 -0800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3552-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3552-1 Vendor - TEL - Arpita Srivastava and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3552-1 LEAHI-DD-FIRMWARE-LDT-3552_The FW Message List generated aren't able to decode some messages ]]> Fri, 20 Feb 2026 14:41:35 -0800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3552-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3552-1 Sean Nash added Vendor - TEL - Arpita Srivastava to LEAHI-DD-FIRMWARE-LDT-3552-1 LEAHI-DD-FIRMWARE-LDT-3552_The FW Message List generated aren't able to decode some messages ]]> Thu, 19 Feb 2026 11:24:40 -0800 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=9163776b3940f1b8330d152e54617396e179bfca https://devapps.diality.us/changelog/dd-firmware?cs=9163776b3940f1b8330d152e54617396e179bfca Dara Navaei committed 9163776 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 44 more in dd-firmware LDT-3552 updated the array of the DD valves structure

· /firmware/App/Controllers/Valves.h

(-6, +1)

| History

| Source

| Diff

]]> Tue, 17 Feb 2026 10:16:37 -0800 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3552-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3552-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3552-1 ]]>