Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

Declare local variables at top of scope.

Add space between ( and ?

Remove blank line.

Why redeclare result?

Remove blank line.

Why are you redeclaring result? This assignment will not survive outside of the if statement.

Remove blank line.

Remove blank line.

· /firmware/App/Controllers/BalancingChamber.c	(-0, +18)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-20, +19)	| History	| Source	| Diff
· /firmware/App/DDCommon.h	(-0, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.c	(-7, +35)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.h	(-1, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-1, +2)	| History	| Source	| Diff

]]> Thu, 23 Apr 2026 16:11:25 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=323024b3c7b988f4da87d3e5ef54f395db1142f8 https://devapps.diality.us/changelog/dd-firmware?cs=323024b3c7b988f4da87d3e5ef54f395db1142f8 Vendor - TEL - Sameer Poyil committed 323024b on branch LDT-3978-switch-chamber-f-conductive-lev in dd-firmware LDT-3978 addressed review comments

· /firmware/App/Controllers/Heaters.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.c	(-34, +32)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.h	(-2, +2)	| History	| Source	| Diff

]]> Thu, 23 Apr 2026 14:59:17 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Vinayakam Mani joined LEAHI-DD-FIRMWARE-LDT-3978-1 LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid ]]> Thu, 23 Apr 2026 14:56:16 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28636 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28636 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

lower? and change the D98 level sensor comment as well.

Remove empty line

Space before LVL_STATE_LOW

space inside array index.

Space inside parenthesis.

Change this to LEVEL_T enum.

Is this macro still being used? if not, delete it.

· /firmware/App/Controllers/Heaters.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/PermeateTank.c	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateFlushConcentrate.c	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateFlushPermeate.c	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.c	(-67, +101)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.h	(-16, +22)	| History	| Source	| Diff

]]> Wed, 22 Apr 2026 14:11:04 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3980-1 LEAHI-DD-FIRMWARE-LDT-3980_Dialysate Composition - FW Implementation (Dry Bicarbonate) - 1/1: ]]> Tue, 21 Apr 2026 13:01:19 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1/#c28564 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1/#c28564 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3980-1

control interval is different. Control interval must be separated else we don't get finer control on bicarb conductivity. also the dead band is different. need to figure out whether we can combine or not

This code looks very similar to bicarb code above. Do we really need separate handling?

Remove extra blank line.

Add unit of measure to definition name (e.g. _PSI). Should be done for all definitions w/ a unit of measure to prevent unit errors.