Updated

Removed

Fixed

Removed

Added alarm

Added back

Add alarm here.

Make h10DACControl a U08.

Remove extra blank line.

This looks like leftover from merge conflict. Remove this line.

What do we do if BP module reports an error? Do we just go to idle state and there is no alarm?

Thats for error register so not required now

You’re right. I should also check the busy status before transitioning to the GET_DATA state. I’ll update the measurement completion logic to first verify the busy bit is cleared, then validate the BP data response code before moving to BP_DRIVER_GET_DATA_STATE.

Why do you have {} in the cases?

You are getting bpResults, but not doing anything with them. Should you pass as parameter to checkBloodPressureReading() function?

Where are these get functions defined? I can't find them.

· /MsgDefs.h	(-2, +2)	| History	| Source	| Diff
· /TDDefs.h	(-2, +2)	| History	| Source	| Diff

]]> Thu, 21 May 2026 15:06:50 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3505-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3505-1 Vendor - TEL - Jashwant Gantyada and Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-3505-1 LEAHI-TD-FIRMWARE-LDT-3505_Heparin - TD - 04: DEV - Feature Implementation ]]> Thu, 21 May 2026 12:11:46 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29302 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29302 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-4033-1

Removed

Updated

Do we not need the module error alarm?

This is not an atomic assignment, so we have to consider thread safety.
If this driver is running from General Task (I believe it is since ModeTreatment's exec will be calling the BPModule's exec which calls this driver's exec) and if the caller to this function will also be running from General Task (I believe it is since BPModule controller is the caller), then there is no thread safety issue and we should mention in the function header brief that this function should only be called from within the General Task.
If another task is involved (e.g. Priority Task is calling this function), this function could be interrupting the get data state while it is populating bpResults with new results and the caller would get a mix of old and new results (we would not want that).

same.

same.

Just like driver state machine, we should only set a request flag to TRUE here and let the state machine handle the transition.

How do we get out of Idle state?

This should be called in all states (so in controller's exec function).