leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
The FP signals are not included in the DD-pre gen/Gen dialysate transition functions. They have handled separately in the TD Interface.

The FP signals are not included in the DD-pre gen/Gen dialysate transition functions. They have handled separately in the TD Interface.

its auto generated . should not change it manually. any way when merging its added correct value

its auto generated . should not change it manually. any way when merging its added correct value

Now we don't need this macro ?

Now we don't need this macro ?

now we are initializing sensor simultaneously?

now we are initializing sensor simultaneously?

comments missing

comments missing

comments missing

comments missing

This is not clear- please give a detailed description for this variable

This is not clear- please give a detailed description for this variable

use capital for starting letter

use capital for starting letter

please align the comments

please align the comments

please Alignment the comments

please Alignment the comments

Why the order is important here ? please document it

Why the order is important here ? please document it

do we need bracket here ? all text should start with capital

do we need bracket here ? all text should start with capital

Why a * here ?

Why a * here ?

is it write states or read state ?

is it write states or read state ?

is documentation correct ?

is documentation correct ?

You are right, modified in all places

You are right, modified in all places

FALSE?

FALSE?

FALSE?

FALSE?

FALSE?

FALSE?

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always ha...

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always happen regardless of how we got to pre-gen mode.

Add comment that these modes not (yet?) supported.

Add comment that these modes not (yet?) supported.

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.

Add blank line before return.

Add blank line before return.

Add blank line before return.

Add blank line before return.