leahi-common

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Yes. The integrity module is in leahi-fwcommon repository, and it serves both TD and DD.

Yes. The integrity module is in leahi-fwcommon repository, and it serves both TD and DD.

These are located in the integrity.c

These are located in the integrity.c

Yes the ECC checks are done in the bootloader stack.

Yes the ECC checks are done in the bootloader stack.

remove camel case for SetPoint, instead use Setpoint Update line 659 too

remove camel case for SetPoint, instead use Setpoint
Update line 659 too

Can we rename this to TREATMENT_DURATION_CONFIRM_REQUEST_PAYLOAD_T

Can we rename this to TREATMENT_DURATION_CONFIRM_REQUEST_PAYLOAD_T

Can we rename this to TREATMENT_DURATION_VALIDATE_REQUEST_PAYLOAD_T?

Can we rename this to TREATMENT_DURATION_VALIDATE_REQUEST_PAYLOAD_T?

What is the difference between the bicarbonateConcentrate and bicarbonate. Please update the comment.

What is the difference between the bicarbonateConcentrate and bicarbonate. Please update the comment.

Looks like comment for 208 and 223 are swapped?

Looks like comment for 208 and 223 are swapped?

please align the comments

please align the comments

Please update the msg id to MSG_ID_TD_TREATMENT_SET_POINT_DIALYSATE_TEMP_CHANGE_RESPONSE

Please update the msg id to MSG_ID_TD_TREATMENT_SET_POINT_DIALYSATE_TEMP_CHANGE_RESPONSE

Please break it into two lines and check other functions too.

Please break it into two lines and check other functions too.

Please break it into two lines

Please break it into two lines

Please break it into two lines

Please break it into two lines

Please break it into two lines Should the name of the message id be MSG_ID_TD_TREATMENT_UF_VOLUME_VALIDATE_RESPONSE?

Please break it into two lines
Should the name of the message id be MSG_ID_TD_TREATMENT_UF_VOLUME_VALIDATE_RESPONSE?

Please break it into two lines

Please break it into two lines

Please break it into two lines

Please break it into two lines

Please break it into two lines

Please break it into two lines

Please break it into two lines

Please break it into two lines

TREAT_PARAMS_PROPERTIES should also be an input?

TREAT_PARAMS_PROPERTIES should also be an input?

please add @param

please add @param

Shouldn't this file contain the incoming request and associate it to the corresponding function? And that function will trigger the response sending part. Declaring the response here instead seems...

Shouldn't this file contain the incoming request and associate it to the corresponding function?
And that function will trigger the response sending part.

Declaring the response here instead seems out of regular design scheme.

please align the comment

please align the comment

Updated

Updated

Removed

Removed

Fixed

Fixed

Removed

Removed