leahi-common

Clone Tools

Stats

Commits this week: 27
Total Committers: 20
Last Commit: 22 May
Commits this week: 27

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 min ago

Vinayakam Mani

I guess we can remove the "balancingChamberFillInProgress" check here.

I guess we can remove the "balancingChamberFillInProgress" check here.

3 mins ago

Sean Nash

Should use GENERIC_CONFIRMATION_REQUEST_T which already exists in OperationModes.h. This should be removed.

Should use GENERIC_CONFIRMATION_REQUEST_T which already exists in OperationModes.h. This should be removed.

5 mins ago

Vinayakam Mani

Add a comment here to wait for BC switching to go Idle state and transition to spent chamber fill state. Also, add a space after ().

Add a comment here to wait for BC switching to go Idle state and transition to spent chamber fill state. Also, add a space after ().

18 mins ago

Sean Nash

Put this back.

Put this back.

20 mins ago

Sean Nash

Need to put if condition back.

Need to put if condition back.

20 mins ago

Sean Nash

This check was correct before.

This check was correct before.

30 mins ago

Sean Nash

This doesn't look like a command - it looks like a status.

This doesn't look like a command - it looks like a status.

1 hr ago

Vinayakam Mani

Remove the TODO comment.

Remove the TODO comment.

2 hrs ago

Vinayakam Mani

align the comment.

align the comment.

2 hrs ago

Vinayakam Mani

Vendor - TEL - Sameer PoyilWhat's the value you are recommending for?

Vendor - TEL - Sameer PoyilWhat's the value you are recommending for?

2 hrs ago

Vinayakam Mani

Remove values in the comment, as they are changing during development (200ms persistence, 4 PSI low pressure, 17 PSI high pressure etc.,), instead use defined persistence, low or high threshold pre...

Remove values in the comment, as they are changing during development (200ms persistence, 4 PSI low pressure, 17 PSI high pressure etc.,), instead use defined persistence, low or high threshold pressure etc.,

2 hrs ago

Vinayakam Mani

decays to threshold level (4 PSI).

decays to threshold level (4 PSI).

2 hrs ago

Vinayakam Mani

remove all commented code.

remove all commented code.

2 hrs ago

Vinayakam Mani

Update comment. remove TODO if no more applicable.

Update comment. remove TODO if no more applicable.

2 hrs ago

Vinayakam Mani

FillWaterEndState?

FillWaterEndState?

2 hrs ago

Vinayakam Mani

Delete it.

Delete it.

2 hrs ago

Vinayakam Mani

Supply state (instead of drain). Updates Inputs and outputs across the file.

Supply state (instead of drain). Updates Inputs and outputs across the file.

2 hrs ago

Vinayakam Mani

When the BC fill completed and allow opening D65 for Chamber F fill?

When the BC fill completed and allow opening D65 for Chamber F fill?

2 hrs ago

Vinayakam Mani

Can we rename this IsDryBicartChamberFillWindowOpen? ( removing BalChamber)

Can we rename this IsDryBicartChamberFillWindowOpen? ( removing BalChamber)

2 hrs ago

Vinayakam Mani

50ms?

50ms?

2 hrs ago

Vendor - TEL - Suresh Dharnala

I checked with Vinay. It is not too early. The plan is to start DD pre-generation immediately after the Start Treatment request, while DD waits for IOFP/FP to complete permeate generation before en...

I checked with Vinay. It is not too early. The plan is to start DD pre-generation immediately after the Start Treatment request, while DD waits for IOFP/FP to complete permeate generation before entering Pre-Treatment.

2 hrs ago

Vinayakam Mani

Add comment to align with the rest of the implementation.

Add comment to align with the rest of the implementation.

3 hrs ago

Vinayakam Mani

Add outputs as well.

Add outputs as well.

4 hrs ago

Vinayakam Mani

I guess we should have some minimum speed as well as like max speed. Please work with Abhijit on worst case min speed.

I guess we should have some minimum speed as well as like max speed. Please work with Abhijit on worst case min speed.

5 hrs ago

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4500_(DD) Alarm 75 and pressure build up during Chamber H fill
LEAHI-DD-FIRMWARE-LDT-4500_(DD) Alarm 75 and pressure build up during Chamber H fill
Wednesday 15 Jul
3:03 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:
LEAHI-TD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:
9:48 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)
LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)
9:15 am

Vendor - TEL - Arpita Srivastava

Tuesday 14 Jul
11:17 pm

Sean Nash

I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmatio...

I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmation msg is received.

11:10 pm

Sean Nash

I thought we'd removed the first 3 states. Isn't install state the first state? Maybe Praneeth did that and it will show up when you merge staging into your branch.

I thought we'd removed the first 3 states. Isn't install state the first state? Maybe Praneeth did that and it will show up when you merge staging into your branch.