Fisheye on td-firmware/firmware/App/Modes/ModePreTreat.h

Fisheye on td-firmware/firmware/App/Modes/ModePreTreat.h https://devapps.diality.us/changelog/~br%3DLDT-4002-hdf-fw-implementation/td-firmware/firmware/App/Modes/ModePreTreat.h Recent activity in "td-firmware" under directory /firmware/App/Modes/ModePreTreat.h LEAHI-TD-FIRMWARE-LDT-1886-2: closed by Vendor - TEL - Praneeth Bunne Fri, 22 May 2026 15:39:48 -0700 Vendor - TEL - Praneeth Bunne https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2 Vendor - TEL - Praneeth Bunne Closed LEAHI-TD-FIRMWARE-LDT-1886-2 ]]> LEAHI-TD-FIRMWARE-LDT-1886-2: reviewers finished Fri, 22 May 2026 13:31:18 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2 Sean Nash and Vendor - TEL - Arpita Srivastava finished reviewing LEAHI-TD-FIRMWARE-LDT-1886-2 LEAHI-TD-FIRMWARE-LDT-1886_Blood Set Auto-Load and Auto-Eject - TD ]]> td-firmware (LDT-2240-disposable-tube-set-self-test): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 22 May 2026 11:47:14 -0700 Dara Navaei https://devapps.diality.us/changelog/td-firmware?cs=9cc543b1c2508280767573e20eddd94e68be1fb5 https://devapps.diality.us/changelog/td-firmware?cs=9cc543b1c2508280767573e20eddd94e68be1fb5 Dara Navaei committed 9cc543b on branch LDT-1886-blood-set-auto-load-and-auto-ej, LDT-2240-disposable-tube-set-self-test and 6 more in td-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodFlow.h (-2, +2) | History | Source | Diff

· /firmware/App/Controllers/Ejector.c (-2, +2) | History | Source | Diff

· /firmware/App/Controllers/Ejector.h (-2, +2) | History | Source | Diff

· /firmware/App/Modes/ModeInitPOST.c (-2, +2) | History | Source | Diff

· /firmware/App/Modes/ModePostTreat.c (-3, +3) | History | Source | Diff

· /firmware/App/Modes/ModePostTreat.h (-3, +3) | History | Source | Diff

· /firmware/App/Modes/ModePreTreat.c (-2, +2) | History | Source | Diff

· /firmware/App/Modes/ModePreTreat.h (-2, +2) | History | Source | Diff

· /firmware/App/Modes/OperationModes.c (-2, +2) | History | Source | Diff

· /firmware/App/Services/AlarmMgmtSWFaults.h (-2, +2) | History | Source | Diff

· /firmware/App/Services/Messaging.c (-2, +2) | History | Source | Diff

· /firmware/App/Services/StateServices/TubeSetAutoEject.c (-3, +3) | History | Source | Diff

· /firmware/App/Services/StateServices/TubeSetAutoEject.h (-3, +3) | History | Source | Diff

· /firmware/App/Services/StateServices/TubeSetInstall.c (-3, +3) | History | Source | Diff

· /firmware/App/Services/StateServices/TubeSetInstall.h (-3, +3) | History | Source | Diff

]]> LEAHI-TD-FIRMWARE-LDT-1886-2: comment by Vendor - TEL - Arpita Srivastava "We can rename priorState to previousInstallStat..." Wed, 20 May 2026 15:48:42 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2/#c29259 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2/#c29259 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-1886-2

We can rename priorState to previousInstallState.
Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "Is this the right time to zero this volume?" Wed, 20 May 2026 12:14:07 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29238 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29238 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

Is this the right time to zero this volume?

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "update total volume too?" Wed, 20 May 2026 12:13:25 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29237 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29237 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

update total volume too?

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "maybe use target rate for both." Wed, 20 May 2026 12:09:27 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29236 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29236 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

maybe use target rate for both.

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "Use #define for array size." Wed, 20 May 2026 11:41:41 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29235 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29235 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

Use #define for array size.

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "Make the 6 a #define" Wed, 20 May 2026 11:40:36 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29234 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29234 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

Make the 6 a #define

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "only 1 return statement" Wed, 20 May 2026 11:37:42 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29233 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29233 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

only 1 return statement

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "remove comma" Wed, 20 May 2026 11:35:12 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29232 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29232 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

remove comma

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "return FALSE on else" Wed, 20 May 2026 11:24:59 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29231 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29231 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

return FALSE on else

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "signal functions should return BOOL." Wed, 20 May 2026 11:24:25 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29230 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29230 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

signal functions should return BOOL.

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "Move up with rest" Wed, 20 May 2026 11:20:18 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29229 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29229 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

Move up with rest

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "Move this function to your service." Wed, 20 May 2026 11:17:28 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29228 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29228 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

Move this function to your service.

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "Add HDF state too" Wed, 20 May 2026 11:16:10 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29227 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29227 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

Add HDF state too

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "Not needed." Wed, 20 May 2026 11:09:39 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29226 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29226 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

Not needed.

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "Should always exec your bolus sm." Wed, 20 May 2026 11:06:27 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29225 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29225 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

Should always exec your bolus sm.

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "Keep 2 blank lines before banner" Wed, 20 May 2026 11:01:24 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29224 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29224 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

Keep 2 blank lines before banner

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "Add fluid bolus state" Wed, 20 May 2026 10:59:40 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29223 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29223 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

Add fluid bolus state

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "Add fluid bolus state" Wed, 20 May 2026 10:59:11 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29222 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29222 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

Add fluid bolus state

]]> LEAHI-TD-FIRMWARE-LDT-4013-1: comment by Sean Nash "FLUID_BOLUS_CMD_EVENT" Wed, 20 May 2026 10:58:34 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29221 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1/#c29221 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-1

FLUID_BOLUS_CMD_EVENT

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "These alarms are in the wrong place. Their enu..." Tue, 19 May 2026 17:38:43 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c29211 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c29211 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "Remove this blank line." Tue, 19 May 2026 17:37:01 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c29210 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c29210 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Remove this blank line.

]]> LEAHI-TD-FIRMWARE-LDT-1886-2: comment by Vendor - TEL - Arpita Srivastava "There is still merge conflict? Please resolve ..." Tue, 19 May 2026 15:36:43 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2/#c29194 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2/#c29194 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-1886-2

There is still merge conflict?
Please resolve merge conflict and build the code in your local before pushing.

]]> LEAHI-TD-FIRMWARE-LDT-1886-2: comment by Sean Nash "This merge conflict is still unresolved." Tue, 19 May 2026 15:35:43 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2/#c29193 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2/#c29193 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1886-2

This merge conflict is still unresolved.

]]> LEAHI-TD-FIRMWARE-LDT-1886-2: comment by Vendor - TEL - Arpita Srivastava "leak in the comment section." Tue, 19 May 2026 15:34:57 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2/#c29192 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2/#c29192 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-1886-2

leak in the comment section.

]]> LEAHI-TD-FIRMWARE-LDT-1886-2: comment by Sean Nash "Where is alarm 191..203?" Tue, 19 May 2026 15:34:38 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2/#c29191 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2/#c29191 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1886-2

Where is alarm 191..203?

]]> td-firmware (LDT-2240-disposable-tube-set-self-test): LDT-1886: Resolve merge conflicts Tue, 19 May 2026 15:28:16 -0700 Vendor - TEL - Praneeth Bunne https://devapps.diality.us/changelog/td-firmware?cs=b5f9997c044f5d3516ac84ce1d756705215895f5 https://devapps.diality.us/changelog/td-firmware?cs=b5f9997c044f5d3516ac84ce1d756705215895f5 Vendor - TEL - Praneeth Bunne committed b5f9997 on branch LDT-1886-blood-set-auto-load-and-auto-ej, LDT-2240-disposable-tube-set-self-test and 6 more in td-firmware LDT-1886: Resolve merge conflicts

· /firmware/App/Modes/ModePreTreat.c (-7, +55) | History | Source | Diff

· /firmware/App/Modes/ModePreTreat.h (-2, +4) | History | Source | Diff

· /firmware/App/Modes/OperationModes.c (-5, +5) | History | Source | Diff

· /firmware/App/Services/AlarmMgmtSWFaults.h (-6, +7) | History | Source | Diff

· /firmware/App/Services/Messaging.c (-1, +2) | History | Source | Diff

]]> LEAHI-TD-FIRMWARE-LDT-1886-2: comment by Vendor - TEL - Arpita Srivastava "please add bpLeftHomeTimerCounter to inputs and..." Mon, 18 May 2026 09:45:42 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2/#c29164 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2/#c29164 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-1886-2

please add bpLeftHomeTimerCounter to inputs and outputs.

]]>